From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id CD53A1B518; Thu, 4 Oct 2018 17:52:58 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Oct 2018 08:52:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,340,1534834800"; d="scan'208";a="78484353" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.113]) ([10.237.220.113]) by orsmga007.jf.intel.com with ESMTP; 04 Oct 2018 08:52:56 -0700 To: Darek Stojaczyk , dev@dpdk.org Cc: wuzhouhui250@gmail.com, pawelx.wodkowski@intel.com, gowrishankar.m@linux.vnet.ibm.com, stable@dpdk.org References: <20181003123925.6343-1-dariusz.stojaczyk@intel.com> From: "Burakov, Anatoly" Message-ID: <254f2fd2-832b-0722-cb1b-bd0a5050bd00@intel.com> Date: Thu, 4 Oct 2018 16:52:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181003123925.6343-1-dariusz.stojaczyk@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal/vfio: share the default container in multi process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2018 15:52:59 -0000 On 03-Oct-18 1:39 PM, Darek Stojaczyk wrote: > So far each process in MP used to have a separate container > and relied on the primary process to register all memsegs. > > Mapping external memory via rte_vfio_container_dma_map() > in secondary processes was broken, because the default > (process-local) container had no groups bound. There was > even no way to bind any groups to it, because the container > fd was deeply encapsulated within EAL. > > This patch introduces a new SOCKET_REQ_DEFAULT_CONTAINER > message type for MP synchronization, makes all processes > within a MP party use a single default container, and hence > fixes rte_vfio_container_dma_map() for secondary processes. > >>>From what I checked this behavior was always the same, but > started to be invalid/insufficient once mapping external > memory was allowed. > > Fixes: 73a639085938 ("vfio: allow to map other memory regions") > Cc: anatoly.burakov@intel.com > Cc: pawelx.wodkowski@intel.com > Cc: gowrishankar.m@linux.vnet.ibm.com > Cc: stable@dpdk.org > > While here, fix up the comment on rte_vfio_get_container_fd(). > This function always opens a new container, never reuses > an old one. > > Signed-off-by: Darek Stojaczyk > --- This makes things a bit funky when we consider external memory support. The same address space may or may not be mapped into the process, so we may or may not need to map things for DMA depending on whether we're mapping shared memory for DMA, or not. The previous behavior may be counter-intuitive, but it's IMO the correct one - each process has its own container and performs its own DMA mappings. -- Thanks, Anatoly