From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Timothy Redaelli <tredaelli@redhat.com>, dev@dpdk.org
Cc: stable@dpdk.org, jin.yu@intel.com
Subject: Re: [dpdk-dev] [PATCH 1/3] examples/vhost_blk: fix building with GCC 10
Date: Wed, 5 Feb 2020 16:12:03 +0100 [thread overview]
Message-ID: <25500ee7-58d7-8dfc-9f2d-064f0c81bfef@redhat.com> (raw)
In-Reply-To: <e5806189663a5bec0c326bae9ab0ed7b8f2865df.1580910264.git.tredaelli@redhat.com>
On 2/5/20 2:47 PM, Timothy Redaelli wrote:
> GCC 10 defaults to -fno-common, this means a linker error will now be
> reported if the same global variable is defined in more than one
> compilation unit.
>
> Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage sample")
> Cc: jin.yu@intel.com
> Cc: stable@dpdk.org
> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> ---
> examples/vhost_blk/vhost_blk.c | 2 ++
> examples/vhost_blk/vhost_blk.h | 4 ++--
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2020-02-05 15:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 13:47 [dpdk-dev] [PATCH 0/3] examples: " Timothy Redaelli
2020-02-05 13:47 ` [dpdk-dev] [PATCH 1/3] examples/vhost_blk: " Timothy Redaelli
2020-02-05 15:12 ` Maxime Coquelin [this message]
2020-02-05 14:12 ` [dpdk-dev] [PATCH v2 3/3] app/test-pipeline: " Timothy Redaelli
2020-02-05 14:21 ` Dumitrescu, Cristian
2020-02-05 17:05 ` [dpdk-dev] [PATCH 2/3] examples/eventdev_pipeline: " Timothy Redaelli
2020-02-05 17:05 ` [dpdk-dev] [PATCH 3/3] examples/qos_sched: " Timothy Redaelli
2020-03-04 9:37 ` [dpdk-dev] [PATCH 0/3] examples: " David Marchand
2020-03-04 10:17 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25500ee7-58d7-8dfc-9f2d-064f0c81bfef@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=jin.yu@intel.com \
--cc=stable@dpdk.org \
--cc=tredaelli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).