From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 696D65B2E for ; Thu, 2 May 2019 15:11:13 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0B5E0213BD; Thu, 2 May 2019 09:11:13 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 02 May 2019 09:11:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=CFihUHq0tEgA/tOPgQMAJfyyClE6UY/JAbU6ePFTMyQ=; b=mw4wTpo83GeF z5AuV5j51o7Q/hHf/Wzf6k2jGQU1p5Pmca+lF0ne3Wm3Jf/bF6hPW0yrXpvMqDSu MOB+mcAJWk1Nbjl2s/xi3EeyLv4AsPUn18P0DqZ9vXcjtsHp6R4Hjy3tV9uWvR0M BzV9ItYoIaZ54azFPn5BugZoANPDvBQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=CFihUHq0tEgA/tOPgQMAJfyyClE6UY/JAbU6ePFTM yQ=; b=3Gy7JW1pzvZ29fu/WrX8F1SNiVSWSodVqftdyp8OQZ98wK+2Nsfpga+C1 cGIM8AK2pF+LZH4gPdwqQRVq4Y2xLJ4zDEJ0ecn+W0eB00ML+2piNZtx1rBqgNsZ Aq2JHE0YqCfdS71kGMvlTjUPPq/XSA913cCfRVYvQSIgoTwIFJts8Hh+JwaV1rO4 w8hnR60pr1XJEWsCY04Nb2FpWAWDFiWD/OvQfLeYi9p+YXdrxjjChTvJlrPiEgNe Dkd4ohC5JnNqoJDPsr/JPz3eQIX/BEImJ5rYrHctrSVU/JSF/FvgwEi0a8+8IwuW QnzmX5b5vvhDbOD8u1Ifw5fYZNeSQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrieelgdeigecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6FFE0103C8; Thu, 2 May 2019 09:11:11 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson , Luca Boccassi Cc: dev@dpdk.org Date: Thu, 02 May 2019 15:11:10 +0200 Message-ID: <2551645.ic9nZLS4EI@xps> In-Reply-To: <20190426144838.GA26084@bsd12> References: <20190423220644.54589-1-bruce.richardson@intel.com> <181e25f512b11f6c691f58c2cfdf47a9322a5091.camel@debian.org> <20190426144838.GA26084@bsd12> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 3/4] devtools/test-meson-builds: add testing of pkg-config file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 May 2019 13:11:13 -0000 26/04/2019 16:56, Bruce Richardson: > On Wed, Apr 24, 2019 at 02:37:58PM +0100, Luca Boccassi wrote: > > On Wed, 2019-04-24 at 13:31 +0100, Bruce Richardson wrote: > > > On Wed, Apr 24, 2019 at 12:02:24PM +0100, Luca Boccassi wrote: > > > > On Wed, 2019-04-24 at 11:41 +0100, Bruce Richardson wrote: > > > > > On Wed, Apr 24, 2019 at 10:22:04AM +0100, Luca Boccassi wrote: > > > > > > On Tue, 2019-04-23 at 23:06 +0100, Bruce Richardson wrote: > > > > > > > +# > > > > > > > rather > > > > > > > than hacking our environment, just edit the .pc file prefix > > > > > > > value > > > > > > > +sed > > > > > > > -i "s|prefix=|prefix=$DESTDIR|" $PKG_CONFIG_PATH/libdpdk.pc > > > > > > > > > > > > What about just using meson's prefix option instead? Which is > > > > > > how > > > > > > it > > > > > > would be used in a real use case > > > > > > > > > > I don't think that would fully work, as my understanding is that > > > > > the > > > > > prefix > > > > > option would apply only to the /usr/local parts, but not to the > > > > > kernel > > > > > modules which would still try and install in /lib/. > > > > > > > > What about doing a meson configure -Denable_kmods=false before the > > > > ninja install? The modules are not needed for that test anyway, > > > > right? > > > > Alternatively, the kernel src dir could be symlinked in the build > > > > path, > > > > and the kernel_dir option could be used > > > > > > > > I'm just worried that the test should be as "realistic" as > > > > possible, to > > > > avoid missing something > > > > > > Yes, I did think of that too, but it does mean doing another > > > configuration > > > run in meson, and possibly a rebuild too if the rte_build_config.h > > > file > > > changes. Therefore I decided to use DESTDIR for the sake of speed > > > here. I > > > assumed there would be a pkg-config variable to adjust the output > > > paths > > > based on a sysroot, but couldn't find a suitable one. [...] > > > > There actually is a pkg-config binary option, I just tried and it works > > (it seems to be disabled by default on Debian and derivatives): -- > > define-prefix > > > Any cmdline options to pkg-config don't solve the problem here as it means > that the makefiles for any app need to be modified to use all those. It looks to be a good solution. Being able to update the DPDK install directory when building an application should be a mandatory requirement. I suggest to wrap the call to pkg-config so we can have this ability. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 98F61A0AC5 for ; Thu, 2 May 2019 15:11:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9153E5B40; Thu, 2 May 2019 15:11:14 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 696D65B2E for ; Thu, 2 May 2019 15:11:13 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0B5E0213BD; Thu, 2 May 2019 09:11:13 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 02 May 2019 09:11:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=CFihUHq0tEgA/tOPgQMAJfyyClE6UY/JAbU6ePFTMyQ=; b=mw4wTpo83GeF z5AuV5j51o7Q/hHf/Wzf6k2jGQU1p5Pmca+lF0ne3Wm3Jf/bF6hPW0yrXpvMqDSu MOB+mcAJWk1Nbjl2s/xi3EeyLv4AsPUn18P0DqZ9vXcjtsHp6R4Hjy3tV9uWvR0M BzV9ItYoIaZ54azFPn5BugZoANPDvBQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=CFihUHq0tEgA/tOPgQMAJfyyClE6UY/JAbU6ePFTM yQ=; b=3Gy7JW1pzvZ29fu/WrX8F1SNiVSWSodVqftdyp8OQZ98wK+2Nsfpga+C1 cGIM8AK2pF+LZH4gPdwqQRVq4Y2xLJ4zDEJ0ecn+W0eB00ML+2piNZtx1rBqgNsZ Aq2JHE0YqCfdS71kGMvlTjUPPq/XSA913cCfRVYvQSIgoTwIFJts8Hh+JwaV1rO4 w8hnR60pr1XJEWsCY04Nb2FpWAWDFiWD/OvQfLeYi9p+YXdrxjjChTvJlrPiEgNe Dkd4ohC5JnNqoJDPsr/JPz3eQIX/BEImJ5rYrHctrSVU/JSF/FvgwEi0a8+8IwuW QnzmX5b5vvhDbOD8u1Ifw5fYZNeSQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrieelgdeigecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6FFE0103C8; Thu, 2 May 2019 09:11:11 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson , Luca Boccassi Cc: dev@dpdk.org Date: Thu, 02 May 2019 15:11:10 +0200 Message-ID: <2551645.ic9nZLS4EI@xps> In-Reply-To: <20190426144838.GA26084@bsd12> References: <20190423220644.54589-1-bruce.richardson@intel.com> <181e25f512b11f6c691f58c2cfdf47a9322a5091.camel@debian.org> <20190426144838.GA26084@bsd12> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 3/4] devtools/test-meson-builds: add testing of pkg-config file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190502131110.ayDJWhthAWjYyFQVPBLaBuyR11xQbgkR9bWyNKgxQjY@z> 26/04/2019 16:56, Bruce Richardson: > On Wed, Apr 24, 2019 at 02:37:58PM +0100, Luca Boccassi wrote: > > On Wed, 2019-04-24 at 13:31 +0100, Bruce Richardson wrote: > > > On Wed, Apr 24, 2019 at 12:02:24PM +0100, Luca Boccassi wrote: > > > > On Wed, 2019-04-24 at 11:41 +0100, Bruce Richardson wrote: > > > > > On Wed, Apr 24, 2019 at 10:22:04AM +0100, Luca Boccassi wrote: > > > > > > On Tue, 2019-04-23 at 23:06 +0100, Bruce Richardson wrote: > > > > > > > +# > > > > > > > rather > > > > > > > than hacking our environment, just edit the .pc file prefix > > > > > > > value > > > > > > > +sed > > > > > > > -i "s|prefix=|prefix=$DESTDIR|" $PKG_CONFIG_PATH/libdpdk.pc > > > > > > > > > > > > What about just using meson's prefix option instead? Which is > > > > > > how > > > > > > it > > > > > > would be used in a real use case > > > > > > > > > > I don't think that would fully work, as my understanding is that > > > > > the > > > > > prefix > > > > > option would apply only to the /usr/local parts, but not to the > > > > > kernel > > > > > modules which would still try and install in /lib/. > > > > > > > > What about doing a meson configure -Denable_kmods=false before the > > > > ninja install? The modules are not needed for that test anyway, > > > > right? > > > > Alternatively, the kernel src dir could be symlinked in the build > > > > path, > > > > and the kernel_dir option could be used > > > > > > > > I'm just worried that the test should be as "realistic" as > > > > possible, to > > > > avoid missing something > > > > > > Yes, I did think of that too, but it does mean doing another > > > configuration > > > run in meson, and possibly a rebuild too if the rte_build_config.h > > > file > > > changes. Therefore I decided to use DESTDIR for the sake of speed > > > here. I > > > assumed there would be a pkg-config variable to adjust the output > > > paths > > > based on a sysroot, but couldn't find a suitable one. [...] > > > > There actually is a pkg-config binary option, I just tried and it works > > (it seems to be disabled by default on Debian and derivatives): -- > > define-prefix > > > Any cmdline options to pkg-config don't solve the problem here as it means > that the makefiles for any app need to be modified to use all those. It looks to be a good solution. Being able to update the DPDK install directory when building an application should be a mandatory requirement. I suggest to wrap the call to pkg-config so we can have this ability.