From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11D9FA04E7; Mon, 2 Nov 2020 12:01:32 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BA0B5BE87; Mon, 2 Nov 2020 12:01:30 +0100 (CET) Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com [64.147.123.17]) by dpdk.org (Postfix) with ESMTP id EE70CBE7D for ; Mon, 2 Nov 2020 12:01:28 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.west.internal (Postfix) with ESMTP id 18F07D71; Mon, 2 Nov 2020 06:01:26 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 02 Nov 2020 06:01:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= lhjBrW/KhKf19vBkQLuaSRVEsmq6o3OpuIe7CHzELrM=; b=tVEJthbxM6OpnNdw CaFs7NkxzkK7wawU2UVohl+URspFJFLgtwjqkrbGlC0+FlHARz0AvDL0L9nQmeJ1 UQwZat0kmKL6cSKasb7Ig3oD6JWeP+fOkajwMZvQEYdYvyNPoxA2BZZVcf2Dpks+ EaCy9Fc1HuGpbOxKaIl/c5TsEo7m/27Qx6P81o2g+dvQEf3rXXn7PU04Vm2ENA2p v6jyVlhYvUM2jakphUSENMUUtnj+nvk0ekNtC2FULFcgZ9zHP0R0LhDzEuzEZx/N 9H6jOupUnQbyTQZs3AmN7FskEKzUD9hHJVgEg2EFkpnwRSkYpoHDChnsUIi22Pkw X3oaEw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=lhjBrW/KhKf19vBkQLuaSRVEsmq6o3OpuIe7CHzEL rM=; b=fiaA65JmWxZc6bUtKPAs/q9oL+F6vlNUCv/2ndYGkfmsEegi9OpnD2Ltp 2QrUfy4b5eT6YS7jLtxOuhAQBAwc1HAf4+dlmNB/vOPfdIffVvdUZSVcLTgrdo8O cLXnkr2GsadG6lZP4oCq0qm3Sb0zBZnc9RzpFW1d7gLLJwjBHUmuWuwdk/EoRohY r4dty8WaDFM9Ztm8ZpK8TyGLLSB9+ncjEx/HonAfTfv4pu+WDWpv7+gmGbB+H5Ep 5+8XzgEJMTACfTMcx0YkqzGi81rATtssKHbv88wMnpVxYCLN2rvQb+5ZnWHaXHW2 rEFF1Alb0OMtmZHtq8z8mfNYhPlXA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddtuddgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AD3733280065; Mon, 2 Nov 2020 06:01:22 -0500 (EST) From: Thomas Monjalon To: Jerin Jacob , Jerin Jacob Cc: dev@dpdk.org, Ferruh Yigit , David Marchand , "Richardson, Bruce" , Olivier Matz , Andrew Rybchenko , Viacheslav Ovsiienko , Nithin Dabilpuram , Kiran Kumar K , Ray Kinsella , Neil Horman Date: Mon, 02 Nov 2020 12:01:20 +0100 Message-ID: <2551714.mDZGrADpUY@thomas> In-Reply-To: <5457970.OX1LmiOAXX@thomas> References: <20201029092751.3837177-1-thomas@monjalon.net> <5457970.OX1LmiOAXX@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 10/14] net/octeontx2: switch timestamp to dynamic mbuf field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/11/2020 10:38, Thomas Monjalon: > 01/11/2020 19:28, Jerin Jacob: > > On Sun, Nov 1, 2020 at 11:40 PM Thomas Monjalon wrote: > > > > > > The mbuf timestamp is moved to a dynamic field > > > in order to allow removal of the deprecated static field. > > > The related mbuf flag is also replaced. > > > > > > Signed-off-by: Thomas Monjalon > > > --- > [...] > > > +uint64_t rte_pmd_octeontx2_timestamp_rx_dynflag; > > > +int rte_pmd_octeontx2_timestamp_dynfield_offset = -1; > > > > Instead of the global variable, please move the offset to struct > > otx2_timesync_info(which is used in fastpath) and accessible in slow > > path. > > This structure is initialized in otx2_nix_dev_start(). > otx2_rx_timestamp_setup() is called earlier in otx2_nix_configure(). > One of the two has to change. Which one? I see that the timestamp config can be changed in otx2_nix_dev_start() so it looks I have no other choice than moving timestamp setup at "start" stage anyway. Will be done in v3, that I will send later today.