From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6758AA034F; Wed, 13 May 2020 18:31:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1A17A1D65B; Wed, 13 May 2020 18:31:05 +0200 (CEST) Received: from wnew1-smtp.messagingengine.com (wnew1-smtp.messagingengine.com [64.147.123.26]) by dpdk.org (Postfix) with ESMTP id 0C16C1D62C for ; Wed, 13 May 2020 18:31:04 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.west.internal (Postfix) with ESMTP id 19BC8778; Wed, 13 May 2020 12:31:02 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 13 May 2020 12:31:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= NeVD8wdsxTNc+D/gbK20a8xk7GkQYo9rzUpk9R6LRl0=; b=cO63KV6iX19V+IjW fQp5nq9yKfmV6SXq+LXUyr0Mdf1PGWKeAaYkrn/44CQlmvMyfpCUNug6K9izLzRu YDz5610QhmOcBzvPXkoBciQtI3oSqb03VouhuRXedehj9yui4+a/7YpZns8J0gJJ E5BjyzmTdiq4gitaXX5aVI+brSwpaOKw+kTKNlblkydTtE8FdVZxgjdyEDn3VTcr NhwoXBV1Zqb1rIJyRXT/FroXcEy6BSL9Ddz4UlTRRIr4hXl792bILlsD6sCMICEy 5FgmsXY5OZ9oGaFR8+o1Z+SKUAgfYBkPzTTRQ/suwb0Ue6B8zIBqJuHancom0nJk Btz0ag== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=NeVD8wdsxTNc+D/gbK20a8xk7GkQYo9rzUpk9R6LR l0=; b=JQQpptnE1hiPV1Wz/YZHCDdFYT/KRL6z/zTBr6joPJT0vge+J3h2Ukvz+ pPI7viczU0bh5G10Dclfdd1hI8I5Y9iBolvmpUUKRV3uRI9pq4Bk8uvsLxpeuXN3 XE62upv7N1MVSj6Fq7xYX1RvD2u40TOa+8gnSkc+odOzLNDG5Gsdd/RKBQzuRxuV 8+a9MUkfadRhSjJmEfBoIzW0FfmEoTzsSfgwDUlcLypN87fVFdITvO7dGlBYbxc0 8X3Ytm+Oq9BzVpLwC/EXhjynDPir9hqaGoGlX6MH7mYUbwLTvuaavEQxOBSMBMSk +22mZpqAOgvopK80/tAomS3HZtodw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrleeggddutddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffdvffejueetleefieeludduuefgteejleevfeekjeefieegheet ffdvkeefgedunecuffhomhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrd dvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A3F15306631E; Wed, 13 May 2020 12:30:59 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: Ray Kinsella , Neil Horman , Cristian Dumitrescu , Eelco Chaudron , dev@dpdk.org, David Marchand , Luca Boccassi , Bruce Richardson , Ian Stokes , Andrzej Ostruszka Date: Wed, 13 May 2020 18:30:57 +0200 Message-ID: <2552320.9PvXe5no7K@thomas> In-Reply-To: <20200513121149.2283385-1-ferruh.yigit@intel.com> References: <20200129164350.3724793-1-ferruh.yigit@intel.com> <20200513121149.2283385-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] meter: provide experimental alias of API for old apps X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" I think the title should be about ABI, not API. 13/05/2020 14:11, Ferruh Yigit: > Duplicate the existing and versioned symbol as experimental. Would be good to explain the case of the meter lib you are addressing. If I understand well, you consider we "broke" the experimental ABI during 20.02 when moving symbols from EXPERIMENTAL to DPDK_20.0.1 (and to DPDK_21 during 20.05). That's why you want to add back the EXPERIMENTAL symbol as an alias of the symbol in the next ABI (21). > This is to prevent DPDK maturing experimental API breaking old > applications using that experimental API. > The relevant process update is captured in: > https://patches.dpdk.org/patch/65863/ > > Created VERSION_SYMBOL_EXPERIMENTAL helper macro. > > Updated the 'check-experimental-syms.sh' buildtool, which was > complaining that the symbol is in EXPERIMENTAL tag in .map file but it > is not in the .experimental section (__rte_experimental tag is missing). > Updated tool in a way it won't complain if the symbol in the > EXPERIMENTAL tag duplicated in some other block in .map file (versioned) > > Enabled function versioning for meson build for the library. > > Fixes: 30512af820fe ("meter: remove experimental flag from RFC4115 trTCM API") Even if it's never backported, it would be more correct to add Cc: stable to indicate it is fixing previous release (20.02 here). > Signed-off-by: Ferruh Yigit [...] > --- a/lib/librte_meter/rte_meter_version.map > +++ b/lib/librte_meter/rte_meter_version.map > @@ -20,4 +20,12 @@ DPDK_21 { > rte_meter_trtcm_rfc4115_color_blind_check; > rte_meter_trtcm_rfc4115_config; > rte_meter_trtcm_rfc4115_profile_config; > + > } DPDK_20.0; > + > +EXPERIMENTAL { > + global: > + > + rte_meter_trtcm_rfc4115_config; > + rte_meter_trtcm_rfc4115_profile_config; > +}; >