From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 6111D11DE
 for <dev@dpdk.org>; Sat, 20 Jan 2018 15:49:06 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id C707820A9E;
 Sat, 20 Jan 2018 09:49:05 -0500 (EST)
Received: from frontend2 ([10.202.2.161])
 by compute1.internal (MEProxy); Sat, 20 Jan 2018 09:49:05 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=xbMckJvlrVtCBzNDgt2RiiE935
 KCeng6WI8Pzw/8JGU=; b=KWk2tttrmDEH370Qh3cQMVdnPioMJGbbZutpEr/UaF
 PvheECcA6H3IzaGINDhbogRZavxmpNOwuPhN7snz4snngH2OC++x/ERxMv+2kueb
 OFf+JDY4zuND18bqT4nxJ0bkLU1Tgfs7KeNhNsEcMp+9DX3OIqxMcW+hXfe2VK0h
 4=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=xbMckJ
 vlrVtCBzNDgt2RiiE935KCeng6WI8Pzw/8JGU=; b=Hg6nDCy0gOXZYIVVlAJmSz
 LM+3sPLHfVpH/NhUMpu4jEC2UPyAdc7uTWOELLobpjr228k/t9krQgFHEifpeiiw
 gY6K+uXFqoJD5zsPBj6ahzL4oZCflg1NgEgfNKPZ5AYDnLslfE813JeXP1fDPZpV
 MKQIHOGJ/WkswYWZwOnD2O9XI6tFIgbIFyg1i+5N19L6bfv4nQP9Oc3siFPKqLyh
 MOBQlKQzg+xetIfwegHDzFHHV9W2rA3rCX4tDAp7BQ9n3hRehQl5YIAInAH8ezmE
 zDz70Fqrzdc5i6z3efopoqsHOnPjUGQHdwBt5rwcUp72Y9vBzdMPcF9u/rdG1CyA
 ==
X-ME-Sender: <xms:4VZjWoMNqcaz1pV7yLhGa3b3XgCfwPHrO5sWK89qXNDinzVz-oreNw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 7627624636;
 Sat, 20 Jan 2018 09:49:05 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
 Jonas Pfefferle <jpf@zurich.ibm.com>
Cc: dev@dpdk.org, anatoly.burakov@intel.com
Date: Sat, 20 Jan 2018 15:48:30 +0100
Message-ID: <2553597.NGuM8CDarU@xps>
In-Reply-To: <8831fc88-0f0d-b89e-5d19-a12983b243cf@redhat.com>
References: <1509465586-7436-1-git-send-email-jpf@zurich.ibm.com>
 <8831fc88-0f0d-b89e-5d19-a12983b243cf@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 20 Jan 2018 14:49:06 -0000

19/01/2018 18:37, Maxime Coquelin:
> 
> On 10/31/2017 04:59 PM, Jonas Pfefferle wrote:
> > Check and report errors on open/read in noiommu check.
> > 
> > Signed-off-by: Jonas Pfefferle <jpf@zurich.ibm.com>
> > ---
> >   lib/librte_eal/linuxapp/eal/eal_vfio.c | 29 +++++++++++++++++++++--------
> >   1 file changed, 21 insertions(+), 8 deletions(-)
> 
> I agree with the fix, Kernels v4.4 and earlier does have vfio, but not
> the noiommu mode, so the file does not exist.
> 
> Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Applied, and added this explanation, thanks