From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, david.marchand@redhat.com, ferruh.yigit@intel.com,
jerinj@marvell.com, stephen@networkplumber.org
Subject: Re: [dpdk-dev] [PATCH] kernel: remove igb_uio
Date: Tue, 08 Sep 2020 11:27:23 +0200 [thread overview]
Message-ID: <2557168.Xcie88ISVP@thomas> (raw)
In-Reply-To: <20200908082557.GC351@bricha3-MOBL.ger.corp.intel.com>
08/09/2020 10:25, Bruce Richardson:
> On Tue, Sep 08, 2020 at 02:14:02AM +0200, Thomas Monjalon wrote:
> > On Tue Sep 8, 2020 at 2:50 AM CEST, Thomas Monjalon wrote:
> > > As decided in the Technical Board in November 2019,
> > > the kernel module igb_uio is moved to the dpdk-kmods repository
> > > in the /linux/igb_uio/ directory.
> >
> > The code is moved with its git history in
> > http://git.dpdk.org/dpdk-kmods/
> >
> > The move process started with these commands:
> > cd dpdk
> > dir=igb_uio
> > path1=lib/librte_eal/linuxapp/$dir
> > path2=kernel/linux/$dir
> > git format-patch -o $dir 0c9a540ed2.. -- $path1 $path2
> > find $dir -type f -exec sed -i "s,$path1\|$path2,linux/$dir," '{}' \;
> > cd ../dpdk-kmods
> > git am ../dpdk/$dir/*
> > git filter-branch --force
> > --index-filter "git rm --cached --ignore-unmatch linux/$dir/Makefile"
> > --prune-empty --tag-name-filter cat -- --all
> >
> > Makefile and meson.build files were not imported at all.
> > Some other commits were skipped (virtio, vmxnet3 and Xen dom0 support),
> > because they were not very useful and reverted later in the history.
> > Anyway the original history is available forever in dpdk.git.
> >
> > Currently it cannot compile because the file rte_pci_dev_feature_defs.h
> > is missing, defining enum rte_intr_mode. An option is to import this file.
> >
> > It would be nice to add a README file in the new igb_uio directory.
> > Volunteers welcome :)
>
> In terms of building the module, one option which I think is worth
> considering is to try and use meson subject/wrap support to download and
> build this module as part of the main DPDK build, as now, when enable_kmods
> option is set. With a wrap file in DPDK it can automatically pull down and
> build the code as part of a main project build. I assume that integration
> into main DPDK build is still something worth having? The only thing I
> don't like about using a wrap file is that it has to be placed in a folder
> called "subproject" at the top level of the DPDK project.
The idea is encouraging the use of VFIO and make igb_uio deprecated.
I think we should not do any effort to ease igb_uio usage inside dpdk.git.
Compiling the kernel module standalone in dpdk-kmods.git looks enough, isn't it?
next prev parent reply other threads:[~2020-09-08 9:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 22:50 Thomas Monjalon
2020-09-08 0:14 ` Thomas Monjalon
2020-09-08 8:25 ` Bruce Richardson
2020-09-08 9:27 ` Thomas Monjalon [this message]
2020-09-08 9:34 ` Bruce Richardson
2020-09-08 9:46 ` Thomas Monjalon
2020-09-08 12:06 ` Ferruh Yigit
2020-09-11 12:22 ` Thomas Monjalon
2020-09-11 15:54 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2020-09-11 16:22 ` Ferruh Yigit
2020-09-12 8:55 ` Thomas Monjalon
2020-09-14 9:47 ` Ferruh Yigit
2020-09-24 5:41 ` Stephen Hemminger
2020-10-05 8:57 ` Thomas Monjalon
2020-10-05 9:11 ` Maxime Coquelin
2020-10-05 9:56 ` Bruce Richardson
2020-10-10 7:23 ` 谢华伟(此时此刻）
2020-10-05 9:38 ` [dpdk-dev] [PATCH v3] " Thomas Monjalon
2020-10-05 9:42 ` [dpdk-dev] [PATCH v4] kernel/linux: " Thomas Monjalon
2020-10-05 10:14 ` Andrew Rybchenko
2020-10-05 11:14 ` Jerin Jacob
2020-10-06 10:16 ` Ferruh Yigit
2020-10-06 10:54 ` Thomas Monjalon
2020-10-06 11:09 ` Ferruh Yigit
2020-10-06 12:49 ` Thomas Monjalon
2020-10-06 12:54 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2557168.Xcie88ISVP@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).