From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6A6FA0032; Tue, 28 Sep 2021 11:05:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A2A0040E3C; Tue, 28 Sep 2021 11:05:02 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 238F940DF6 for ; Tue, 28 Sep 2021 11:05:01 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 651325C00EF; Tue, 28 Sep 2021 05:05:00 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 28 Sep 2021 05:05:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= KylgH5RTpjfhNT8LxR80EJcPNcXMGEEYxfTj+DxASsk=; b=IlS6DKjDkSnsdbCd zZ2z4atXGj6nkQg8IU2KW+ykW9V8H5dD4nHYbdIiuw/9fP29mzdGOjumTTLNFz45 7RvPxLFyibDEl71lMJtDh+h8rEKJUYlsNlAi/XlFzMbelkukNlK8lTqLzRIpji2o kTR/0asWYM7JtFQeHVUEXpnubk4YD6l8pXvMIvfhzNqpYUPFx8YElxWj684d1kM1 1Cz1+uYbztz5qXi5WUcDj38XUwUh1IuyOZSRBCOFZvVxqTLpyG21BcI8TBuIuxvE Lm1Z7UmlOYONr1hEt+Rajfue55vSB4a1gszQ4yLEknX/Xn6RH/bSFQTOalxMKA5z rC2SIg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=KylgH5RTpjfhNT8LxR80EJcPNcXMGEEYxfTj+DxAS sk=; b=TSp5TEmIOnPbk6NhJlrmyJMTH2HtfR4D5KM8Tu5KP6z6kKEh+dT0vjScb qYAUq/Qd8qmgnLL4l/4RnMB0Z5hnf/d1+0IDQDVIHVFuVOpR46ZX0DCHXL8TziNP btdfzAB3iBcct6GKvgNONj4TESrGIr86XouRPGOnzNY9hN/SBJN+QHbuvKiv9ESd FD5gE/q/gN2ncWOf4e/DNfJzA8aDKrl51hHpnFlBtVKpCJDMeO2Ji5jtsqacOVXl ZCXlnUPXIpT+p1e6FkW7i14fOIhAazkDYhQabu3K3lYusHrXJBSg4lOTgQTP3IT6 kh5bfZdQ5VcvK8WCafH5VUJ7y4q7g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudektddgtdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhephfeugfeufeehueejhefhjefftdekveeivdffjedukeejudehffeh gfehgeduudehnecuffhomhgrihhnpehpmhgurdhnvghtnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdr nhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 28 Sep 2021 05:04:59 -0400 (EDT) From: Thomas Monjalon To: Xueming Li , David Marchand , Gaetan Rivet Cc: dev , Asaf Penso , Ferruh Yigit , Andrew Rybchenko Date: Tue, 28 Sep 2021 11:04:57 +0200 Message-ID: <2557544.gBOyUbuW4X@thomas> In-Reply-To: References: <1608304614-13908-2-git-send-email-xuemingl@nvidia.com> <1618283653-16510-6-git-send-email-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 5/5] devargs: parse global device syntax X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/09/2021 10:29, David Marchand: > On Tue, Apr 13, 2021 at 5:15 AM Xueming Li wrote: > > > > When parsing a devargs, try to parse using the global device syntax > > first. Fallback on legacy syntax on error. > > > > Example of new global device syntax: > > -a bus=pci,addr=82:00.0/class=eth/driver=mlx5,dv_flow_en=1 > > > > Signed-off-by: Xueming Li > > Reviewed-by: Gaetan Rivet > > Starting with a virtio user port, I get a warning: > > # dpdk-testpmd --vdev > net_virtio_user0,iface=test,path=/dev/vhost-net,queues=1 > --log-level=pmd.net.virtio.*:debug -- -i > ... > EAL: Unrecognized layer dev/vhost-net,queues=1 > ... > > Am I doing something wrong? > If not, could you have a look? The new global syntax is using the slash / as separator. We should detect legit use of slash in a path. Here, the value starts with a slash so it should be easy to ignore. Another way is to consider slash only if followed by "class=" or "driver="