From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id AF39E2C8 for ; Tue, 27 Jun 2017 01:20:43 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3756020F53; Mon, 26 Jun 2017 19:20:43 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 26 Jun 2017 19:20:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=53nQWFRkVUl70gj c7Rv4bBuCimiggWMlJGtmhLLikx0=; b=GkceYPI5AhK7BBt/wMroJWMba+RcFwE 9/sEY2z2C3ry4HJOUy7lzXkt0TIVKM8ONDHmUXmA1oqnv7GpPtMVDINyasz/ISnQ axqMORm61icWwpa9JF+BOlHtnlad4h36FAXYG4Sqm2ObnDs3tBL9+QdL+L1Kx9Ff 1sFvVp3gBFA8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=53nQWFRkVUl70gjc7Rv4bBuCimiggWMlJGtmhLLikx0=; b=ClycRkx3 eQUTr50nV8tF9KLeT1AXj7kTgMi3poQt4nDPuqHp10AQbWrno8kBCglnfvI2wzQQ u29lLbpEiX4Ejlrk05n0RwrgCMuLLO8RLQrPUzPrOw7o7ghaPoi3LTXiT1iaoAQq HyEw151QZk/gsVHMyclmPdhr7LLIcH9GmvxKo27UukRKdOf9QOE3xBdJF2HJJb7Z 8M4KVZP9TA3yem0AJ+x4GFO+v48GYTZ2wQKwwLWOxQjdp7bFd4xTx14db6FPkVkb KKxCxx3FknuTDSxDp/QUK5NJE7il7PNbzHHRGgxMacks6hknVSdFR5LBeL7hFrY1 NOHTgw3h6/O5Cw== X-ME-Sender: X-Sasl-enc: 16s+LCaJRXIEx9qTyJyDGaFTLGbQSTP+mrtfDp3WFKha 1498519242 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E2AB67E51B; Mon, 26 Jun 2017 19:20:42 -0400 (EDT) From: Thomas Monjalon To: Luca Boccassi Cc: dev@dpdk.org, lboccass@brocade.com Date: Tue, 27 Jun 2017 01:20:42 +0200 Message-ID: <2558671.pWjLEmoHCY@xps> In-Reply-To: <20170623184153.24488-8-lboccass@brocade.com> References: <20170623181616.16981-1-lboccass@brocade.com> <20170623184153.24488-1-lboccass@brocade.com> <20170623184153.24488-8-lboccass@brocade.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 7/8] mk: sort object files when building deps lists X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jun 2017 23:20:44 -0000 23/06/2017 20:41, lboccass@brocade.com: > From: Luca Boccassi > > In order to achieve reproducible builds, always use the same > order when listing object files to build dependencies lists. > > Signed-off-by: Luca Boccassi > --- > mk/rte.app.mk | 4 ++-- > mk/rte.hostapp.mk | 4 ++-- > mk/rte.shared.mk | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) > > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -263,8 +263,8 @@ LDLIBS_NAMES += $(patsubst -Wl$(comma)-l%,lib%.a,$(filter -Wl$(comma)-l%,$(LDLIB > > # list of found libraries files (useful for deps). If not found, the > # library is silently ignored and dep won't be checked > -LDLIBS_FILES := $(wildcard $(foreach dir,$(LDLIBS_PATH),\ > - $(addprefix $(dir)/,$(LDLIBS_NAMES)))) > +LDLIBS_FILES := $(sort $(wildcard $(foreach dir,$(LDLIBS_PATH),\ > + $(addprefix $(dir)/,$(LDLIBS_NAMES))))) You cannot sort libraries. Check - for instance - this comment above in this file: # Eliminate duplicates without sorting, only keep the last occurrence filter-libs = \ Why sorting them? What is random in libraries list?