From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
[66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 2A6C91C8D1
for <dev@dpdk.org>; Mon, 14 May 2018 16:59:05 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id C0F99223A6;
Mon, 14 May 2018 10:59:04 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute1.internal (MEProxy); Mon, 14 May 2018 10:59:04 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:content-transfer-encoding:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc; s=mesmtp; bh=0HXMpkuqP/PgVzQSwSa7xgbZyb
Ma3JZ5CoXw/X8+AE0=; b=P7gX9ZSkBhzY/JY5CPuFvIw3tw5PfdMAkQr5vCHyw7
B5EmtrtgVgnv61BcKw73gduF3/zaALMAvy944F3It7X+oqm4cy2/ff8caY3M4Gep
SGpDIHnjMTmG3VxyX9eFtDsJXWAQsm4G6yckRFEZY1+LVbbRbn9H/Ue6j/7C31Cn
k=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=0HXMpk
uqP/PgVzQSwSa7xgbZybMa3JZ5CoXw/X8+AE0=; b=hVhYY0Hh5KZ9E80Vx9A3gk
8ufUbYmnF8kW6I3OfT1mJgSQ5pUcZVlouuTqoKydY//u/gVdeHAt7o4LSutndR76
x1uabtYR4hFSLS6V/YNJeAaHFRU2d7LRg+C/xuoddjjZmNHuLPqOpyQamngq88lX
FsyOCI55OjBp5yH70u7qyi3oHSbV089LvmAw09+MYqJgyeiV7ar6edFUY1Rz09dj
TeKVWLbSOwgqX72BRVyybZIAVKjLFTgjKfhd2Ltqx/POPBzFkUwgmcQmlUZ1/Nma
l4ARvxea1zkhCv7irL6tgy6EzsIkfa1Bx7Uqp/V4OFUZCPRi6p1PUn2l9kkBAtNA
==
X-ME-Sender: <xms:OKT5Wj3I0gGz7ZG69UbXUsoG1FYYQeNVZW1I1AynaSXaQjbI3dltuw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 5465CE4123;
Mon, 14 May 2018 10:59:04 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Date: Mon, 14 May 2018 16:59:03 +0200
Message-ID: <2561984.NlRDZHRkjG@xps>
In-Reply-To: <2601191342CEEE43887BDE71AB977258AEDC72E8@irsmsx105.ger.corp.intel.com>
References: <4850625.lUN5xUOOBk@xps> <2420395.OS6qY2Y8eq@xps>
<2601191342CEEE43887BDE71AB977258AEDC72E8@irsmsx105.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] bpf: add missed EXPERIMENTAL tags
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 14 May 2018 14:59:05 -0000
14/05/2018 16:55, Ananyev, Konstantin:
>
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > Sent: Monday, May 14, 2018 3:31 PM
> > To: Ananyev, Konstantin <konstantin.ananyev@intel.com>
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] bpf: add missed EXPERIMENTAL tags
> >
> > 14/05/2018 15:15, Konstantin Ananyev:
> > > - add EXPERIMENTAL tag for the section in MAINTAINERS.
> > > - add EXPERIMENTAL tag to BPF public API files.
> > > - add attribute __rte_experimental to BPF public API declarations.
> > >
> > > Fixes: 94972f35a02e ("bpf: add BPF loading and execution framework")
> > > Fixes: 5dba93ae5f2d ("bpf: add ability to load eBPF program from ELF")
> > > Fixes: a93ff62a8938 ("bpf: add BPF loading and execution framework")
> > >
> > > Reported-by: Thomas Monjalon <thomas@monjalon.net>
> > > Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> > > ---
> > > MAINTAINERS | 2 +-
> > > lib/librte_bpf/rte_bpf.h | 26 ++++++++++++++++----------
> > > lib/librte_bpf/rte_bpf_ethdev.h | 15 ++++++++++-----
> > > 3 files changed, 27 insertions(+), 16 deletions(-)
> >
> > You need to add __rte_experimental in function definitions too (.c file).
>
> I believe that was done in initial commit.
I did not check, sorry.
> > There is a tool to check it: buildtools/check-experimental-syms.sh
> >
>
> ./buildtools/check-experimental-syms.sh lib/librte_bpf/rte_bpf_version.map x86_64-native-linuxapp-gcc-meson/lib/librte_bpf.a
>
> Don't produce any errors/warnings for me.
> Do I miss something here?
No, it's me doing wrong assumption :)