From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 793A2568A for ; Tue, 8 Dec 2015 11:04:29 +0100 (CET) Received: by wmww144 with SMTP id w144so174462406wmw.1 for ; Tue, 08 Dec 2015 02:04:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=Mifk96QY1c27KQaIHj1a1YnN2PKvcFhommffX38vLTI=; b=r6ofNQO0hZFvzA+vA7CsIKOWkMzNhhZYqYLyGEwtFRTjGf0yMy+QJwKdK/x/q0FOZr veL3lZ337sbTuhESKs1GaWBSpj87XD4PB9iEEn4ygKjlZF/G37wtK/wtKCd3mXxdYLV+ zZmjgUJ/Q7xKtfVlK57ggsWa2GMsw716SLM/FMAEu6yXLtqGRVGtDgiRpZnVMXqbZkIC wDNi2t3tYJ5bQC1c9IWmfMJdfSZgJEkeLvryuo6YjwdT+kPYHqRstxdw6f1FyAYyaosL jAqJgCKopHFwK9ThtV0VJQ7mgvNNxjY+gmOwnRaupR6fZGDJ8qS1D7k1Vh5qVsXV6AHm +2fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Mifk96QY1c27KQaIHj1a1YnN2PKvcFhommffX38vLTI=; b=BS58C0k5URVLmSsklz89Ot8KJVbtoF68KmpUMl/3fkgPMKGKzyrFClgr3vswJukJ7e +uP+0wSJwS/PUziO+W/omBH6R7sASqWOpMPvqWyovtWYYa8HAC3aZbbpE+ScZsL7xait gbjSSZ5d/wrTOzg866MT546QxWMYpgwbojUCgW9h88cvdHybJp4+loqUcsEwA4t23EpB k/+Qmsv/TgTnEdPKgS8c7Nsfc9kQnzQmlNMDIpappZ74ZDrBxLIadD+kFWLJ5P+G9WN+ iI/blOeie0K8DSYGfy2dO0BMgV7+V8ujzAF5hpnk9sIweZocgI+qWdudEI2R8Pr5BA+O Ii7Q== X-Gm-Message-State: ALoCoQkzqx+r53mrKtvceEGseOAsn9aUgdPGU0PbA3DWwfCbGU/aWRAvDESoU7Vj9MAc0XMOyVphkEDpZrXOrWnFlJOCBhVS4g== X-Received: by 10.28.194.133 with SMTP id s127mr2720143wmf.53.1449569069333; Tue, 08 Dec 2015 02:04:29 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id h67sm20561553wmf.17.2015.12.08.02.04.28 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 08 Dec 2015 02:04:28 -0800 (PST) From: Thomas Monjalon To: Jianbo Liu Date: Tue, 08 Dec 2015 11:03:16 +0100 Message-ID: <2562409.c2PxG9doT8@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1448995276-9599-1-git-send-email-jianbo.liu@linaro.org> <4116700.gN3RbU5N65@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 2/3] eal/acl: enable acl for armv7-a X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Dec 2015 10:04:29 -0000 2015-12-08 15:56, Jianbo Liu: > On 8 December 2015 at 10:23, Thomas Monjalon wrote: > > 2015-12-08 09:50, Jianbo Liu: > >> On 8 December 2015 at 09:18, Thomas Monjalon wrote: > >> > 2015-12-03 23:02, Jianbo Liu: > >> >> -ifeq ($(CONFIG_RTE_ARCH_ARM64),y) > >> >> +ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM) $(CONFIG_RTE_ARCH_ARM64)),) > >> > [...] > >> >> +#ifdef RTE_ARCH_ARM > >> >> +/* NEON intrinsic vqtbl1q_u8() is not supported in ARMv7-A(AArch32) */ > >> > > >> > I'm convinced there is a good reason why ARMv8 is also called ARCH_ARM64, > >> > and ARMv7 may be called AArch32 or ARCH_ARM. But I don't know why? > >> > > >> https://lkml.org/lkml/2012/7/15/133 > >> > >> > Is ARCH_ARM32 or ARCH_ARMv7 too simple? > >> > Is it possible to have a 32-bit ARMv8? > >> Yes, ARMv8-R/M > > > > So what does mean CONFIG_RTE_ARCH_ARM? > > ARMv7? ARM32? > > Please consider a renaming. > > I'd rather not renaming becase it can be both ARMv7 and AARCH32, which > are ISA compatibility. > If further differentiation is needed, CONFIG_RTE_ARCH_ARMv7 is added > in the config, just like Jan Viktorin did. I don't understand. You say CONFIG_RTE_ARCH_ARM is for ARMv7 and AARCH32, right? Both are 32-bit right? Why not rename it to CONFIG_RTE_ARCH_ARM32?