From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id EB3BB1B04D for ; Fri, 13 Jul 2018 01:00:38 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 28A4C220B9; Thu, 12 Jul 2018 19:00:38 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 12 Jul 2018 19:00:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=Ce4sVdHh2p1Zp+ABr5UkoKUGaI +BCUlvI4g6Zo4RLXM=; b=gAj5uyRzGTnn8lV2kM7HtuPGxc6WEx6sEUEPPOdb4u uV3G4HWNt2EsBWJgLFC1aDi1qNdYSbQcBntAynxTOQUrCdjOtBZUQBTvobQE/VUw yurDb5b0rUE32HLK9dDNWB6TtLFfrBGwGNRQFPigW9exa5TWGh/WpIiFpMnWjrtw w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=Ce4sVd Hh2p1Zp+ABr5UkoKUGaI+BCUlvI4g6Zo4RLXM=; b=wjLTkK699CqeaX8NIdRI31 OKc5WiTslPgFIP8yp0Ay0RFP1YGzA2GMuJKuRyOwXTU36fLE25zROlstPCE83+q/ MQpqrbqlQVoYgfGpqpU9zxcH/5TJFyDICvOqMsCfu51dT310H1tdWnaJEYYjO5Ly RCQPekUWbhghEFG1Yh+GrilXQjBtfEu4bJ+Zfrao8H2zEAf/iY1YSmgLFBpd+2TF bDJ4upjwYCu0ffalPF8VX/6DZ/qAEByjlEUt1o//9zDrFZw+gWEKB9pTekGa5Ome +stXZmdAm36vcc3itIkR1Ps2hRtM+WSPb7fTWb/jusTKBiaI+pAUOzc9g3foSHmA == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2ED541025C; Thu, 12 Jul 2018 19:00:37 -0400 (EDT) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, Bruce Richardson Date: Fri, 13 Jul 2018 01:00:35 +0200 Message-ID: <2565996.1ACNHyXsKP@xps> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 3/3] eal: make memory segment preallocation OS-specific X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2018 23:00:39 -0000 28/06/2018 13:41, Anatoly Burakov: > In the perfect world, it wouldn't matter how much memory was > preallocated because most of it was always going to be private > anonymous zero-page mappings for the duration of the program. > However, in practice, due to peculiarities of FreeBSD, we need > to additionally limit memory allocation there. This patch moves > the segment preallocation to EAL private functions that will be > implemented by an OS-specific EAL rather than being in the common > memory-related code. > > Since there is no support for growing/shrinking memory use at > runtime on FreeBSD anyway, this does not inhibit any functionality > but makes core dumps faster even on default settings. > > Signed-off-by: Anatoly Burakov > --- > > Notes: > For Linuxapp, this is 99% code move (aside from slight changes due to > code deduplication between Linuxapp EAL and old common memory code), > while for FreeBSD it's mostly code move but with changes due to > dropping 32-bit code and implementing FreeBSD-specific limits on > memory preallocation outlined in the commit. Applied, thanks