[dpdk-dev] [PATCH] i40e: configure the vector PMD option as no for default for l3fwd undefined ptype issue

[dpdk-dev] [PATCH] i40e: configure the vector PMD option as no for default for l3fwd undefined ptype issue

[Zhe Tao]

Configure the vector PMD option as no for default as a work around for l3fwd.
After the l3fwd app can handle the undefined ptype or the i40e vPMD can return
the ptype, the option will be set as yes for default again.

Signed-off-by: Zhe Tao <zhe.tao@intel.com>
---
 config/common_bsdapp   | 2 +-
 config/common_linuxapp | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/config/common_bsdapp b/config/common_bsdapp
index 7df0763..a9b51ff 100644
--- a/config/common_bsdapp
+++ b/config/common_bsdapp
@@ -189,7 +189,7 @@ CONFIG_RTE_LIBRTE_I40E_DEBUG_TX=n
 CONFIG_RTE_LIBRTE_I40E_DEBUG_TX_FREE=n
 CONFIG_RTE_LIBRTE_I40E_DEBUG_DRIVER=n
 CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC=y
-CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=y
+CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=n
 CONFIG_RTE_LIBRTE_I40E_RX_OLFLAGS_ENABLE=y
 CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC=n
 CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_PF=64
diff --git a/config/common_linuxapp b/config/common_linuxapp
index 52173d5..56d6287 100644
--- a/config/common_linuxapp
+++ b/config/common_linuxapp
@@ -187,7 +187,7 @@ CONFIG_RTE_LIBRTE_I40E_DEBUG_TX=n
 CONFIG_RTE_LIBRTE_I40E_DEBUG_TX_FREE=n
 CONFIG_RTE_LIBRTE_I40E_DEBUG_DRIVER=n
 CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC=y
-CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=y
+CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=n
 CONFIG_RTE_LIBRTE_I40E_RX_OLFLAGS_ENABLE=y
 CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC=n
 CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_PF=64
-- 
2.1.4

Re: [dpdk-dev] [PATCH] i40e: configure the vector PMD option as no for default for l3fwd undefined ptype issue

[Zhang, Helin]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhe Tao
> Sent: Wednesday, November 18, 2015 12:46 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] i40e: configure the vector PMD option as no for
> default for l3fwd undefined ptype issue
> 
> Configure the vector PMD option as no for default as a work around for l3fwd.
> After the l3fwd app can handle the undefined ptype or the i40e vPMD can
> return the ptype, the option will be set as yes for default again.
> 
> Signed-off-by: Zhe Tao <zhe.tao@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>

Re: [dpdk-dev] [PATCH] i40e: configure the vector PMD option as no for default for l3fwd undefined ptype issue

[Thomas Monjalon]

> > Configure the vector PMD option as no for default as a work around for l3fwd.
> > After the l3fwd app can handle the undefined ptype or the i40e vPMD can
> > return the ptype, the option will be set as yes for default again.
> > 
> > Signed-off-by: Zhe Tao <zhe.tao@intel.com>
> Acked-by: Helin Zhang <helin.zhang@intel.com>

Few comments:
1/ The issue is not described.
2/ The release notes should be updated in the section "known issues".
3/ Changing the default config option won't prevent users from enable it.
If it is broken, it is better to fix or revert it.

[dpdk-dev] [PATCH v2] i40e: configure the vector PMD option as no for default for l3fwd undefined ptype issue

[Zhe Tao]

PATCH v1: configure the vector PMD option as no for FVL
PATCH v2: Update the "know issues" for 2.2 release note

Issue: l3fwd app need the ptype in the mbuf to forwarding the packets properly.
but now some drivers like virtio driver and FVL vPMD will not set the ptype in
mbuf, so l3fwd cannot work properly on that kind of drivers.

Configure the vector PMD option as no for default as a work around for l3fwd.
After the l3fwd app can handle the undefined ptype or the i40e vPMD can return
the ptype, the option will be set as yes for default again.

Signed-off-by: Zhe Tao <zhe.tao@intel.com>
---
 config/common_bsdapp                 | 2 +-
 config/common_linuxapp               | 2 +-
 doc/guides/rel_notes/release_2_2.rst | 6 +++++-
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/config/common_bsdapp b/config/common_bsdapp
index 7df0763..a9b51ff 100644
--- a/config/common_bsdapp
+++ b/config/common_bsdapp
@@ -189,7 +189,7 @@ CONFIG_RTE_LIBRTE_I40E_DEBUG_TX=n
 CONFIG_RTE_LIBRTE_I40E_DEBUG_TX_FREE=n
 CONFIG_RTE_LIBRTE_I40E_DEBUG_DRIVER=n
 CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC=y
-CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=y
+CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=n
 CONFIG_RTE_LIBRTE_I40E_RX_OLFLAGS_ENABLE=y
 CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC=n
 CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_PF=64
diff --git a/config/common_linuxapp b/config/common_linuxapp
index 52173d5..56d6287 100644
--- a/config/common_linuxapp
+++ b/config/common_linuxapp
@@ -187,7 +187,7 @@ CONFIG_RTE_LIBRTE_I40E_DEBUG_TX=n
 CONFIG_RTE_LIBRTE_I40E_DEBUG_TX_FREE=n
 CONFIG_RTE_LIBRTE_I40E_DEBUG_DRIVER=n
 CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC=y
-CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=y
+CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=n
 CONFIG_RTE_LIBRTE_I40E_RX_OLFLAGS_ENABLE=y
 CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC=n
 CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_PF=64
diff --git a/doc/guides/rel_notes/release_2_2.rst b/doc/guides/rel_notes/release_2_2.rst
index 0781ae6..0fe4cbb 100644
--- a/doc/guides/rel_notes/release_2_2.rst
+++ b/doc/guides/rel_notes/release_2_2.rst
@@ -215,7 +215,11 @@ Other
 Known Issues
 ------------
 
-
+* l3fwd app now cannot handle the receive packets properly without ptype.
+  When using the FVL PMD for l3fwd, need to make sure the receive packets
+  will have the ptype set, but now the FVL vPMD does not support ptype,
+  so please configure the vPMD option as no when using the l3fwd on FVL.
+
 API Changes
 -----------
 
-- 
2.1.4

Re: [dpdk-dev] [PATCH v2] i40e: configure the vector PMD option as no for default for l3fwd undefined ptype issue

[Thomas Monjalon]

2015-11-24 02:47, Zhe Tao:
> PATCH v1: configure the vector PMD option as no for FVL
> PATCH v2: Update the "know issues" for 2.2 release note
> 
> Issue: l3fwd app need the ptype in the mbuf to forwarding the packets properly.
> but now some drivers like virtio driver and FVL vPMD will not set the ptype in
> mbuf, so l3fwd cannot work properly on that kind of drivers.
> 
> Configure the vector PMD option as no for default as a work around for l3fwd.
> After the l3fwd app can handle the undefined ptype or the i40e vPMD can return
> the ptype, the option will be set as yes for default again.
> 
> Signed-off-by: Zhe Tao <zhe.tao@intel.com>

Applied, thanks.