From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 97D9AA057B; Wed, 1 Apr 2020 16:16:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 07A982C15; Wed, 1 Apr 2020 16:16:59 +0200 (CEST) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id 33335FFA for ; Wed, 1 Apr 2020 16:16:57 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id BFC8558035E; Wed, 1 Apr 2020 10:16:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 01 Apr 2020 10:16:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=PA8I4xqY3BQXi8z3/uIbgdYLyawmagiUmi3/jjh7g8Y=; b=h5O1UkEzlt3w GYJhtUKEymmeTetwtx5vnevGpHqDp2kX0o48m/Ul0R2NVJsbx6pQpFrwobvcaujq gPy/woWl6L+L2G7Nyy3IVlz0TCgE9lvV5c1hEQU6XRRYHkSpKx2+PVF6xuuAnivZ zCFoSyaND0kPwEKYDacXzcjGwyNeQIQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=PA8I4xqY3BQXi8z3/uIbgdYLyawmagiUmi3/jjh7g 8Y=; b=05SHBxGLc+EAzO6emjjvHpt2ipDIQ9x6SEiwA4bhCYgb+ucVY1lcmXKjS pP9uWpk2BMm+QD+grg0VNANu9zPmzQQWss9IADmuOvWqZ/xgTNaj702S7eyvNFX7 RSwjirGXr3zPqo2zhTTwxdTrKetmiqAoou5CjeF+3i7lrLetVHQyhTPJaNfhLOi5 vDLirT1rLP3SbevdBC7IykCwmN+5zN4+hM7xN6Qa9Xr6ITLLmN825R/x/JWTKeBO HpJbp8rSBeoigQMD9uqSkjp1IFcv/ZWeEH6calr2xl/FWMrzMYjedVIm8rY46/Se jw8O8ozYFTvHKwA7XR6Imb3dUp65Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrtddvgdejfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8A5963280060; Wed, 1 Apr 2020 10:16:51 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Kollanukkaran , David Marchand Cc: dev , Bruce Richardson , Mattias =?ISO-8859-1?Q?R=F6nnblom?= , Sunil Kumar Kori , "Yigit, Ferruh" , Andrew Rybchenko , Declan Doherty , Olivier Matz , Neil Horman , Ray Kinsella Date: Wed, 01 Apr 2020 16:16:50 +0200 Message-ID: <2572120.Nya5fj1elA@xps> In-Reply-To: References: <20200325211603.240288-1-jerinj@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 00/33] DPDK Trace support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 01/04/2020 16:12, David Marchand: > On Wed, Apr 1, 2020 at 12:05 PM Jerin Jacob wrote: > > On Wed, Apr 1, 2020 at 1:49 PM David Marchand wrote: > > > - Regardless of the trace framework, the ALLOW_EXPERIMENTAL_API flag > > > gates access to APIs so that external users are aware of their status. > > > I have been considering setting this flag unconditionally for internal > > > users in the top Makefile/meson for app/ lib/ and drivers/. > > > I could look at this and prepare a patch about this, but this is not > > > enough here. > > > > It makes sense to me. Let me know when you are planning to send that patch, > > I will rebase this series on top of that. > > Feel free to take over, thanks. > > > > > > If you don't have time then I can send the patch too. > > I assume the patch content will be: > > 1) Removing experimental API from app, lib, drivers, examples with > > make and meson > > 2) Have it enabled at the global level. > > examples are a special case as they can be compiled out of the dpdk sources. > This is why I excluded them of the list in my mail before. > > > > > How about: > > > * we introduce a global config switch that enables/disables the trace > > > framework (off by default): the people who want to test it and help > > > stabilize it will have to deal with the experimental flag for now, > > > * in 20.11, the trace points are put into the stable ABI, and the > > > option is removed, > > > > IMO, the better alternative would be: > > > > Since the trace changes in the "inline" functions of the specific > > library already > > disabled under _compile time_ RTE_ENABLE_TRACE_DP flag and > > it is using RTE_TRACE_POINT_DP() to define the trace unlike slow path > > trace like RTE_TRACE_POINT(). > > Ah indeed. > Note: RTE_ENABLE_TRACE_DP is not plugged with meson. > > > > So I can improve RTE_TRACE_POINT_DP() to make absolute NOP if > > ALLOW_EXPERIMENTAL_API not defined. > > > > On the upside, > > The tracing code will be enabled by default(runtime it is disabled by > > default anyway). > > If some need to fastpath API tracing then ALLOW_EXPERIMENTAL_API need > > to enable. > > So this won't break applications. > > So either keep the RTE_ENABLE_TRACE_DP flag or use > ALLOW_EXPERIMENTAL_API... no opinion. > Thomas? Anyway we need a compile-time option? The option is just for compatibility? Then ALLOW_EXPERIMENTAL_API looks to be the right option.