From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0087.outbound.protection.outlook.com [104.47.32.87]) by dpdk.org (Postfix) with ESMTP id 76E051B68A for ; Fri, 3 Nov 2017 12:35:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Qz2PIlwCaeo7kTTqD1+3flBl7Pqb/cVpKLlGvt8VGF8=; b=e3RAjxn8mowWfCU9V+8SfvPh20Yd8HkIws16ZGoOx4BJ6739MYFQBzs+SJrnrVaLOmEg/zxVqqQ/EgL9zvOMBcM603vp1QheI8JD1/GIxBy31xsyDGSW+InwZrvi9/NcxOGqqLsFaz+hLqdLPV0aGUS8qfqNHcpvZxy2k2wpdVA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Santosh.Shukla@cavium.com; Received: from [10.160.0.39] (111.93.218.67) by CY4PR07MB3096.namprd07.prod.outlook.com (10.172.115.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.178.6; Fri, 3 Nov 2017 11:35:47 +0000 To: Thomas Monjalon Cc: dev@dpdk.org, olivier.matz@6wind.com, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, anatoly.burakov@intel.com References: <20170905103119.20511-1-santosh.shukla@caviumnetworks.com> <20171020123136.10557-1-santosh.shukla@caviumnetworks.com> <20171020123136.10557-5-santosh.shukla@caviumnetworks.com> <5335497.nnbAZL8Naz@xps> From: santosh Message-ID: <2572bad0-8023-3146-dfd1-1e0ef874fe70@caviumnetworks.com> Date: Fri, 3 Nov 2017 17:05:29 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <5335497.nnbAZL8Naz@xps> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: PN1PR0101CA0012.INDPRD01.PROD.OUTLOOK.COM (10.174.151.22) To CY4PR07MB3096.namprd07.prod.outlook.com (10.172.115.10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7782cb61-70ec-4ca7-4bae-08d522af08b0 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603238); SRVR:CY4PR07MB3096; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3096; 3:We15xyE/J9FgvqvbHsKEWn7a4d++/f+ovXY92qzcu7Yr3LrC8nxVDD58m46eNGhDRgkNSnJAAQlNM7FObzDebZ4S6jFfAUmTWb30Y14QpE145Zqa3JjujclVrHxim8apPhhXO6zmJm2iqLDd5AhjicWQAWyiXZbCD/SVqTomhDkIr8LUWiP8trIdED+jKCusLRcu2ZLdwSDgTqpgFJRev5NlXwWaHu6HOZGKmTDRLznYmAXRTRFbEwkOjoXl88wl; 25:7yqVKjhQyc3E/0n9cVrnaLtjg1/ZD/MpusqgZjzR3KdSdjqTohiuDrPp/XxpueU7uI9sCwwc3BwsnKRjx0HXcxAGWXRUZADuimzPEwwGRA6nJ11vB7Q+RGzoIU1+F6QH/cfv+WdQkKmIEEaNt3UfgnD95BjnLjVIdKYONq8meUnOIJgcTVpCdcCGd0jaWqf8vva4DUaeXAPIgHkj+rFxwAQ1joDxUQadJwRn0sW6X6rXUFkDzU2RInJXrkjszKgtLJF6UEif+l2gzb5Cpl/8+2rAXEdaw0+F3WFln8abXgs8XSGRY8XQOJzy2ffX3CqwVXKeoYiVxGuDgbnAulzjXQ==; 31:qvxUOZqTWCz6BzdxC49pQ2DlJ6YvNbdiKf4bQNMkVI0DJUkazy2+K3fW4arkZ5TMFaQn067DPS63O7EmW+elC9saMjVvYnJ8OvPPzN7imVE21ketQx3hM0RfaTYnJOjG6vJO9eZt42ktg8+qX3c/RAXnn6vC4Nq/+Gh31FLgUdqqhA4HldI+fxoI8t4H08B6a6/cTI2ZbWBzZ1UKBfzKVFGLjpXLkRZ2O92AWqWIPkc= X-MS-TrafficTypeDiagnostic: CY4PR07MB3096: X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3096; 20:7Gyko57tFeO67JCs10Fj+KeK89cdCyj8yWCqqyY9DlMr6j4F2UdL3h6xZTP9YmeIM0kb0YUa/hHBdVN+EhRNIjviRHCw4L21DiJ3t82cLW+4Eigd3lUJRKF4TlqYIszggS6+geLZ9Ii9y1FpPvAuKUO6qUtrMYcW9FMEPZocIcF+LZAIheQ+R3B3GuHFBGueRyZteGxWgAZS8k6Ln0/nRYerGYN8glo8joxUZO+bwaqH/ZDQmZokKOgbb6naadCFviKkUaGOfLEBtJpIlc0xXflJPMJ3KL/cuDQ3BzsZyc57OW8ShT8nn3tx6ogloTk0BuvbpYx66Ug+Q3qWUTUycGIKa1+YQuPiP/Fs1W8V2IVyheY4Sb6H7GlcD2C6EDLzYtVwRH5hIbKakrAJ4Q8Rrbk+xGsSz/fvgsNlLoUrEzEZp3f1nKYrd9uiGrtDanr/YZiA0dH4iFiOhzaPbuKTri6ZN3OQI2ippHn19vGn03m5wGWaShCGDhVvPpyjN7dKjH+TLQutUU2ncY+poJg7sGoxsxETFkpJ7q/w9HDYXqpyoGKRwKfpiq8Zt4VlNHEmshumx7JHpiIFPE8b+ZeYqZz05UQNCzj/8f2mdFveFaQ=; 4:ADx1EY0+WvaNWFTlmodmKvCqSNa3NzRLVXoWMSD91VNfzIJlUWBYtyo69RyF3Glt3zTVfOFfLGcZ4FGkUm/K5h65VXHHy/sWWmHY3Ebt4wNJr2fpN+hm04+BzLODu4dAxOvp59Z2gnPl5q07Eky118dtnQJYgQLv67GWN62xwAj5MSbgfAyDjTcS3P28D3Zl7fadoYqlRVa7aZ/BmabstBSAcrYrP+dG5WokovCy6Xr//MLA7PkAUGKC1m5s7D8zdv85+YP8xPRccpb7BFG+/g== X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(93006095)(3231021)(3002001)(100000703101)(100105400095)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123555025)(20161123564025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY4PR07MB3096; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY4PR07MB3096; X-Forefront-PRVS: 0480A51D4A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(6049001)(346002)(376002)(189002)(199003)(24454002)(90366009)(105586002)(25786009)(189998001)(53936002)(97736004)(6246003)(72206003)(478600001)(65826007)(5660300001)(42882006)(6666003)(106356001)(6916009)(2950100002)(229853002)(31696002)(77096006)(6486002)(47776003)(81156014)(31686004)(5009440100003)(81166006)(50466002)(54356999)(3846002)(50986999)(76176999)(8936002)(36756003)(23676003)(4326008)(16526018)(83506002)(64126003)(6116002)(2906002)(16576012)(58126008)(316002)(68736007)(33646002)(65956001)(93886005)(65806001)(7736002)(86152003)(66066001)(8676002)(305945005)(8656006)(230700001)(101416001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3096; H:[10.160.0.39]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjA3TUIzMDk2OzIzOkFjMWpBOFl3bUVLaVRycnFhbkNmR3RMTkYw?= =?utf-8?B?ckk5U3ZmMmQ3OXcyZEFMRXNvb2dIaWZBTE50T2w1UmFDK2M1TkZ1SVJaMTk3?= =?utf-8?B?bVZKL2tydnV2Y1RJMmM2T0JYTkZkR2FqZWl0SzB1VW42ampxTVJRYkxHUFZn?= =?utf-8?B?U0dZNDBodnFEMExDdmtFOEx6NUxjUm54QUdzWFpleGJ5V3diTVJoYm0wRGN6?= =?utf-8?B?VGhWTTlaM1ZNeHM4WW92TkV0N1BwbE9FK2xETm80UUFLbGREZlRMdWFkaTFm?= =?utf-8?B?S05VK0JGYURKTVNHZDFWVlVGMDMwcUlmclRCZWZiN3Z0K1oxSG1DV01jZDJl?= =?utf-8?B?QmxMdnBDYStmd000aVpWeHozK1E0V3BIQXEwbjU3TmhQV1FzNzVQaEk3anI1?= =?utf-8?B?RElraEIzeWtDRFBkSFJ5T3AwV3lvZks1Q3ZqUUlUdU1pdFFkQytkejNNQ0N0?= =?utf-8?B?MFRxUkRLem0yTEN1NnBSaVI3VHJWMmRBOTBQM2ZjZUVXQVcrTmR4S2dDdFpl?= =?utf-8?B?dEU5N0RHcURFVmh0NXovK0J3djBueGpBRHpOVEtOdGhzZXBMVWV6bmxpMVgy?= =?utf-8?B?TWtJUXZYaXBzZUQyakp2YnZqczlTMjlrLzNReWdVY2FrMEZ3TjU4cWx0U0ps?= =?utf-8?B?amUyMTZGRWlXa0ppN0huVUJsSEhDSHQzZ0t5WWx2cE5HRUhnUnRUZ0hpUFZY?= =?utf-8?B?ZEJPTTBlaGJDaVZ4WlllN1RzL1JwWmJkb2V6UTJiS1grWGFxcDJDaHljaVdE?= =?utf-8?B?STQxZHhlaVpKdWdNRFdyMFk5ODZhWm1lRDFYeW5WeFRCY0puaGhQSi93b0F3?= =?utf-8?B?dFUzNWFveGZrUHpmeW5ISmhnUVBwRGM2anEwWXNwTFRScDJWbUVLeENmcUhs?= =?utf-8?B?aWVSVkNaclltbG5rTUlTS1VmeUxNRCs3UFF6cmFiRGVoamVQTWw2RE9wMExz?= =?utf-8?B?dER2Ym9xZElDbWJJazN3c09iYmxsZ09ORnphTGxqRWRCWnRDeUQyQXRhK3R0?= =?utf-8?B?TmpDNm9xbUVzVUVqTWs3MVBCYkdvbjhLZ1dtQTdOM1V1cERid2VhNnY4SDlo?= =?utf-8?B?U0FQQXRnTVBrYXRIdFE0bHhpZUcva1FGYzNEeGVRS3VHYXJEVVlpTldRUFIy?= =?utf-8?B?TThpNnZXd2RWckI2UHRQSjkyclpsUXBaUHJ5c0tlT0cvdjdpckdtYWhpZGw4?= =?utf-8?B?U3V5ekRmSVRHb1MyaWx5aS80QUEvNzdqNGpMcUwwUS9jMlZvd0o2dlJsMUlu?= =?utf-8?B?VUFUaEJOZTVoM0hXU1NDQ1R6VVRka1dQbHVDa2hqUEhNTWN5aHdUNWtSMllh?= =?utf-8?B?VVRJRWJsZllqdHY5ZDRSNTdTWTdIazNZcWgzUG5MUnVrSUhzYjNML25QVy9U?= =?utf-8?B?YWxxNWlaTThNSGlrUSsxS1c2Ynd6Q2lGSTJHUzVBdHp1aitLN2lnR1pKVGQr?= =?utf-8?B?a21pOHRVTkpRWEM5OE96R3N6OElxL0lNMHQwQkhKMHh5T28vVDlRUHJhMVcx?= =?utf-8?B?d2VwUXp0LzVWb09uc2JRM2dzYWpQNmtqMFVJbHJHSEFjMUNDdG9Wa0NGTndM?= =?utf-8?B?Rk5PZnh0aVZGbVRUaG0ranQ4c09tZTdkdlo1RmExa3J6WGp2MjlPOHFTTEhR?= =?utf-8?B?aVlrTVYrNUUzSHkvV0YySHF3d3RuWXp2bGtTbXVYUUlncjMrcTBYcEgrMkRl?= =?utf-8?B?VWU2NkoybHBtY3BoQnF4Ry9wYXAvYjBSa0hwRytQMG9pcWNwb2E4UVlOQnFT?= =?utf-8?B?UUhqRHorMWEwME1UWlBpRzc5RU9UTk41a051MXpWSHRIVStoZndPUDFBQmRo?= =?utf-8?B?SEd4VnhwbzRTVDF6cWx1WkZPUXpvQXpidTZmclJRZVIzREx4dDcxUUFiRC94?= =?utf-8?B?UTAxV3BuMy8rN0w2bjhlSVF1RktlU1J0YzFuYTcvVk83U1NTcTREcXA2LzBL?= =?utf-8?B?WmE5cmVFWmhRPT0=?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3096; 6:csN+EFei6U52cZmyyaHepKNFmU+iW8+C9GNlsOg7P9zNsq+kGMkjhY0GVW8HPoipjpfefVkgkEZukmbVyVhsSoxhSTmbZjVcHEMtvYrVaiJ4yh0y7Re3jOzt6uX+PJnBy9/wtNr6Op08+TisKmDBMrt7g/e/gdPwd8RtEBw9QX/6qhbfnThVXq4d4EpKjVQ9FEa4+Olu6hsze9pKpRU5JSAkLkiIQd5mKf3vYpNaW2FmHiyPJqd4YqcQUH3z/rqUs+midun95CI+bKgTQUNbGsI45/N+8CwsR5HIYiljOhTWgr4pD6EBxtWBjQuvTZmZSBnul074REoImRjYjqweIM0sc0nsZgTFK4LkZF82Gcg=; 5:0DDSgzrUdX8Q253fI3XaBmAJW7RhcY+6Z7uNexZoLciiqWBfy7Kd5/fL06d7ztK45DbQFHqMcwK/7JfZltg0tLQXyyEzgmi/iGprXBxXjiKJNbqfsAqEnFvbg//l1gQTHl5AL38LExhhB+vxeGGwzIWLpow6cQHPw1iG9E3URS0=; 24:ywEDAOjjA7Nv0jONPNFjtOFwPN1aWsuq18D344MLh/4s5kll40KdMuEQLOn1k/i1o3JPh0f7/5VRLY/BZvTKJW78LG5K1chEQiFGUExkMKM=; 7:Zt9SXIeXYTSzTlFF5Yl3U0+enLU1kWISYlr2AWGcd3IDQFHke+X+nFsNKcfZQCXpHW7++yAYMFwJ/+7Z8yaB1ogrcqdDu3FfwwnSbMnwiqnXInONBREhvoIZC2PW69bgR9CNn0pSmfTCXV1HFsDANhBlv5BW8YjAR6f8Nb0ISNvspXQj92C09ci08Ks/bFi9uxEBWyCEyFLmsdShr5rL1RvlntlzFD1TOOuV2LKzugbU0uSdgO3ZSBzCqcSsJP+L SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2017 11:35:47.3214 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7782cb61-70ec-4ca7-4bae-08d522af08b0 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3096 Subject: Re: [dpdk-dev] [PATCH v3 4/6] eal/memory: rename memory API to iova types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Nov 2017 11:35:52 -0000 On Friday 03 November 2017 04:41 PM, Thomas Monjalon wrote: > 20/10/2017 14:31, Santosh Shukla: >> Renamed memory translational api to _iova types. >> The following api renamed from: >> >> rte_mempool_populate_phys() >> rte_mempool_populate_phys_tab() > These functions still have "physical addresses" in their description. > It is not consistent. > > Please provide ABI compatibility for mempool functions. > >> rte_eal_using_phys_addrs() > Why renaming rte_eal_using_phys_addrs? > I think we need to review how it is used. > Maybe it requires a rework. > >> rte_mem_virt2phy() >> rte_dump_physmem_layout() >> rte_eal_get_physmem_layout() >> rte_eal_get_physmem_size() > Those 3 functions deal with physical memory layout. > I don't see a need to rename them. In iova=va mode, those api will have va address. > But the dump function needs a change to avoid printing > "phys" even in VA case. > >> rte_malloc_virt2phy() >> rte_mem_phy2mch() > This last function was removed with Xen. > It is wrong to rename it in the release notes. > It should just be removed from the map file (I will send a patch). > >> To the following iova types api: >> >> rte_mempool_populate_iova() >> rte_mempool_populate_iova_tab() >> rte_eal_using_iova_addrs() >> rte_mem_virt2iova() > [...] >> rte_malloc_virt2iova() > I am not convinced by the names virt2iova. > I sounds like "virt to virt". > What about "virt2io" or "virt2io_addr"? no, iova can be _pa or _va, its an io_addr indeed but I prefer virt2iova, same mentioned in deprecation notice (no strong opinion), More suggestion on naming pl.? > As the ABI is broken in EAL 17.11, we do not care about compatibility. > But we must keep an alias to the old function name in order to allow > a smooth API transition for applications. > I suggest to add static inline functions with the old names and set > the deprecated attribute. ok, Will address in 18.02. Thanks.