From: Thomas Monjalon <thomas@monjalon.net>
To: "Xu, Ting" <ting.xu@intel.com>,
"Iremonger, Bernard" <bernard.iremonger@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"arybchenko@solarflare.com" <arybchenko@solarflare.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4] app/testpmd: fix DCB set failure
Date: Wed, 13 May 2020 14:58:00 +0200 [thread overview]
Message-ID: <2577108.MsWZr2WtbB@thomas> (raw)
In-Reply-To: <DM6PR11MB2537874F781637B7023B7366EFBF0@DM6PR11MB2537.namprd11.prod.outlook.com>
13/05/2020 10:54, Iremonger, Bernard:
> The fix is no longer in testpmd, so the commit line should be "ethdev: fix DCB set failure".
In general, the word "failure" (or error, etc) is not needed.
Because it is a fix, we know there was a failure before :)
And specifically here, you are not fixing just DCB.
next prev parent reply other threads:[~2020-05-13 12:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 10:25 [dpdk-dev] [PATCH v1] app/testpmd: fix DCB set failure in FreeBSD by clang Ting Xu
2020-05-11 5:12 ` Xing, Beilei
2020-05-11 7:50 ` Huang, ZhiminX
2020-05-11 16:29 ` Ferruh Yigit
2020-05-12 2:17 ` Xu, Ting
2020-05-12 11:42 ` Iremonger, Bernard
2020-05-12 10:13 ` [dpdk-dev] [PATCH v2] app/testpmd: fix DCB set failure Ting Xu
2020-05-18 17:06 ` Ferruh Yigit
2020-05-13 9:50 ` [dpdk-dev] [PATCH v3] " Ting Xu
2020-05-13 10:07 ` [dpdk-dev] [PATCH v4] " Ting Xu
2020-05-13 8:54 ` Iremonger, Bernard
2020-05-13 12:58 ` Thomas Monjalon [this message]
2020-05-13 17:16 ` [dpdk-dev] [PATCH v5] ethdev: " Ting Xu
2020-05-13 13:28 ` Ferruh Yigit
2020-05-18 16:24 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2020-05-13 15:54 ` [dpdk-dev] " Iremonger, Bernard
2020-05-18 13:32 ` Andrew Rybchenko
2020-05-18 14:57 ` Matan Azrad
2020-05-18 16:21 ` Ferruh Yigit
2020-05-18 16:20 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2577108.MsWZr2WtbB@thomas \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
--cc=ting.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).