From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com
 [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id 7FC4AC464
 for <dev@dpdk.org>; Wed, 21 Oct 2015 18:37:17 +0200 (CEST)
Received: by wicll6 with SMTP id ll6so83012547wic.1
 for <dev@dpdk.org>; Wed, 21 Oct 2015 09:37:17 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=tnTrq8J2R2ECyzX2y0I0Ks+zWagMKhNQCzQeLSu525Y=;
 b=cA9mFf4DRTIyw6wQPh+VE7oyneM7ndqmjHx8PSyP0VGrCC74EGkpY22eqH47mdlJ3K
 JAB4iH23bhviiZwSdMT1/zQ2rntGcr2QkwAAr7fr5IToDNTG8qdGkBI1ERfeX7xcHsPs
 nFBDMz0NkqgSsfDmeTXzOAHUNTnxNKTJ490Ri8UF4SX9YyfdAGhTwUxW6awQw0wjf09c
 s0wmjfFN1EXicF7sQT5rtnCu8FD6wklFNomoxLF70QHRLuaRHaj5fMtCaAyLaN+bR+nk
 LE/h54dE+pKPfiInbKPX1l6PYUC/vrN2yC0pH8xTjAkktqg3Uqo7242pm0u9I4tXgWqf
 ioDg==
X-Gm-Message-State: ALoCoQnxuSApcR6QwxcDjJ2/C2HRz7KYDcfBtJ7aL39CVrF87fNE+lUN+LLIp99q3jhaBYc2/nPm
X-Received: by 10.180.88.34 with SMTP id bd2mr19932789wib.82.1445445437355;
 Wed, 21 Oct 2015 09:37:17 -0700 (PDT)
Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net.
 [82.239.227.177])
 by smtp.gmail.com with ESMTPSA id jh4sm6932959wjb.33.2015.10.21.09.37.16
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 21 Oct 2015 09:37:16 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Liang-Min Larry Wang <liang-min.wang@intel.com>
Date: Wed, 21 Oct 2015 18:36:12 +0200
Message-ID: <2579237.5XQrXtFRuP@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1437663628-18076-3-git-send-email-liang-min.wang@intel.com>
References: <1437401571-9104-2-git-send-email-liang-min.wang@intel.com>
 <1437663628-18076-1-git-send-email-liang-min.wang@intel.com>
 <1437663628-18076-3-git-send-email-liang-min.wang@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 2/2] examples: new example: l2fwd-ethtool
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Oct 2015 16:37:17 -0000

2015-07-23 11:00, Liang-Min Larry Wang:
>  examples/Makefile                                |    1 +
>  examples/l2fwd-ethtool/Makefile                  |   48 +
>  examples/l2fwd-ethtool/l2fwd-app/Makefile        |   58 ++
>  examples/l2fwd-ethtool/l2fwd-app/main.c          | 1025 ++++++++++++++++++++++
>  examples/l2fwd-ethtool/l2fwd-app/netdev_api.h    |  770 ++++++++++++++++
>  examples/l2fwd-ethtool/l2fwd-app/shared_fifo.h   |  159 ++++
>  examples/l2fwd-ethtool/lib/Makefile              |   57 ++
>  examples/l2fwd-ethtool/lib/rte_ethtool.c         |  336 +++++++
>  examples/l2fwd-ethtool/lib/rte_ethtool.h         |  385 ++++++++
>  examples/l2fwd-ethtool/nic-control/Makefile      |   55 ++
>  examples/l2fwd-ethtool/nic-control/nic_control.c |  614 +++++++++++++
>  11 files changed, 3508 insertions(+)

This patch is huge.
Please split a bit.

> --- a/examples/Makefile
> +++ b/examples/Makefile
> @@ -53,6 +53,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_KNI) += kni
>  DIRS-y += l2fwd
>  DIRS-$(CONFIG_RTE_LIBRTE_IVSHMEM) += l2fwd-ivshmem
>  DIRS-$(CONFIG_RTE_LIBRTE_JOBSTATS) += l2fwd-jobstats
> +DIRS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += l2fwd-ethtool
>  DIRS-y += l3fwd

Please keep the alphabetical order.

I do not plan to review it more.
If nobody complains, it means it's accepted.