From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA5B34240B; Wed, 18 Jan 2023 09:42:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8FA5240DFD; Wed, 18 Jan 2023 09:42:07 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 7FCC14003F for ; Wed, 18 Jan 2023 09:42:06 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 4F71F320069B; Wed, 18 Jan 2023 03:42:05 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 18 Jan 2023 03:42:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1674031324; x= 1674117724; bh=q9smbsbfdfHOcY4BkWqKyqBL3/zb8nF0rXl4lqHXipU=; b=E Sb04Y5EEEX7XKqXIqg5xuyu7dvoe3SBe+oqjYHiE2MGlSK37oSBkfkRdjcWw4YH7 7eOeBwGRh5DlN0HbhiL6T0iKwwu71tEDiTpPCPY8m2YDwqK8RnuIRHly6UtxBQH8 i2k250Kzac+BQNxx0zdOq2DWLJuHPx7PPF6cB+9jkdJNlNjJ0mu1SpZP0i3Sq8ck Z293w7jfY5oEV8hZY0ySsYldhT+FKXcdHuEmdI/EY210EbRA0BM4secKfj3LvERk pB93czEamsAOHQuguktp0J34E49tmtr81d0lx2LhYtR6rM67AZx030HYdJBRtX+S pNhqu109rUmaaU2HJgI7w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1674031324; x= 1674117724; bh=q9smbsbfdfHOcY4BkWqKyqBL3/zb8nF0rXl4lqHXipU=; b=s 2740Fxe95pD5LTyypCIhoqegnSSmWM+RthwpAWMCCV1EZ4dCavlZDCeWdClAbZ0Q zn5mpgLZr6liOwcT/O/uswVklY3wMFSiL4f2fAd6CO4vpYbsruva3Fx/z1pHt4qO EIFWr+/6SmWL7/Tmd0XINgXI8xntfRFJu5ttGOQxYFiDSYBPLgBHy2Kdp4p8iY8P MnrQMDhxMMmPL8oD2XcnCH2zmFV+MZDZQ3/6f3OS6RdaBSRZlx6cSQekIJEC9yOZ OuPNf3mHlyJhEuxUe/gAfeYZnxG/kKS2KsVy/LwRQ/3xgr8fJlTaf0lX140X0iGM t5hZ/dUknzJkzhXCKiYNw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddtjedguddviecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 18 Jan 2023 03:42:04 -0500 (EST) From: Thomas Monjalon To: Sinan Kaya Cc: dev@dpdk.org Subject: Re: [PATCH RESEND v2 01/11] ethdev: check return result of rte_eth_dev_info_get Date: Wed, 18 Jan 2023 09:42:03 +0100 Message-ID: <2581232.ECZNHGQPT7@thomas> In-Reply-To: <20221122153053.1172434-2-okaya@kernel.org> References: <20221122153053.1172434-1-okaya@kernel.org> <20221122153053.1172434-2-okaya@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 22/11/2022 16:30, okaya@kernel.org: > rte_class_eth: eth_mac_cmp: The status of this call to rte_eth_dev_info_get > is not checked, potentially leaving dev_info uninitialized. [...] > /* Return 0 if devargs MAC is matching one of the device MACs. */ > - rte_eth_dev_info_get(data->port_id, &dev_info); > + if (rte_eth_dev_info_get(data->port_id, &dev_info) < 0) > + return -1; > + > for (index = 0; index < dev_info.max_mac_addrs; index++) > if (rte_is_same_ether_addr(&mac, &data->mac_addrs[index])) > return 0; Acked-by: Thomas Monjalon You would get more attention if you Cc the maintainers. You can use this git option: --cc-cmd devtools/get-maintainer.sh