From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id F39158D9C for ; Thu, 26 Apr 2018 16:30:44 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 94B6821B2A; Thu, 26 Apr 2018 10:30:44 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 26 Apr 2018 10:30:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=/hUrnWUljETuNFsnm4fKwOU90E WbyYcG+ZiLzRss0co=; b=M3KdSpRmLrOp6kM9YdbsCODlVjvBHWwSYqT5euwuGw W45RFFQHtzcKxhO7BMK6/+oHmFo5PGTDSJB4B3PI4m7QlAS/b5GU+y3GRw6LSZl9 kUd9lvWZdQUWWCmYltaDUiD9lTrp+eWBTRbnVoPBCvR1zMg2TdQiqiFUi0aoxmrE Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=/hUrnW UljETuNFsnm4fKwOU90EWbyYcG+ZiLzRss0co=; b=gE9ce7WHrrzDsSdtIEUofs a5ZdlOeEnzaM6eP/adeZEh3E9JzaYB6tC1E3QlIKrv6B6/u4gWRJOk8qN8rcwMOq 7BBAgf7KtUrLkpKvU66ZedtsvHmSfcU8P2c2ooKZ5gO9N909Px+vcMUzoP1hK5x+ TfzUnjh+59i2qWDNGk2O0D/lM/BkiLEL1RlgHSue3nhk65yzPiLuQY1AmHQwIP36 5Kk8eWxsz2dtO0AydszrCZNcTbcvmHwlhLMr09yOLIBj0HxwDWwCViyzaiqMdlCA sJLq7LILuV2QUAt9piYpO/k8pO1gqjbEvTLRfB+p76pYdZz8Km9VMfXUQaLDGwKw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4E587E47A0; Thu, 26 Apr 2018 10:30:43 -0400 (EDT) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, Neil Horman , John McNamara , Marko Kovacevic , Robert Sanford , erik.g.carrillo@intel.com, olivier.matz@6wind.com, shreyansh.jain@nxp.com Date: Thu, 26 Apr 2018 16:30:42 +0200 Message-ID: <2584582.pWCQVUZt55@xps> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] lcore: make semantics of lcore role function more intuitive X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Apr 2018 14:30:45 -0000 26/04/2018 15:42, Anatoly Burakov: > rte_lcore_has_role() returns 0 if role of lcore matches requested > role. The return value of the API is confusing, and this is a known > problem with a deprecation notice announcing the change to more > intuitive semantics: > > Commit 064518f68d48 ("doc: announce EAL API change to lcore role function") > Cc: erik.g.carrillo@intel.com > > Implement changes announced in the deprecation notice, and remove it. > Also, fix usages of this API to reflect the change. Control thread patches > expected new behavior and were broken before, now they are fixed as well. > > Fixes: d651ee4919cd ("eal: set affinity for control threads") > Cc: olivier.matz@6wind.com > > Signed-off-by: Anatoly Burakov Applied, thanks