From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C911C44153; Tue, 4 Jun 2024 13:59:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B55CF402EB; Tue, 4 Jun 2024 13:59:07 +0200 (CEST) Received: from fhigh7-smtp.messagingengine.com (fhigh7-smtp.messagingengine.com [103.168.172.158]) by mails.dpdk.org (Postfix) with ESMTP id 38691402CD for ; Tue, 4 Jun 2024 13:59:06 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfhigh.nyi.internal (Postfix) with ESMTP id A872D1140163; Tue, 4 Jun 2024 07:59:05 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 04 Jun 2024 07:59:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1717502345; x=1717588745; bh=/iSOy+bxAA8qtu/MZe9dM40i1MFDoQz6A1zzeKKIdzQ=; b= KnoJ+gL4INXpcT0uJm6gS68PnWvC2fZSuR0FCI0QY4Qm+Y+ppdamGic3MNuBqjd+ IRys0cxWDbeX2/tr+mQ7JPu6eHraPo/7Cnyezn3pBTGSv2u9bQZQuz44cAryaBB7 XGVn0tJ3mdDw8Meq7fOL6aV5nUZIelJEiPy9aT91hF8Ft4nKhqJTDoX7NwWGiBN3 fpf+ekZCwT0bT2ioxJ0aAqcPMeQEhMckB0k/5TBSQRf9Y0JHOEqVhOn7UXqGlLxv xtqch1TSAR1Zc+92hy/7aJn8HSQCcWLqpjWBDDeM27RYrJ2t4h4+rA2dObqijuHT xppJ13IZrraROsLQRArTbA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1717502345; x= 1717588745; bh=/iSOy+bxAA8qtu/MZe9dM40i1MFDoQz6A1zzeKKIdzQ=; b=O wz5dIIGmw1wRDw9OrMO2GXNhYXNZ7dftzCb4RbhhmmjXuH8HxQCjRjTVWG/HBaRO ZWGTeW164qPdVTspaiSXGg/yB/xLKOIDlMZhDiQZ1LWPXXWDfVx8pcNSBTfnTMzh ebB9X9SP5t8eVkEPwMkByYl0mQXtUBlsLrOhse0dN1pzXY6CW516wGKSuryzLKBc fiApzJejrSTf4+pjZA1WO082PCDixjJ0TQr+l+2sbXmkKgxoRL5pFxItCTOXI7cY P1vRch70CJDXa8/ZrVOH8Xi/4voXdDw/jSgiun3Ca+ZflJ5iv5SQ8Hk+Mz/uS0yR PFcIBsnV2gqWgCQ74SdsQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdelgedggedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeejudevheeiveduuddtveffgfdtgeekueevjeffjeegtdeggeek gfdvuefgfeekjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 4 Jun 2024 07:59:03 -0400 (EDT) From: Thomas Monjalon To: Rongwei Liu Cc: dev@dpdk.org, matan@nvidia.com, viacheslavo@nvidia.com, orika@nvidia.com, suanmingm@nvidia.com, Dariusz Sosnowski , Ferruh Yigit , Andrew Rybchenko Subject: Re: [PATCH v2 2/4] ethdev: add VXLAN last reserved field Date: Tue, 04 Jun 2024 13:59:01 +0200 Message-ID: <2585221.otXNkdZ6W1@thomas> In-Reply-To: <20240527024720.1099161-3-rongweil@nvidia.com> References: <20240527024720.1099161-1-rongweil@nvidia.com> <20240527024720.1099161-3-rongweil@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 27/05/2024 04:47, Rongwei Liu: > Add VXLAN last reserved byte in rte flow packet field. You should squash addition in testpmd in the same patch. Adding a field in rte_flow.h should be atomic with testpmd update. > @@ -2428,6 +2428,7 @@ enum rte_flow_field_id { > RTE_FLOW_FIELD_ESP_SEQ_NUM, /**< ESP Sequence Number. */ > RTE_FLOW_FIELD_ESP_PROTO, /**< ESP next protocol value. */ > RTE_FLOW_FIELD_RANDOM, /**< Random value. */ > + RTE_FLOW_FIELD_VXLAN_RSVD1, /**< VXLAN reserved1. */ It isn't clear what reserved1 is. You should say it is the last byte of the VXLAN header.