From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 7BDC24F90
 for <dev@dpdk.org>; Wed,  6 Mar 2019 12:31:13 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 0631F2689D;
 Wed,  6 Mar 2019 06:31:13 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Wed, 06 Mar 2019 06:31:13 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=3ie1f/0WK1O31Nu4WQwpo7GFuDhUl5tBQudzSggk31U=; b=gCiuvAGi1nq7
 k1NgUZJcmmiUsd+7i8qHuZl0R0Zlifs9odqCe5ggIDto2FeLgQomaVtB+Z7qsZ/B
 T0dENcQDYCO4rh4+GV2joAewta/e3Xlh0AD0LtFSUJon1l9UcNysbZQih+hqnmkw
 ZeQvgqdR8aOVF+uKUc9cW6UZ2Mj4iew=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=3ie1f/0WK1O31Nu4WQwpo7GFuDhUl5tBQudzSggk3
 1U=; b=TfI4yAiMyQXWqtt1rAhYlep8jV3RZqzq6jGFID5aKje2fnRQq980HLCy+
 /GGQ8SM2A6DM9/5yvn6HiVlj7GByFp1/IiHDOLaQcFRGzcy28kP1KprnRMTc86ud
 Urn6JKGYuPzoTu5dBUY/GZJxmXxmydqsVhn/OcGcthOE11BRoN9mzXj+3Q0P8TID
 ZVy1jVxaTm8mm9s1MO2mDojXAzFC7N01tsaYU/cdu+KQg1lqy8HO7x9oqcUb8gvW
 /FX8UeGI8Ce7IpAXRtN7bn8A6fOPedIt9RQmibl4cfvPVxWyhWqVJnhkqnFPFsPz
 VCDEDHL/Kcon9e7k7Z6y0lzq7j9+A==
X-ME-Sender: <xms:gK9_XBlC1H2-KYlLRr1KO2mIpYbcUaea2VN5dU-0QawNZjy5nfoLbQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrfeehgddvlecutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
 uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
 fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
 ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh
 hmrghinhepfihrohhnghdrqddqqdguvghvnecukfhppeejjedrudefgedrvddtfedrudek
 geenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnh
 gvthenucevlhhushhtvghrufhiiigvpedt
X-ME-Proxy: <xmx:gK9_XM8bYO6TxYOIgFoC_vWD62xn83ZilZ7_pyERHexF5DExoziIPw>
 <xmx:gK9_XPnajmrD9KLgIJBZ9IIAPcQn721BcHbkBI1NlLkF0tMUbFdwoA>
 <xmx:gK9_XJ2ySeZ8WRPfgNh8hAKj_GoSM9US_7Ysljc9Sa6MG7FJKysRXA>
 <xmx:gK9_XL19ocOLUsoK0xi30fcipRat6rU7aViNxMtSbPXtgeX7n2TCXw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id CB6F210331;
 Wed,  6 Mar 2019 06:31:11 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Anand Rawat <anand.rawat@intel.com>
Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com,
 jeffrey.b.shaw@intel.com
Date: Wed, 06 Mar 2019 12:31:09 +0100
Message-ID: <2585800.7Z22QRaGj1@xps>
In-Reply-To: <20190306041634.12976-3-anand.rawat@intel.com>
References: <20190306041634.12976-1-anand.rawat@intel.com>
 <20190306041634.12976-3-anand.rawat@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2 2/6] eal: add header files to support
	windows
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Mar 2019 11:31:13 -0000

06/03/2019 05:16, Anand Rawat:
> Added header files to support windows on x86 platforms.
> Updated rte_config to include rte_windows.h for windows
> build.
[...]
> --- a/config/rte_config.h
> +++ b/config/rte_config.h
> +/* windows specific*/
> +#ifdef RTE_EXEC_ENV_WINDOWS
> +#include <rte_windows.h>
> +#endif

Include in the config file looks wrong.

> --- /dev/null
> +++ b/lib/librte_eal/windows/eal/include/exec-env/rte_windows.h

I think we could remove the sub-directory exec-env.
Could we include this file from rte_common.h?

> @@ -0,0 +1,23 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2019 Intel Corporation
> + */
> +
> +#ifndef _RTE_WINDOWS_H_
> +#define _RTE_WINDOWS_H_
> +
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
> +#define __extension__
> +#define __thread __declspec(thread)
> +
> +#define strerror_r(a, b, c) strerror_s(b, c, a)
> +
> +typedef void *ssize_t;
> +
> +#ifdef __cplusplus
> +}
> +#endif
> +
> +#endif /* _RTE_WINDOWS_H_ */

It is missing comments to explain the need of each line.