From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id C0B7616E for ; Wed, 12 Jul 2017 10:50:36 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 23C1720ACB; Wed, 12 Jul 2017 04:50:36 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 12 Jul 2017 04:50:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=UMszGvLqvTD84jX jSymkFGaFeyYpGvZSHzqsW4xTLfk=; b=gS78mkeEe+9ooF0+gjy4iz1Mhlu8pdy mh7kJidz3wcQzATpNbAkiyBwGtrWNjoz0DdzXmCJ8Rsvdv1W92c26rlY5gnVJhIF vfD0USf0ykA3VVVJvWL985ffq8U7/gjSNVVWxyklBeI1x6SCdXmfFyUibMBaJlMi xaGplTb4J3A8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=UMszGvLqvTD84jXjSymkFGaFeyYpGvZSHzqsW4xTLfk=; b=VhuEQTMk hH/5v0suXZBGg7Fu5uRfFXVz1/kecIYiRLJDK7Ye+YLbV6Ye3g/HsVcZ0D0DMluK n4ZhZaDYHslzosZTNh2IP4zuQMllS12PLTGIgepfY2SmEu8UpGDhO9btff01wcQm TBdOzC4xTWyo6oEGQU/WAT19D0SVLMJ02Tog9BOAxEqxFOcL7LTlCvbfor81KFCd Xl8uTa5nNlU+Q1kbmG7GWPK4RA1oWwPVNHpog2jniPZg1QlBliN6+IGCI/QSneM7 B75lqdWhBkFueClFJAQoJpcEM10Lsqcg6GBJ3dM1tFHdO++ut1VR9x3YEIpDD1/F z04shQ7uBm4xGg== X-ME-Sender: X-Sasl-enc: sgtAX99H2gL/yQn10JjlEfRsDOZRcyyM/K6hF85ROl1L 1499849435 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CFFDA244AB; Wed, 12 Jul 2017 04:50:35 -0400 (EDT) From: Thomas Monjalon To: Jan Blunck Cc: dev@dpdk.org Date: Wed, 12 Jul 2017 10:50:35 +0200 Message-ID: <25860205.Dk19R5WIvi@xps> In-Reply-To: References: <20170711232512.54641-1-jblunck@infradead.org> <3538101.lyQKiAFUpY@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 00/13] devargs fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Jul 2017 08:50:37 -0000 12/07/2017 10:09, Jan Blunck: > On Wed, Jul 12, 2017 at 3:29 AM, Thomas Monjalon wrote: > > 12/07/2017 01:24, Jan Blunck: > >> The changes to enum rte_devtype that got merged into 17.08-rc1 are breaking > >> API without prior notice. This series is reworking the rte_devargs changes > >> in a way hopefully compliant to the new failover PMD and still keeping API > >> compatible with earlier releases. > > > > I have not reviewed this series yet. > > I have just seen that your are introducing "bus=" in devargs. > > Do you keep compatibility with old scheme without "bus=" option? > > We need to keep this compat for 17.08 and deprecate it for 17.11. > > The old scheme which got introduced with 17.08-rc1 is using the > concatenation of bus name, a one character separator and the device > name: > > rte_eal_devargs_parse( "busname*devname,args" ) No I was talking about the real old scheme without any bus name :) > The new scheme I propose is changing this to take an explicit 'bus=' > argument into account. In case the 'bus=' argument isn't given but the > device is found by iterating the devices on the buses this will also > work. OK > > Please, could you also review the fixes from Gaetan and ack those > > which are relevant from your point of view? > > We cannot progress if we don't apply the fixes we agree on. > > Yes, will do today. Thanks > > Last note: we should make RC2 in few days (hopefully on Sunday), > > so please reply quickly. > > Thanks