From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B95EF4598C; Sat, 14 Sep 2024 11:41:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 567F1402A8; Sat, 14 Sep 2024 11:41:41 +0200 (CEST) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id 492FF4026A for ; Sat, 14 Sep 2024 11:41:39 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.163.48]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4X5R4B6KXvz1T7XJ; Sat, 14 Sep 2024 17:40:26 +0800 (CST) Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10]) by mail.maildlp.com (Postfix) with ESMTPS id 5EB8318006C; Sat, 14 Sep 2024 17:41:37 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Sat, 14 Sep 2024 17:41:37 +0800 Message-ID: <258c30fd-8100-49b5-9a1b-a1aad893b286@huawei.com> Date: Sat, 14 Sep 2024 17:41:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v0 1/1] dmadev: provide priority configuration support To: Vamsi Krishna , , , CC: , , , , , , , , , Amit Prakash Shukla References: <20240913121038.315714-1-vattunuru@marvell.com> Content-Language: en-US From: fengchengwen In-Reply-To: <20240913121038.315714-1-vattunuru@marvell.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpeml500024.china.huawei.com (7.185.36.10) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024/9/13 20:10, Vamsi Krishna wrote: > From: Vamsi Attunuru > > Some DMA controllers offer the ability to configure priority level > for the hardware command queues, allowing for the prioritization of > DMA command execution based on queue importance. > > This patch introduces the necessary fields in the dmadev structures to > retrieve information about the hardware-supported priority levels and to > enable priority configuration from the application. > > Signed-off-by: Vamsi Attunuru > Signed-off-by: Amit Prakash Shukla > --- > > Deprecation notice: > https://patches.dpdk.org/project/dpdk/patch/20240730144612.2132848-1-amitprakashs@marvell.com/ > > * Assuming we do not anticipate any advanced scheduling schemes for dmadev queues, > this RFC is intended to support a strict prioirty scheme. > > doc/guides/rel_notes/release_24_11.rst | 15 +++------------ > lib/dmadev/rte_dmadev.c | 10 ++++++++++ > lib/dmadev/rte_dmadev.h | 11 +++++++++++ > 3 files changed, 24 insertions(+), 12 deletions(-) > > diff --git a/doc/guides/rel_notes/release_24_11.rst b/doc/guides/rel_notes/release_24_11.rst > index 0ff70d9057..dc711bbf98 100644 > --- a/doc/guides/rel_notes/release_24_11.rst > +++ b/doc/guides/rel_notes/release_24_11.rst > @@ -88,18 +88,9 @@ API Changes > ABI Changes > ----------- > > -.. This section should contain ABI changes. Sample format: > - > - * sample: Add a short 1-2 sentence description of the ABI change > - which was announced in the previous releases and made in this release. > - Start with a scope label like "ethdev:". > - Use fixed width quotes for ``function_names`` or ``struct_names``. > - Use the past tense. > - > - This section is a comment. Do not overwrite or remove it. > - Also, make sure to start the actual text at the margin. > - ======================================================= > - > +* dmadev: Added ``nb_priorities`` field to ``rte_dma_info`` structure and > + ``priority`` field to ``rte_dma_conf`` structure to get device supported > + priority levels and configure required priority from the application. > > Known Issues > ------------ > diff --git a/lib/dmadev/rte_dmadev.c b/lib/dmadev/rte_dmadev.c > index 845727210f..053170f55a 100644 > --- a/lib/dmadev/rte_dmadev.c > +++ b/lib/dmadev/rte_dmadev.c > @@ -497,6 +497,16 @@ rte_dma_configure(int16_t dev_id, const struct rte_dma_conf *dev_conf) > return -EINVAL; > } > > + if (dev_info.nb_priorities == 1) { > + RTE_DMA_LOG(ERR, "Device %d must support more than 1 priority, or else 0", dev_id); > + return -EINVAL; > + } > + > + if (dev_info.nb_priorities && (dev_conf->priority >= dev_info.nb_priorities)) { > + RTE_DMA_LOG(ERR, "Device %d configure invalid priority", dev_id); > + return -EINVAL; > + } Please add trace support > + > if (*dev->dev_ops->dev_configure == NULL) > return -ENOTSUP; > ret = (*dev->dev_ops->dev_configure)(dev, dev_conf, > diff --git a/lib/dmadev/rte_dmadev.h b/lib/dmadev/rte_dmadev.h > index 5474a5281d..d59fcf1b61 100644 > --- a/lib/dmadev/rte_dmadev.h > +++ b/lib/dmadev/rte_dmadev.h > @@ -297,6 +297,10 @@ struct rte_dma_info { > int16_t numa_node; > /** Number of virtual DMA channel configured. */ > uint16_t nb_vchans; > + /** Number of priority levels (must be > 1), if supported by DMA HW channel. > + * 0 otherwise. > + */ > + uint16_t nb_priorities; Suggest add priority schedule policy capability, for example: RTE_DMA_CAPA_PRIORITY_POLICY_SP > }; > > /** > @@ -332,6 +336,13 @@ struct rte_dma_conf { > * @see RTE_DMA_CAPA_SILENT > */ > bool enable_silent; > + /* The prioirty of the DMA HW channel. > + * This value cannot be greater than or equal to the field 'nb_priorities' > + * of struct rte_dma_info which get from rte_dma_info_get(). > + * Among the values between '0' and 'nb_priorities - 1', lowest value > + * indicates higher priority and vice-versa. > + */ > + uint16_t priority; > }; > > /**