From: Thomas Monjalon <thomas@monjalon.net>
To: "Shelton, Benjamin H" <benjamin.h.shelton@intel.com>
Cc: dev@dpdk.org, "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: Clarify usage of TM node parent update API function
Date: Tue, 31 Jul 2018 18:52:02 +0200 [thread overview]
Message-ID: <2590450.z5BpaqTJhJ@xps> (raw)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891268E77C744@IRSMSX107.ger.corp.intel.com>
31/07/2018 17:09, Dumitrescu, Cristian:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> >
> > Cristian, review please?
> >
> > 10/07/2018 17:33, Ben Shelton:
> > > The node parent update API function may be used to update the
> > > priority/weight of an existing node. Update the documentation to
> > > indicate that this use case is supported.
> > >
> > > Signed-off-by: Ben Shelton <benjamin.h.shelton@intel.com>
> > [...]
> > > /**
> > > * Traffic manager node parent update
> > > *
> > > + * This function may be used to move a node and its children to a
> > different
> > > + * parent. Additionally, if the new parent is the same as the current
> > parent,
> > > + * this function will update the priority/weight of an existing node.
> > > + *
> > > * Restriction for root node: its parent cannot be changed.
> > > *
> > > * This function can only be called after the rte_tm_hierarchy_commit()
>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Applied, thanks
prev parent reply other threads:[~2018-07-31 16:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 15:33 Ben Shelton
2018-07-31 15:05 ` Thomas Monjalon
2018-07-31 15:09 ` Dumitrescu, Cristian
2018-07-31 16:52 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2590450.z5BpaqTJhJ@xps \
--to=thomas@monjalon.net \
--cc=benjamin.h.shelton@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).