From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id AB4B4378E for ; Tue, 31 Jul 2018 18:52:08 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 325B421AAA; Tue, 31 Jul 2018 12:52:08 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 31 Jul 2018 12:52:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=A9Keb1GVwhLbe0uvXf+p0HAJPQ i/LLm1wtdpMobe2Lg=; b=WvUBOdmTAxA18pdg/UtGaDzUKmie1Xevhcf0E1MMT/ fiipGOwx2xj2vWvoelD2g5rv7FK23vvb0DsVwGJa7DSKQqpUSf9e/igXdwk1g0hi 8zUtnA1d2USwsGj2Uaz4qKOIAalZX+vdKkYpK3pgnzicdsM7C4EFbz1Ao6z6inLQ A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=A9Keb1 GVwhLbe0uvXf+p0HAJPQi/LLm1wtdpMobe2Lg=; b=NVs3NJBsUTUcamhoAafCKW dTRWUFqFWkJjUZNa2O1gS4OgrlpfZYbUESmVhnwOfs5MkMjkdV/W7FIDT8jEALLg e61ebCZt1d4ailTH0HRZMNyw0241APQoJW9PXC8GsmHfgMbjPk3NCkC1QX9haXQy 1X/ctw8jE023ZnOK6tE+DYP9wfQlaPayep1AaoNtOpjMA4lg9wubnDRXTJSFgAPR yp1XzCVowrhCnJ2Lyv/HmpIHequqqAceicIy6F5XsrtboQ9RK61Fs8Z7/FN74qwJ 0q+acP6trNGkCwyPq26sdWu57KDAtZ6+oDU2urEfsL+N+EBk7oKQC9xyfuyEkLHw == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 490D41025D; Tue, 31 Jul 2018 12:52:07 -0400 (EDT) From: Thomas Monjalon To: "Shelton, Benjamin H" Cc: dev@dpdk.org, "Dumitrescu, Cristian" Date: Tue, 31 Jul 2018 18:52:02 +0200 Message-ID: <2590450.z5BpaqTJhJ@xps> In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891268E77C744@IRSMSX107.ger.corp.intel.com> References: <20180710153301.546-1-benjamin.h.shelton@intel.com> <1748890.xKDDESA46q@xps> <3EB4FA525960D640B5BDFFD6A3D891268E77C744@IRSMSX107.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: Clarify usage of TM node parent update API function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jul 2018 16:52:08 -0000 31/07/2018 17:09, Dumitrescu, Cristian: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > Cristian, review please? > > > > 10/07/2018 17:33, Ben Shelton: > > > The node parent update API function may be used to update the > > > priority/weight of an existing node. Update the documentation to > > > indicate that this use case is supported. > > > > > > Signed-off-by: Ben Shelton > > [...] > > > /** > > > * Traffic manager node parent update > > > * > > > + * This function may be used to move a node and its children to a > > different > > > + * parent. Additionally, if the new parent is the same as the current > > parent, > > > + * this function will update the priority/weight of an existing node. > > > + * > > > * Restriction for root node: its parent cannot be changed. > > > * > > > * This function can only be called after the rte_tm_hierarchy_commit() > > Acked-by: Cristian Dumitrescu Applied, thanks