From: Thomas Monjalon <thomas@monjalon.net>
To: Tanzeel-inline <tanxeel1.ahmed@gmail.com>
Cc: olivier.matz@6wind.com, dev@dpdk.org,
Tanzeel Ahmed <tanzeelahmed713@gmail.com>,
ferruh.yigit@amd.com
Subject: Re: [PATCH v2 2/2] lib/net: added push MPLS header API
Date: Mon, 06 Feb 2023 08:31:37 +0100 [thread overview]
Message-ID: <2591829.k3LOHGUjKi@thomas> (raw)
In-Reply-To: <1671319918-44725-1-git-send-email-tanxeel1.ahmed@gmail.com>
18/12/2022 00:31, Tanzeel-inline:
> The mpls hdr can't be const because the bs bit is updated by checking ether type.
>
> v2:
> * marked experimental
> * trailing blanks removed
> * space after /* and before */
> * updated to bracket cuddle style
> * changed rte_memcpy to memcpy
This patch is a change on top of the v1.
The new version should include all changes.
Also you should explain why you add this function.
I'm not sure it should be inline.
prev parent reply other threads:[~2023-02-06 7:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1671299771-10261-1-git-send-email-tanxeel1.ahmed@gmail.com>
2022-12-17 23:31 ` Tanzeel-inline
2023-02-06 7:31 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2591829.k3LOHGUjKi@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=olivier.matz@6wind.com \
--cc=tanxeel1.ahmed@gmail.com \
--cc=tanzeelahmed713@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).