From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id B3BB536E for ; Thu, 11 Feb 2016 08:59:36 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id p63so60774286wmp.1 for ; Wed, 10 Feb 2016 23:59:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=pjetMxTWoiR+eb170lVXftsfFCMOpmZ5QECSKPzP5Hw=; b=Ea4Gae/kIOSibLCoLDDRFbB74Qo9otSk+Dc6dfbn5PIyphds8pwSi8f6ndYdfN7O+R jSuD/mju2DYI5ig9L1xGUHwuldKQAQ2TGv/NVTp/tFlCAuRFMQWZEYvVSpGLJYV8i2qm tBQm0x7UI/RsKCTJxcdKh7BsUnq0mDxdgoVAqQ3oqyJHngA0y5Halza3bj55BzMb2M8l JtHEeZgm2cseiAuabgopPu4tssKMB8NE/nWgkTsOVcJawVUOp8fmIQPvPZP7z5o8Wri0 R1rO2t45f2pKm01tWhdYhkjZpGcJd4hK89PA3wsMTpBMuer8zr8N5ibeVwmqznEF1l/k pgKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=pjetMxTWoiR+eb170lVXftsfFCMOpmZ5QECSKPzP5Hw=; b=RD0Gp4L650z//hdkCIzKOHhke+EKivXs8Yom610kxs54l818lrrMCeCeS8R0nBCtUv 6j7gv9RAAE5zAcfdZ5sivBlzxozORwpTThB6FoECwxtLjw+qYpLhO/rQnXltN/xVtbM2 l3IQe2zEdQ0zA6RZ4+5o6titFrTpvAytmrY11dExeEhBBtLB3aqrIl21pDO6QTu5ql3h km4xNdP9kxHfeqbx0q5kar/QqI7KKZdQEng9MHX0OSvvrkxXKLygc8SunmyzDsc9jNv5 CjL24PPhwx1UfQmF55z40tQ2QmstA5ndtqP+Kf4lau+TKhgrcTvnNorpiS0M1yB2YND6 0nOw== X-Gm-Message-State: AG10YOQjtnv8PHl1ozvBu0+mPkjMWPVflSMK77Gut+Emf0MCiq2xIQPGZ5eVOLZB2/pcuAwz X-Received: by 10.28.184.137 with SMTP id i131mr15217038wmf.96.1455177576538; Wed, 10 Feb 2016 23:59:36 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id t12sm7573879wmt.20.2016.02.10.23.59.35 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 10 Feb 2016 23:59:35 -0800 (PST) From: Thomas Monjalon To: Seth Arnold Date: Thu, 11 Feb 2016 08:58:08 +0100 Message-ID: <2593509.xiuDro8IbH@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160211030540.GB25680@hunt> References: <20160211030540.GB25680@hunt> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] thoughts on DPDK after a few days of reading sources X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Feb 2016 07:59:36 -0000 Hi, 2016-02-10 19:05, Seth Arnold: > I've taken some notes while reading the sources; I'm sharing them in the > hopes that it's useful: on the one hand my fresh eyes may spot things that > you've overlooked, on the other hand your familiarity with the code means > that you're better suited to judge what I've found. Thanks for taking time and sharing, it's very valuable. > - shellcheck reports extensive cases of forgotten quotes to prevent word > splitting or globbing, potentially unused variables, error-prone printf > formatting. The scripts that are going to be used at runtime should be > fixed: > - ./debian/dpdk-init > - ./debian/dpdk.init These files are not in the tree. Should they? > - ./drivers/net/cxgbe/cxgbe_ethdev.c eth_cxgbe_dev_init() memory leak in > out_free_adapter: that doesn't free adapter > - ./drivers/net/virtio/virtio_ethdev.c virtio_set_multiple_queues() calls > virtio_send_command(), which performs: > memcpy(vq->virtio_net_hdr_mz->addr, ctrl, sizeof(struct virtio_pmd_ctrl)); > This copies a potentially huge amount of uninitialized data into ->addr > because the struct virtio_pmd_ctrl ctrl was not zeroed before being > passed. How much of this data leaves the system? Does this require a > CVE? We are not used to open a CVE. [...] > It's nearly impossible to solve issues without error reporting. Good > error reporting saves admins time and money. Until now, the errors were reported on the list and most often fixed quickly. While I agree we need a more formal process (a bug tracker), I think we must be noticed of new bugs on the mailing list. Since nobody was against the bugzilla proposal, a deployment will be planned. http://dpdk.org/ml/archives/dev/2015-August/023012.html