From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD32B42D66; Tue, 27 Jun 2023 02:40:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F17A4113F; Tue, 27 Jun 2023 02:40:01 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 1DA9240F18 for ; Tue, 27 Jun 2023 02:40:00 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id BCD945C0115; Mon, 26 Jun 2023 20:39:58 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 26 Jun 2023 20:39:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1687826398; x=1687912798; bh=xW+EhKwj6rIeh1EPH363607tdZuHiUCpAwG 0FSYjoMQ=; b=GXUjf9pj9v6Mtxe7mY0bDNrvT+UWRaxV1v9GyKIvQ5JcdGmS/Xk aydSFLJJQbhe6hTvAbA8JiYRET+gAUzLzCvvvEPlX6i4sWKHS3G8l0qk8B3GpkE9 El5rxyKZPqUJ9uCja6poJBIqYHdJB/JpGx3ker6m+PqxCv9CjrJ6s52E67JOK5En tvIvIc3qERY1/KaDgUKPD00r72KeNMg5hM5r8IP2Z2uKXlFjMEqqEDtwKSmikZxQ JXhuvnXj4CK5PF+RmN4UBxgqfYLw9dg99zDlsme/E7UDzFyyeornsy6iJDy5705f H8FpYCgOyooFlljcWUOhnsteKp3+9n9Z3kQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1687826398; x=1687912798; bh=xW+EhKwj6rIeh1EPH363607tdZuHiUCpAwG 0FSYjoMQ=; b=UQRFwNwKoJE15OWCcxdtipjcw1MgddT8/rBaqixRXBkEpXIcoIZ VcxJSDrJGqYTmBhAmIU05pikag30X43yHHn4v9lrbhw5Mgdc+gJ8S3fKQR2qX7++ QPUOy9lF46yf0gsdlzDhlXrEPqhKz7oizivbzzCD0581r1SNZN6O9l3qPOsoBcjR u5o/IwTYF8SJPFaWDJHtjRjm5odWKXv7V1Z4++jHtTubnoeLVX2dM5oXF2kppZTc Jadhya7D3ZuEF7PH6sF9Kxb/NV1L6uQX+uXf6YG9CZozu30vEzfFvxLN5U4omaxI JyFRN5rTQj8xL4PphvVNf3WlGMhlt64s5gQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeehgedgfeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkfgjfhgggfgtsehtqh ertddttdejnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghs sehmohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepgedttdeljeejgeffke ekkedtjeevtdehvedtkeeivdeuuedvieduvdelveejueejnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonh drnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 26 Jun 2023 20:39:57 -0400 (EDT) From: Thomas Monjalon To: Slava Ovsiienko Cc: dev@dpdk.org, Jerin Jacob , rasland@nvidia.com Subject: Re: [RFC 2/5] common/mlx5: introduce tracepoints for mlx5 drivers Date: Tue, 27 Jun 2023 02:39:55 +0200 Message-ID: <2594368.9Mp67QZiUf@thomas> In-Reply-To: References: <20230420100803.494-1-viacheslavo@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 13/06/2023 18:01, Jerin Jacob: > On Tue, Jun 13, 2023 at 9:29=E2=80=AFPM Slava Ovsiienko wrote: > > From: Jerin Jacob > > > On Tue, Jun 13, 2023 at 9:20=E2=80=AFPM Slava Ovsiienko > > > wrote: > > > > > > > > Hi, > > > > > > > > <..snip..> > > > > > > > > > > > > mlx5_os_interrupt_handler_create; # WINDOWS_NO_EXPORT > > > > > > mlx5_os_interrupt_handler_destroy; # WINDOWS_NO_EXPORT > > > > > > + > > > > > > + __rte_pmd_mlx5_trace_tx_entry; > > > > > > + __rte_pmd_mlx5_trace_tx_exit; > > > > > > + __rte_pmd_mlx5_trace_tx_wqe; > > > > > > + __rte_pmd_mlx5_trace_tx_wait; > > > > > > + __rte_pmd_mlx5_trace_tx_push; > > > > > > + __rte_pmd_mlx5_trace_tx_complete; > > > > > > > > > > No need to expose these symbols. It is getting removed from rest = of DPDK. > > > > > Application can do rte_trace_lookup() to get this address. > > > > > > > > > > > > > > It is not for application, it is for PMD itself, w/o exposing the s= ymbols build > > > failed. > > > > > > PMD is implementing this trace endpoints, not consuming this trace po= int. > > > Right? If so, Why to expose these symbols? > > > > As far as understand: > > The tracepoint routines are defined in dedicated common/mlx5_trace.c fi= le. > > The tx_burst in mlx5 is implemented as template in header file, and this > > template is used in multiple .c files under net/mlx5 filder. > > So, common/mlx5 should expose its symbols to net/mlx5 to allow successf= ul > > linkage. >=20 > OK. I missed the fact the these are in common code and net driver is > depened on that. > So changes makes sense. It does not make sense to me. These are tracepoints for the ethdev driver. Why declaring them in the common library?