DPDK patches and discussions
 help / color / Atom feed
* [dpdk-dev] [PATCH 1/3] test/eal: remove unneeded command
@ 2020-11-16 10:06 David Marchand
  2020-11-16 10:06 ` [dpdk-dev] [PATCH 2/3] doc: fix coremask option for eventdev pipeline David Marchand
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: David Marchand @ 2020-11-16 10:06 UTC (permalink / raw)
  To: dev; +Cc: thomas

All EAL flags tests are run by calling the "eal_flags_autotest" command.
There is no compatibility to maintain for sub commands only called by
meson.

Fixes: db27370b5720 ("eal: replace blacklist/whitelist options")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 app/test/meson.build      | 2 +-
 app/test/test_eal_flags.c | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/app/test/meson.build b/app/test/meson.build
index 88c831a92e..94fd39fecb 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -195,7 +195,7 @@ fast_tests = [
         ['eal_flags_n_opt_autotest', false],
         ['eal_flags_hpet_autotest', false],
         ['eal_flags_no_huge_autotest', false],
-        ['eal_flags_w_opt_autotest', false],
+        ['eal_flags_a_opt_autotest', false],
         ['eal_flags_b_opt_autotest', false],
         ['eal_flags_vdev_opt_autotest', false],
         ['eal_flags_r_opt_autotest', false],
diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index 85b6c6d7c7..932fbe3d08 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -1546,7 +1546,6 @@ REGISTER_TEST_COMMAND(eal_flags_main_opt_autotest, test_main_lcore_flag);
 REGISTER_TEST_COMMAND(eal_flags_n_opt_autotest, test_invalid_n_flag);
 REGISTER_TEST_COMMAND(eal_flags_hpet_autotest, test_no_hpet_flag);
 REGISTER_TEST_COMMAND(eal_flags_no_huge_autotest, test_no_huge_flag);
-REGISTER_TEST_COMMAND(eal_flags_w_opt_autotest, test_allow_flag); /* for legacy CI */
 REGISTER_TEST_COMMAND(eal_flags_a_opt_autotest, test_allow_flag);
 REGISTER_TEST_COMMAND(eal_flags_b_opt_autotest, test_invalid_b_flag);
 REGISTER_TEST_COMMAND(eal_flags_vdev_opt_autotest, test_invalid_vdev_flag);
-- 
2.23.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dpdk-dev] [PATCH 2/3] doc: fix coremask option for eventdev pipeline
  2020-11-16 10:06 [dpdk-dev] [PATCH 1/3] test/eal: remove unneeded command David Marchand
@ 2020-11-16 10:06 ` David Marchand
  2020-11-19 18:47   ` Thomas Monjalon
  2020-11-16 10:06 ` [dpdk-dev] [PATCH 3/3] bus/vdev: fix comment David Marchand
  2020-11-19 18:50 ` [dpdk-dev] [PATCH 1/3] test/eal: remove unneeded command Thomas Monjalon
  2 siblings, 1 reply; 7+ messages in thread
From: David Marchand @ 2020-11-16 10:06 UTC (permalink / raw)
  To: dev; +Cc: thomas

-w option in this context is an application option for coremask.
Restore it.

Fixes: db27370b5720 ("eal: replace blacklist/whitelist options")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 doc/guides/sample_app_ug/eventdev_pipeline.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guides/sample_app_ug/eventdev_pipeline.rst b/doc/guides/sample_app_ug/eventdev_pipeline.rst
index 41ee8b7ee3..4508c3dcc8 100644
--- a/doc/guides/sample_app_ug/eventdev_pipeline.rst
+++ b/doc/guides/sample_app_ug/eventdev_pipeline.rst
@@ -47,7 +47,7 @@ these settings is shown below:
 .. code-block:: console
 
     ./<build_dir>/examples/dpdk-eventdev_pipeline --vdev event_sw0 -- -r1 -t1 \
-    -e4 -a FF00 -s4 -n0 -c32 -W1000 -D
+    -e4 -w FF00 -s4 -n0 -c32 -W1000 -D
 
 The application has some sanity checking built-in, so if there is a function
 (e.g.; the RX core) which doesn't have a cpu core mask assigned, the application
-- 
2.23.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dpdk-dev] [PATCH 3/3] bus/vdev: fix comment
  2020-11-16 10:06 [dpdk-dev] [PATCH 1/3] test/eal: remove unneeded command David Marchand
  2020-11-16 10:06 ` [dpdk-dev] [PATCH 2/3] doc: fix coremask option for eventdev pipeline David Marchand
@ 2020-11-16 10:06 ` David Marchand
  2020-11-19 18:48   ` Thomas Monjalon
  2020-11-19 18:50 ` [dpdk-dev] [PATCH 1/3] test/eal: remove unneeded command Thomas Monjalon
  2 siblings, 1 reply; 7+ messages in thread
From: David Marchand @ 2020-11-16 10:06 UTC (permalink / raw)
  To: dev; +Cc: thomas

RTE_DEV_WHITELISTED is now replaced with RTE_DEV_ALLOWED.

Fixes: a65a34a85ebf ("eal: replace usage of blacklist/whitelist in enums")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 drivers/bus/vdev/vdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
index 0e94ea9d26..acfd78828f 100644
--- a/drivers/bus/vdev/vdev.c
+++ b/drivers/bus/vdev/vdev.c
@@ -498,7 +498,7 @@ vdev_scan(void)
 			 * by calling rte_devargs_insert() with
 			 *     devargs.bus = rte_bus_find_by_name("vdev");
 			 *     devargs.type = RTE_DEVTYPE_VIRTUAL;
-			 *     devargs.policy = RTE_DEV_WHITELISTED;
+			 *     devargs.policy = RTE_DEV_ALLOWED;
 			 */
 			custom_scan->callback(custom_scan->user_arg);
 	}
-- 
2.23.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH 2/3] doc: fix coremask option for eventdev pipeline
  2020-11-16 10:06 ` [dpdk-dev] [PATCH 2/3] doc: fix coremask option for eventdev pipeline David Marchand
@ 2020-11-19 18:47   ` Thomas Monjalon
  0 siblings, 0 replies; 7+ messages in thread
From: Thomas Monjalon @ 2020-11-19 18:47 UTC (permalink / raw)
  To: David Marchand; +Cc: dev

16/11/2020 11:06, David Marchand:
> -w option in this context is an application option for coremask.
> Restore it.
> 
> Fixes: db27370b5720 ("eal: replace blacklist/whitelist options")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

That's my mistake.

Acked-by: Thomas Monjalon <thomas@monjalon.net>




^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH 3/3] bus/vdev: fix comment
  2020-11-16 10:06 ` [dpdk-dev] [PATCH 3/3] bus/vdev: fix comment David Marchand
@ 2020-11-19 18:48   ` Thomas Monjalon
  0 siblings, 0 replies; 7+ messages in thread
From: Thomas Monjalon @ 2020-11-19 18:48 UTC (permalink / raw)
  To: David Marchand; +Cc: dev, stephen

16/11/2020 11:06, David Marchand:
> RTE_DEV_WHITELISTED is now replaced with RTE_DEV_ALLOWED.
> 
> Fixes: a65a34a85ebf ("eal: replace usage of blacklist/whitelist in enums")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Acked-by: Thomas Monjalon <thomas@monjalon.net>




^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH 1/3] test/eal: remove unneeded command
  2020-11-16 10:06 [dpdk-dev] [PATCH 1/3] test/eal: remove unneeded command David Marchand
  2020-11-16 10:06 ` [dpdk-dev] [PATCH 2/3] doc: fix coremask option for eventdev pipeline David Marchand
  2020-11-16 10:06 ` [dpdk-dev] [PATCH 3/3] bus/vdev: fix comment David Marchand
@ 2020-11-19 18:50 ` Thomas Monjalon
  2020-11-20  9:00   ` David Marchand
  2 siblings, 1 reply; 7+ messages in thread
From: Thomas Monjalon @ 2020-11-19 18:50 UTC (permalink / raw)
  To: David Marchand; +Cc: dev, stephen, bluca, bruce.richardson

16/11/2020 11:06, David Marchand:
> All EAL flags tests are run by calling the "eal_flags_autotest" command.
> There is no compatibility to maintain for sub commands only called by
> meson.
> 
> Fixes: db27370b5720 ("eal: replace blacklist/whitelist options")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Acked-by: Thomas Monjalon <thomas@monjalon.net>




^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH 1/3] test/eal: remove unneeded command
  2020-11-19 18:50 ` [dpdk-dev] [PATCH 1/3] test/eal: remove unneeded command Thomas Monjalon
@ 2020-11-20  9:00   ` David Marchand
  0 siblings, 0 replies; 7+ messages in thread
From: David Marchand @ 2020-11-20  9:00 UTC (permalink / raw)
  To: David Marchand
  Cc: dev, Stephen Hemminger, Luca Boccassi, Bruce Richardson, Thomas Monjalon

On Thu, Nov 19, 2020 at 7:50 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 16/11/2020 11:06, David Marchand:
> > All EAL flags tests are run by calling the "eal_flags_autotest" command.
> > There is no compatibility to maintain for sub commands only called by
> > meson.
> >
> > Fixes: db27370b5720 ("eal: replace blacklist/whitelist options")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>

Series applied.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-16 10:06 [dpdk-dev] [PATCH 1/3] test/eal: remove unneeded command David Marchand
2020-11-16 10:06 ` [dpdk-dev] [PATCH 2/3] doc: fix coremask option for eventdev pipeline David Marchand
2020-11-19 18:47   ` Thomas Monjalon
2020-11-16 10:06 ` [dpdk-dev] [PATCH 3/3] bus/vdev: fix comment David Marchand
2020-11-19 18:48   ` Thomas Monjalon
2020-11-19 18:50 ` [dpdk-dev] [PATCH 1/3] test/eal: remove unneeded command Thomas Monjalon
2020-11-20  9:00   ` David Marchand

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox