From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 759E3A04B4; Fri, 8 Nov 2019 17:28:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 332EF1C1D9; Fri, 8 Nov 2019 17:28:53 +0100 (CET) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 6967E1C067 for ; Fri, 8 Nov 2019 17:28:51 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id F2CD2421; Fri, 8 Nov 2019 11:28:49 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 08 Nov 2019 11:28:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=DDQSjv6DtRSFtNfiFHkpYWodmc5D7bfi0/cEdGydOp4=; b=pVcU2wFwz2ek AdjOFBgUHlM71Nq6dVhXG+INz1V/rLDrMPTg8YReipvKaV/0r2czYXHMcqcvcsKl QMStwWBQfjgkSyQv0qgy4UuETCtutG/SvfKCpZegO1hMbVDr9tijux4kW8PFoI/F YGYMtBCKFyZP87VH5MQosPfBTNxQo2E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=DDQSjv6DtRSFtNfiFHkpYWodmc5D7bfi0/cEdGydO p4=; b=k6Na3/xt+JkLltm+ItCR7Tf7pMUhmLPkjCcLL7eiNt/Dv/h1/V/aRsNKm uuATUlQW+FDtWBAuZYPQbDOJu+4/PcmmrG+y0fPTVDek6NAfqKZcynlV4TZfemMu LXJKd3u+W5RdqUkUX3pkScsF//o9r/NTKCYbiXeuHkv3tC6Vhn/bE2fMnaU4gZ0O ITNmVmm2R4snHwfnWcMwoLQo0aKzcbs78GighfWvBBXRBFRoxnVrFDBqj4axoUcm XCdca2XMfZA7KbeWgMazwaWWFQ193qsuhsPVhgo4cRZ85aTYQ89aM1DwBN0BMy80 UpJIuZFZpUKN0p4mg77QVr38wf3fQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedruddvuddgledtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id F0285306005B; Fri, 8 Nov 2019 11:28:47 -0500 (EST) From: Thomas Monjalon To: Stephen Hemminger Cc: Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , Olivier Matz , dev@dpdk.org Date: Fri, 08 Nov 2019 17:28:46 +0100 Message-ID: <2596988.FVioC1GkKV@xps> In-Reply-To: <20191108081553.78d1900d@hermes.lan> References: <20191106120943.15967-1-thomas@monjalon.net> <20191108081553.78d1900d@hermes.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] cmdline: replace FreeBSD ifdef for IP address parsing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/11/2019 17:15, Stephen Hemminger: > On Wed, 6 Nov 2019 13:09:43 +0100 > Thomas Monjalon wrote: > > > The constants like AF_INET are in sys/socket.h in FreeBSD. > > The #ifdef macro __FreeBSD__ is replaced with RTE_EXEC_ENV_FREEBSD > > in order to be consistent across DPDK files, and allow to grep > > for EXEC_ENV among other benefits. > > > > Signed-off-by: Thomas Monjalon > > --- > > -#ifdef __FreeBSD__ > > +#ifdef RTE_EXEC_ENV_FREEBSD > > #include > > #endif > > Why not always include sys/socket.h having an extra include > is much less of a nuisance than a silly #ifdef. Yes, good suggestion. David already merged the patch. Do you want to propose a patch on top?