From: Thomas Monjalon <thomas@monjalon.net>
To: Gregory Etelson <getelson@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Matan Azrad <matan@nvidia.com>,
Raslan Darawsheh <rasland@nvidia.com>, Ori Kam <orika@nvidia.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
Ferruh Yigit <ferruh.yigit@amd.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
"ivan.malov@oktetlabs.ru" <ivan.malov@oktetlabs.ru>,
"jerinj@marvell.com" <jerinj@marvell.com>
Subject: Re: [PATCH v4 2/2] ethdev: add quota flow action and item
Date: Thu, 19 Jan 2023 10:31:22 +0100 [thread overview]
Message-ID: <2597127.MzOyzyC30C@thomas> (raw)
In-Reply-To: <IA1PR12MB6332111DCDE9BD17D99DB868A5C49@IA1PR12MB6332.namprd12.prod.outlook.com>
19/01/2023 10:13, Gregory Etelson:
> Hello Thomas,
>
> > Is this patch related to query/update of indirect flow action?
> > It looks like it should be in a separate series.
> >
>
> Quota flow action updates relay on rte_flow_action_handle_query_update().
> Also, the function is used in the testmd patch section.
Yes we still don't have the tool in CI to mark series dependency.
> > > + /**
> > > + * Apply quota verdict - PASS or BLOCK to a flow.
> >
> > Is "to" really wanted here?
> > What about "pass or block a flow"?
> >
>
> The flow action provides information only - it does not affect flow in any way.
> Application needs to match on quota flow item after quota action to discover quota state.
> It's also up to application how to react on quota state.
I am still not sure to understand the comment.
Is this one better?
"Apply the quota verdict (PASS or BLOCK) to a flow."
> > > +struct rte_flow_action_quota {
> > > + enum rte_flow_quota_mode mode; /** quota operational mode */
> > > + int64_t quota; /** quota value */
> >
> > What means a negative quota?
>
> Negative quota is kind of a loan extended by a hardware if it provides such option.
> If quota value is -T, application must provide at least (T+1) tokens to return quota to PASS state.
OK. Is it documented?
next prev parent reply other threads:[~2023-01-19 9:31 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 7:35 [PATCH 1/2] ethdev: add query_update sync and async function calls Gregory Etelson
2022-12-21 7:35 ` [PATCH 2/2] ethdev: add quota flow action and item Gregory Etelson
2023-01-08 13:47 ` Ori Kam
2023-01-04 9:56 ` [PATCH 1/2] ethdev: add query_update sync and async function calls Ori Kam
2023-01-11 9:28 ` Gregory Etelson
2023-01-11 9:22 ` [PATCH v2 " Gregory Etelson
2023-01-11 9:22 ` [PATCH v2 2/2] ethdev: add quota flow action and item Gregory Etelson
2023-01-11 12:20 ` [PATCH v3 1/2] ethdev: add query_update sync and async function calls Gregory Etelson
2023-01-11 12:20 ` [PATCH v3 2/2] ethdev: add quota flow action and item Gregory Etelson
2023-01-18 10:31 ` [PATCH v4 1/2] ethdev: add query_update sync and async function calls Gregory Etelson
2023-01-18 10:31 ` [PATCH v4 2/2] ethdev: add quota flow action and item Gregory Etelson
2023-01-18 14:03 ` Thomas Monjalon
2023-01-19 9:13 ` Gregory Etelson
2023-01-19 9:31 ` Thomas Monjalon [this message]
2023-01-19 9:39 ` Gregory Etelson
2023-01-18 13:56 ` [PATCH v4 1/2] ethdev: add query_update sync and async function calls Thomas Monjalon
2023-01-18 17:34 ` Gregory Etelson
2023-01-19 8:44 ` Thomas Monjalon
2023-01-19 13:25 ` [PATCH v5 " Gregory Etelson
2023-01-19 13:25 ` [PATCH v5 2/2] ethdev: add quota flow action and item Gregory Etelson
2023-01-19 16:47 ` [PATCH v6 1/2] ethdev: add query_update sync and async function calls Gregory Etelson
2023-01-19 16:47 ` [PATCH v6 2/2] ethdev: add quota flow action and item Gregory Etelson
2023-01-20 8:52 ` Andrew Rybchenko
2023-01-24 9:26 ` Gregory Etelson
2023-01-20 8:35 ` [PATCH v6 1/2] ethdev: add query_update sync and async function calls Andrew Rybchenko
2023-01-20 10:46 ` Gregory Etelson
2023-01-20 11:22 ` Andrew Rybchenko
2023-01-20 16:50 ` Gregory Etelson
2023-02-01 11:00 ` Andrew Rybchenko
2023-02-01 14:03 ` Gregory Etelson
2023-01-24 9:37 ` [PATCH v7 " Gregory Etelson
2023-01-24 9:37 ` [PATCH v7 2/2] ethdev: add quota flow action and item Gregory Etelson
2023-02-01 11:22 ` Andrew Rybchenko
2023-02-01 15:09 ` Gregory Etelson
2023-02-01 11:16 ` [PATCH v7 1/2] ethdev: add query_update sync and async function calls Andrew Rybchenko
2023-02-01 14:52 ` Gregory Etelson
2023-02-01 15:16 ` [PATCH v8 " Gregory Etelson
2023-02-01 15:16 ` [PATCH v8 2/2] ethdev: add quota flow action and item Gregory Etelson
2023-02-02 9:17 ` Andrew Rybchenko
2023-02-01 17:30 ` [PATCH v8 1/2] ethdev: add query_update sync and async function calls Ori Kam
2023-02-02 9:15 ` Andrew Rybchenko
2023-02-02 10:24 ` Gregory Etelson
2023-02-02 10:30 ` Andrew Rybchenko
2023-02-02 10:44 ` Gregory Etelson
2023-02-02 10:47 ` Andrew Rybchenko
2023-02-02 11:54 ` [PATCH v9 1/2] ethdev: add query and update " Gregory Etelson
2023-02-02 11:54 ` [PATCH v9 2/2] ethdev: add quota flow action and item Gregory Etelson
2023-02-02 12:13 ` [PATCH v9 1/2] ethdev: add query and update sync and async function calls Andrew Rybchenko
2023-02-09 19:16 ` Gregory Etelson
2023-02-02 13:47 ` [PATCH v10 " Gregory Etelson
2023-02-02 13:47 ` [PATCH v10 2/2] ethdev: add quota flow action and item Gregory Etelson
2023-02-19 17:04 ` Thomas Monjalon
2023-02-07 16:03 ` [PATCH v10 1/2] ethdev: add query and update sync and async function calls Gregory Etelson
2023-02-09 15:13 ` Ferruh Yigit
2023-02-09 16:10 ` Gregory Etelson
2023-02-12 11:13 ` Gregory Etelson
2023-02-13 12:30 ` Gregory Etelson
2023-02-16 15:43 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2597127.MzOyzyC30C@thomas \
--to=thomas@monjalon.net \
--cc=aman.deep.singh@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=getelson@nvidia.com \
--cc=ivan.malov@oktetlabs.ru \
--cc=jerinj@marvell.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=viacheslavo@nvidia.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).