From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id A01351B16C for ; Wed, 10 Jan 2018 12:07:47 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4074320A90; Wed, 10 Jan 2018 06:07:47 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 10 Jan 2018 06:07:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=CvM+jh9QnBHkoCBOSuK1yuGkmL QU120WvzHpERR4eKU=; b=ibbKZCUv8bKEQhGI8B9SLCiRroUtO8h+yJ/gYFHC4t UV6gtHMv6c2YN25FHP9s62Shog1xvutoslsL+7mhJ+Qeo/hSkalQzJA/cVyGvkoj BhuRyoziZW3Erf8F/Dl4nCxPqA2K1w+qn3F4J4QbuyFYSACYTd+apt9bPiuQVsYj k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=CvM+jh 9QnBHkoCBOSuK1yuGkmLQU120WvzHpERR4eKU=; b=CkQrTsHrbwFaCQHmTgsOqY IC86vqAv/31lfqv4JKGkvX7noyfZXbhxpIc8EOajWTHBS3EFfUkfs/x/NR+H++Rc qg8/HFJn5iNgelPDzt3Nt39nX3R99YpseTmoSjoYlQg2jv2s9Ds0f9MgGwAVXjKl n+qlbbopREJaWl7AQccVX8mkqbRC1G5smrQwIJizwRRFGfmNdutUyjskJC/beiO6 3zF22wzArh5ojFXUEjTA/kkDZAT0xTDTYh/pSHBAs2c6biUr6NHcZvkvvQmk0gZy i1VUs5yqw705pmhFLmEXgELcB8981pVkp3MZa/ei/CJel/23fnEJdPKh2EZ1by7Q == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E261D24608; Wed, 10 Jan 2018 06:07:46 -0500 (EST) From: Thomas Monjalon To: "Singh, Jasvinder" Cc: dev@dpdk.org, "Iremonger, Bernard" , "Kovacevic, Marko" Date: Wed, 10 Jan 2018 12:07:21 +0100 Message-ID: <2597712.le8lxF3Odu@xps> In-Reply-To: <54CBAA185211B4429112C315DA58FF6D332C3E9C@IRSMSX103.ger.corp.intel.com> References: <20171215103924.5185-1-jasvinder.singh@intel.com> <2144605.X1J6VfJWv8@xps> <54CBAA185211B4429112C315DA58FF6D332C3E9C@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 1/4] lib/librte_flow_classify: remove table id parameter from apis X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 11:07:47 -0000 10/01/2018 11:59, Singh, Jasvinder: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 10/01/2018 10:54, Singh, Jasvinder: > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > 19/12/2017 15:29, Jasvinder Singh: > > > > > This patch removes table id parameter from all the flow classify > > > > > apis to reduce the complexity alongwith some code cleanup. > > > > > > > > > > The validate api is exposed as public api to allow user to > > > > > validate the flow before adding it to the classifier. > > > > > > > > This patch does not compile alone. > > > > Should we merge all patches together? > > > > > > No, It should compile alone. On my system it doesn't show any error and > > compilation goes successfully. Could you send me error log, etc ? > > > > test/test/test_flow_classify.c:48:10: fatal error: too many arguments to > > function call, expected 6, have 7 > > NULL, NULL); > > ^~~~ > > > > I guess it is expected that test and example does not compile after patch 1. > > That's why I suggest to merge all 4 patches. > > Ok, I will send revised patch with all merged into one. I can merge them myself, it is fine.