From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com
 [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 108B4B102
 for <dev@dpdk.org>; Fri, 27 Jun 2014 02:23:15 +0200 (CEST)
Received: by mail-wi0-f182.google.com with SMTP id bs8so1917464wib.9
 for <dev@dpdk.org>; Thu, 26 Jun 2014 17:23:34 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=xKRY4iGB4ZEthc+wQ9eZhjk0S6f4rwhdo+PxfdvlX44=;
 b=FxJgW8hw1pptvlflcL8P2lZgJSjji4NXACZ9gY8zcDmUj3TXQ6AMacvJzsw9UrJdVi
 1ZCrVFoX/3D8cQAz8EfnY1vsVbQ5BKMnStuF3KaY7yr6siBdpHrzlQuOyiMf6f9ODXsr
 WK5hDnO0DPyA/047PdWPSF/YH09YYIHaVbM9dI4oscVUVvfmmgBhuDZNt3IKmpqfAFIO
 w2ui3MWLfZpF7s3ezu0J9dg6RakZhZugnhw/2Y39Zpmju4ptzZiv3yrwtxQoPsBXy+Ee
 z4K8FBlSuXlkFfsSxr0RSXRlxbhesedu+pWKiHSQbvs//8UZxuo6PB0E6fy/12yYnuyD
 LyGg==
X-Gm-Message-State: ALoCoQm0Jab0Uj5QMkwEjKuX9fpLK0QyjHw3PgMxnqs/KFVeddP2UhDE8OnST9X82hSu+GyPIaAu
X-Received: by 10.194.60.110 with SMTP id g14mr21625788wjr.101.1403828614107; 
 Thu, 26 Jun 2014 17:23:34 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id i3sm71441068wiz.13.2014.06.26.17.23.32
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 26 Jun 2014 17:23:33 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Date: Fri, 27 Jun 2014 02:23:28 +0200
Message-ID: <2599116.QEv1WnnULv@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; )
In-Reply-To: <4709584.nAXykbU3l6@xps13>
References: <20140619151238.28b9bbea@nehalam.linuxnetplumber.net>
 <4709584.nAXykbU3l6@xps13>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] rte_ethdev: add link support flag
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Jun 2014 00:23:15 -0000

2014-06-20 15:06, Thomas Monjalon:
> 2014-06-19 15:12, Stephen Hemminger:
> > Only some devices support the link state interrupt configuration option.
> > Link state control does not work in virtual drivers
> > (virtio, vmxnet3, igbvf, and ixgbevf). Instead of having the application
> > try and guess whether it will work or not provide a driver flag that
> > can be checked instead.
> > 
> > Note: if device driver doesn't support link state control, what
> > would happen previously is that the code would never detect link
> > transitions. This prevents that.
> 
> [...]
> 
> > @@ -197,6 +197,8 @@ struct rte_pci_driver {
> > 
> >  #define RTE_PCI_DRV_MULTIPLE 0x0002
> >  /** Device needs to be unbound even if no module is provided */
> >  #define RTE_PCI_DRV_FORCE_UNBIND 0x0004
> > 
> > +/** Device driver supports link state interrupt */
> > +#define RTE_PCI_DRV_LSC	0x0008
> 
> I feel RTE_PCI_DRV_INTR_LSC would be easier to understand.
> Do you agree?
> 
> Note that related event is RTE_ETH_EVENT_INTR_LSC
> and configuration is intr_conf.lsc.

Applied with flag renamed.

Thanks
-- 
Thomas