From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54])
by dpdk.org (Postfix) with ESMTP id 616AEFBCD
for <dev@dpdk.org>; Tue, 20 Dec 2016 18:21:59 +0100 (CET)
Received: by mail-wm0-f54.google.com with SMTP id g23so126675847wme.1
for <dev@dpdk.org>; Tue, 20 Dec 2016 09:21:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=6wind-com.20150623.gappssmtp.com; s=20150623;
h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=QuatCuOWKv0XD463mQw6/88q2it8gfeaj/zvTAM4S3M=;
b=rqPDRcLD+cx9RfD4JLprXDPYFh97YdfWbjjlVc/DlGspSXA6g0f6HGGq9w/hWVKccg
5/mVqjy9wIo8iddGgd4sCU4uvp2ANvOGQ2RBSUGWHG9pFBlx5DBclXTrlnA9nZEaqplQ
BlmblVPlwYH4N+99WsCf9ZdCjmLeoQ46L+AshWPD+jUAKqFJAmSNbdN93/IOkRK++29V
fqPoWNv0HNGEce8JHtwWtPqYM7Mn6QwsB4JPRIHJnp+TzBPQevrs6y5OoRro3nvB2vJ6
uprkJ173ABAGje/+GZp4izJQGyfDqP0qGb+orCgfE7RBJBx/ATYIdAXfJMHGWBwfdP8w
h3cg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
:in-reply-to:references:mime-version:content-transfer-encoding;
bh=QuatCuOWKv0XD463mQw6/88q2it8gfeaj/zvTAM4S3M=;
b=gSAo3pZPK86CWvwVvIxZupUfiK1a9OqW4oyz5yaDHJNUQZuI4Ea4XnTkefysio65H2
b5QtqhKh2wquYLO9ms9IMVwo67uTBqv+VbxYvvHI4NFbhX0rJiuPOaDoR+6rMfdsvWEh
x62TGuCsGl7Xxc+Xnyo7YyAisgXoLv4DmKS3VtdcAZCVgmjOp6035YLdtNBOuJrhqHmw
ud/wGPyvqRjcKGDI8ZD8lI6gfT3RZBjkgNXezc8KEFuIHIFq7inX9vFyfX/SEZJpoIAL
MzAPdcZf/tt4RuvakvNksknZfsZlSlWrEvpPU0vCTYnqS/8LciZ5hpLW7ps5D/WAz3Q1
prKQ==
X-Gm-Message-State: AIkVDXLAmuzbfurabIOlizCbqVd3Ld/rHavK3mZhA9ib0PEJR3czkKWca1AKhWgANm9riIx5
X-Received: by 10.28.152.79 with SMTP id a76mr913773wme.47.1482254519116;
Tue, 20 Dec 2016 09:21:59 -0800 (PST)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
by smtp.gmail.com with ESMTPSA id g73sm23090112wme.16.2016.12.20.09.21.58
(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Tue, 20 Dec 2016 09:21:58 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Qiming Yang <qiming.yang@intel.com>
Cc: dev@dpdk.org, Remy Horton <remy.horton@intel.com>
Date: Tue, 20 Dec 2016 18:21:57 +0100
Message-ID: <2599766.5RT2cabHtI@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <f5d536d4-fe53-5ff9-4f6f-add6f102c171@intel.com>
References: <1479462013-11562-1-git-send-email-qiming.yang@intel.com>
<1479778884-26993-1-git-send-email-qiming.yang@intel.com>
<f5d536d4-fe53-5ff9-4f6f-add6f102c171@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] examples/ethtool: fix bug in drvinfo
callback
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Dec 2016 17:21:59 -0000
2016-11-23 09:00, Remy Horton:
> Not sure this is a problem in practice, as the same set if fields is
> updated each time...at least for now.
>
> On 22/11/2016 09:41, Qiming Yang wrote:
> > Function pcmd_drvinfo_callback uses struct info to get
> > the ethtool information of each port. Struct info will
> > store the information of previous port until this
> > information be updated. This patch fixes this issue.
> >
> > Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application")
> >
> > Signed-off-by: Qiming Yang <qiming.yang@intel.com>
>
> Acked-by: Remy Horton <remy.horton@intel.com>
Applied, thanks