From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23E1CA0032; Wed, 14 Sep 2022 11:37:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C67194021D; Wed, 14 Sep 2022 11:37:10 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id A8A1740156 for ; Wed, 14 Sep 2022 11:37:09 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 5F34B5C00A9; Wed, 14 Sep 2022 05:37:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 14 Sep 2022 05:37:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1663148229; x= 1663234629; bh=FsaFh5qbPoY/uAMNDd5+U49TqkmlZ76KnCwDPhhc4bI=; b=V 5zjnl4iVLSJ5dt2Rj0a2WWbbXi0oBL8QZbAldh6uQheFcLv8HAns4Lgn2fL9Ojf0 f1urcfq9XHVC0UsG+7g6Pys/kwKqaQdG88jult342CPaC/K5Mbh0oUAipi51m+JJ wM4301xc2oL/viN2QVwGrhLUGO+VG737sOS80xHoqddf6SniJjQW8LjWoS0CwWiN ah6Fgo1UjFayNPOfVodMS8hugt1GVIG22YcksCERNI5R5mnQlw2sUlUOpxz3rBd6 lGdBk2PtTFttcexsBU0akyGer3P5RIIwlN1HJHbYatPGOWHVoXA/3N41pnsUMN5r rJnXiv0S7pRozi9gCzVEQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663148229; x= 1663234629; bh=FsaFh5qbPoY/uAMNDd5+U49TqkmlZ76KnCwDPhhc4bI=; b=b 0oswxbgEMy1Q5QjYqS5mFuH379HqDlcH62751Lwolrin+fqFVk7jndFAUs+1nyLK A7qIMosaXNnGwyqEYDX9+0z0K8IWaYrVGWMfRPIL2ORrfoVvhIFVe4g5yxtYZD/Z FL5Ir/81DmBQbLJdUYzoaw+7VA2ydnOobUhB1h9HpR1fKzN5dDv53uK3yXvMyGqT dIj7UDz2jVywRAgrwXPM1sIOuAq9CT9WxBqHK5lyuqaqlGEqNFkV7zxP2HegwvZ9 znCUljF3X2I+woTqZgQlKcTY6lniQIkEJH6B86WNbsUEXCteo5cfmrrs6VRseOSW AbypchckJsgyEft1K151A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeduiedgudekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeehvdejffefudfhudelieefhfeujefhudelieekleekheehlefg keevuedvleehteenucffohhmrghinhepvgguihhtohhrtghonhhfihhgrdhorhhgpdhrvg grughthhgvughotghsrdhiohenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Sep 2022 05:37:07 -0400 (EDT) From: Thomas Monjalon To: Juraj =?utf-8?B?TGlua2XFoQ==?= , Bruce Richardson , Honnappa Nagarahalli Cc: "david.marchand@redhat.com" , "ronan.randles@intel.com" , "ohilyard@iol.unh.edu" , "lijuan.tu@intel.com" , "dev@dpdk.org" Subject: Re: [PATCH v4 1/9] dts: add project tools config Date: Wed, 14 Sep 2022 11:37:06 +0200 Message-ID: <2599934.X9hSmTKtgW@thomas> In-Reply-To: References: <20220728100044.1318484-1-juraj.linkes@pantheon.tech> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 13/09/2022 21:19, Honnappa Nagarahalli: > > > > > > --- /dev/null > > > > > > +++ b/dts/.editorconfig > > > > > > @@ -0,0 +1,7 @@ > > > > > > +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2022 > > > > > > +PANTHEON.tech s.r.o. > > > > > > +# See https://editorconfig.org/ for syntax reference. > > > > > > +# > > > > > > + > > > > > > +[*.py] > > > > > > +max_line_length = 88 > > > > > > > > > > It seems strange to have two different editorconfig settings in > > > > > DPDK. Is there a reason that: > > > > > a) we can't use 79, the current DPDK default and recommended length by > > > > > pycodestyle? Or alternatively: > > > > > b) change all of DPDK to use the 88 setting? > > > > > > > > > > Also, 88 seems an unusual number. How was it chosen/arrived at? > > > > > > > > > > > > > The commit message contains a link to Black's documentation where > > > > they > > > explain it: > > > > https://black.readthedocs.io/en/stable/the_black_code_style/current_ > > > > st > > > > yle.html#line-length > > > > > > > > Let me know what you think about it. I think it's reasonable. I'll > > > > move the > > > config to the top level .editorconfig file. > > > > > > > > > > I have no objection to moving this to the top level, but others may > > > like to keep our python style as standard. Realistically I see three choices here: > > > > > > 1. Force DTS to conform to existing DPDK python style of 79 characters > > > 2. Allow DTS to use 88 chars but the rest of DPDK to keep with 79 > > > chars 3. Allow all of DPDK to use 88 chars. > > > > > > Of the 3, I like relaxing the 79/80 char limit so #3 seems best to me > > > as you suggest. However, I'd wait a few days for a desenting opinion > > > before I'd do a new patchset revision. :-) > +1 for option #3, it seems reasonable In .editorconfig, we have this default: max_line_length = 100 It is also documented in our guide. For Python we have this exception: [*.py] indent_style = space indent_size = 4 max_line_length = 79 I'm OK to increase it to 88 as it does not exceed the default. In any case, it should be documented in the style guide.