From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D73745895; Thu, 29 Aug 2024 11:01:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C43C42D89; Thu, 29 Aug 2024 11:00:45 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by mails.dpdk.org (Postfix) with ESMTP id 71D3B42D7F for ; Thu, 29 Aug 2024 11:00:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724922040; x=1756458040; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=ML7TpOrEuCbbx1MlPLyvyBfjakv7V3HPGTiack99HoI=; b=QjNrfD4MnsS3JpRmz2UqViFr2YgTLfkFsdCMTI7RnAwR0ixsNc6Rgppa P5Z2enjDLgQ0LZ2S9/o3loyX9NCdR8jTlYNSTSKGlAqkdUqimfN2aikSk wCKx+FN9Doiq8TM1mKlG5HNsvdhAAhQ4ljjOwlsIdAoOvJL966iGjQVPZ mCoDjFR0jM/KMl4MoI5mCLXeNh1M6VbxdfE2lanR1ubomCA+YxcnKohAd wc5KOAJYF9qsLzXKElk/M0pDrQqnwYt4cCMpEPC+zpMGdTLcnu7n89Kgk AE3WD3jIHj0AXSAHM83wTAC5euSpzuyZk11ot19zHoPRL6sH99gG45VPF Q==; X-CSE-ConnectionGUID: 0uqLAFbLReupig5wm3hD2A== X-CSE-MsgGUID: A/1duHQNSZOvYVhuf3IXcA== X-IronPort-AV: E=McAfee;i="6700,10204,11178"; a="23663480" X-IronPort-AV: E=Sophos;i="6.10,185,1719903600"; d="scan'208";a="23663480" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2024 02:00:38 -0700 X-CSE-ConnectionGUID: LCPdRrURRiebke7ARE1kMA== X-CSE-MsgGUID: zl+mP+aVTDie3VmGPLk6CQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,185,1719903600"; d="scan'208";a="64202951" Received: from silpixa00401119.ir.intel.com ([10.55.129.167]) by orviesa008.jf.intel.com with ESMTP; 29 Aug 2024 02:00:37 -0700 From: Anatoly Burakov To: dev@dpdk.org Subject: [PATCH v1 11/15] net/ixgbe/base: remove FW API version check Date: Thu, 29 Aug 2024 10:00:16 +0100 Message-ID: <259d90908365695537387c21657875204826f29f.1724921977.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Krzysztof Galazka Only certain variants of drivers rely on FW API version check in shared code. Other drivers implement their own logic due to differences in requirements. DPDK does not require the FW API check. Signed-off-by: Krzysztof Galazka Signed-off-by: Anatoly Burakov --- drivers/net/ixgbe/base/ixgbe_e610.c | 31 +---------------------------- 1 file changed, 1 insertion(+), 30 deletions(-) diff --git a/drivers/net/ixgbe/base/ixgbe_e610.c b/drivers/net/ixgbe/base/ixgbe_e610.c index 6eaf377f4a..7ea495db97 100644 --- a/drivers/net/ixgbe/base/ixgbe_e610.c +++ b/drivers/net/ixgbe/base/ixgbe_e610.c @@ -3541,32 +3541,7 @@ s32 ixgbe_reset_hw_E610(struct ixgbe_hw *hw) reset_hw_out: return status; } -/** - * ixgbe_fw_ver_check - Check the reported FW API version - * @hw: pointer to the hardware structure - * - * Checks if the driver should load on a given FW API version. - * - * Return: 'true' if the driver should attempt to load. 'false' otherwise. - */ -static bool ixgbe_fw_ver_check(struct ixgbe_hw *hw) -{ - if (hw->api_maj_ver > IXGBE_FW_API_VER_MAJOR) { - ERROR_REPORT1(IXGBE_ERROR_UNSUPPORTED, "The driver for the device stopped because the NVM image is newer than expected. You must install the most recent version of the network driver.\n"); - return false; - } else if (hw->api_maj_ver == IXGBE_FW_API_VER_MAJOR) { - if (hw->api_min_ver > - (IXGBE_FW_API_VER_MINOR + IXGBE_FW_API_VER_DIFF_ALLOWED)) { - ERROR_REPORT1(IXGBE_ERROR_CAUTION, "The driver for the device detected a newer version of the NVM image than expected. Please install the most recent version of the network driver.\n"); - } else if ((hw->api_min_ver + IXGBE_FW_API_VER_DIFF_ALLOWED) < - IXGBE_FW_API_VER_MINOR) { - ERROR_REPORT1(IXGBE_ERROR_CAUTION, "The driver for the device detected an older version of the NVM image than expected. Please update the NVM image.\n"); - } - } else { - ERROR_REPORT1(IXGBE_ERROR_CAUTION, "The driver for the device detected an older version of the NVM image than expected. Please update the NVM image.\n"); - } - return true; -} + /** * ixgbe_start_hw_E610 - Prepare hardware for Tx/Rx * @hw: pointer to hardware structure @@ -3584,10 +3559,6 @@ s32 ixgbe_start_hw_E610(struct ixgbe_hw *hw) if (ret_val) goto out; - if (!ixgbe_fw_ver_check(hw)) { - ret_val = IXGBE_ERR_FW_API_VER; - goto out; - } ret_val = ixgbe_start_hw_generic(hw); if (ret_val != IXGBE_SUCCESS) goto out; -- 2.43.5