Re: [dpdk-dev] [PATCH] net/vmxnet3: convert to new rx offload api

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 4/30/2018 11:20 PM, Louis Luo wrote:
> Ethdev RX offloads API has changed since: commit ce17eddefc20
> ("ethdev: introduce Rx queue offloads API")
> 
> This patch adopts the new RX Offload API in vmxnet3 driver.
>
> Signed-off-by: Louis Luo <llouis@vmware.com>

Hi Louis,

Overall patch looks good, only there is 32bits build error because of logging,
more details below.

Can you please send a new version of the patch, keeping Yong's ack.

<...>

> @@ -376,9 +393,25 @@ vmxnet3_dev_configure(struct rte_eth_dev *dev)
>  	const struct rte_memzone *mz;
>  	struct vmxnet3_hw *hw = dev->data->dev_private;
>  	size_t size;
> +	uint64_t rx_offloads = dev->data->dev_conf.rxmode.offloads;
> +	uint64_t tx_offloads = dev->data->dev_conf.txmode.offloads;
>  
>  	PMD_INIT_FUNC_TRACE();
>  
> +	if ((rx_offloads & VMXNET3_RX_OFFLOAD_CAP) != rx_offloads) {
> +		RTE_LOG(ERR, PMD, "Requested RX offloads 0x%lx"
> +			" do not match supported 0x%lx\n",
> +			rx_offloads, (uint64_t)VMXNET3_RX_OFFLOAD_CAP);

%lx usage causing build error with 32bit build [1], please prefer PRIx64.

[1]
 argument of type "uint64_t={__uint64_t={unsigned long long}}" is incompatible
with format "%lx", expecting argument of type "unsigned long"

<...>