From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D1E6142DD0;
	Tue,  4 Jul 2023 11:42:12 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id AB70C40E03;
	Tue,  4 Jul 2023 11:42:12 +0200 (CEST)
Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])
 by mails.dpdk.org (Postfix) with ESMTP id 906EE40042
 for <dev@dpdk.org>; Tue,  4 Jul 2023 11:42:11 +0200 (CEST)
Received: from dggpeml100024.china.huawei.com (unknown [172.30.72.57])
 by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QwHq83PMgzTlMs;
 Tue,  4 Jul 2023 17:41:08 +0800 (CST)
Received: from [10.67.100.224] (10.67.100.224) by
 dggpeml100024.china.huawei.com (7.185.36.115) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.27; Tue, 4 Jul 2023 17:42:09 +0800
Subject: Re: [PATCH v2] app/testpmd: fix invalid queue ID when start port
To: Jie Hai <haijie1@huawei.com>, Aman Singh <aman.deep.singh@intel.com>,
 Yuying Zhang <yuying.zhang@intel.com>, Ferruh Yigit <ferruh.yigit@amd.com>,
 Shiyang He <shiyangx.he@intel.com>
CC: <dev@dpdk.org>, <liudongdong3@huawei.com>, <alialnu@nvidia.com>
References: <20230703110232.28494-1-haijie1@huawei.com>
 <20230704084507.12788-1-haijie1@huawei.com>
From: fengchengwen <fengchengwen@huawei.com>
Message-ID: <25de3edc-596e-648c-3492-cac36162a8eb@huawei.com>
Date: Tue, 4 Jul 2023 17:42:09 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <20230704084507.12788-1-haijie1@huawei.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.100.224]
X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To
 dggpeml100024.china.huawei.com (7.185.36.115)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Acked-by: Chengwen Feng <fengchengwen@huawei.com>

On 2023/7/4 16:45, Jie Hai wrote:
> Function update_queue_state updates queue state of all queues
> of all ports, using the queue num nb_rxq|nb_txq stored locally
> by testpmd. An error on the invalid queue ID occurs if we run
> testpmd with two ports and detach-attach one of them and start
> the other port first. This is because the attached port has not
> been configured and has no queues, which differs from nb_rxq|nb_txq.
> The similar error happens in multi-process senoris if secondary
> process attaches a port and starts it.
> 
> This patch updates queue state of the specified port, which has
> been configured by primary process. As the secondary process
> cannot configure the ports, make sure that the secondary process
> starts the port only after the primary process has done so.
> 
> Fixes: 141a520b35f7 ("app/testpmd: fix primary process not polling all queues")
> Fixes: 5028f207a4fa ("app/testpmd: fix secondary process packet forwarding")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jie Hai <haijie1@huawei.com>
> ---
...