From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0023D433F0; Tue, 28 Nov 2023 11:23:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 980BD40E54; Tue, 28 Nov 2023 11:23:27 +0100 (CET) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2065.outbound.protection.outlook.com [40.107.95.65]) by mails.dpdk.org (Postfix) with ESMTP id C3AD9402C2 for ; Tue, 28 Nov 2023 11:23:25 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jbIlCvDaDjEX+6uiTswCC+3CARtLi8wt5UE0eNWoJAfEz2FDwiQetbTacdqf3L5s9aB18K208yNvzYwB/5Osfak9z3y77cau2zfhYWZhYcupHY+ga+ME0ljTpEDRT+mVopUzgw6XEEto+LxWfJlDdfQ2j+Gx/MMNnIcFP4dnQl5vIcsX9Y6d3p+St5V9bhRB/2ckghFg3U+YOELJ8H72gHZ0fHvTXdcQG99dF+7TaLdrhl7bgXuGvwA1eHATlj2hfKdJbIiRDxBiVDMLaaRvnDp70gLWz7rwhMXDdPmFEh9vFDtH+Mv52f9AiNS/x7QkytRoQZ73xRSBze5R3l17/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NJn7V4vpdkO5dt9eLYfGxkGPDTzL7pJwf5WDJcmkoaI=; b=ljIk26iHrBWTFglA2IBoN0S5PrVU0wLxEsYYoMwY7Hd/TP8S4B6lz7ZBBmIJkts8f6g+smSx0meBmtQHyyr267DZwfGc6kiilwqOp0aDlVwXPoNZWE7GatXnv51iO1Df4UgZng7spqLRSHo6lhsG8NNvd+U9KJbiDNjCqKZEbzZvTpDJ2ueYBSPgpFfd4ns9jabiZ782nThInx1zSQYr4fMsDtd8Jf6dlM+UAYa6MbRW3r6hYTQZbpRGeSPoc4zTmLt83QHi3vsApicJQ/ubX1LdGOJAemiomeK92HXN6AaXsrVuGK9utkbMUPSb1a/2NyZAIuGjWIpGE2JhasU9Xw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NJn7V4vpdkO5dt9eLYfGxkGPDTzL7pJwf5WDJcmkoaI=; b=iFFrtEICY1r4+XcgP/ygMkzx8q4JqP4kNqJQr8crNjauI44GTwpzZeWoGlll0upHp7LKw1qiajuVQGRC9yxmCe/Ao/TXoqcTraAD4dvgtb0l1m3AII98zsPqKAgUIBxR1iNxSvDMq7/tLOd5OwOMsL4gHANrPZIYWTJZVC4283I= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH0PR12MB8174.namprd12.prod.outlook.com (2603:10b6:510:298::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.26; Tue, 28 Nov 2023 10:23:23 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.7025.022; Tue, 28 Nov 2023 10:23:23 +0000 Message-ID: <25e5cde2-dcf5-47b1-a2e9-6104cc380354@amd.com> Date: Tue, 28 Nov 2023 10:23:17 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/6] doc: add RSS hash algorithm feature Content-Language: en-US To: "lihuisong (C)" , dev@dpdk.org Cc: liuyonglong@huawei.com, thomas@monjalon.net, Chengwen Feng , Dongdong Liu , Jie Hai References: <20231123135916.33315-1-lihuisong@huawei.com> <20231125014745.61348-1-lihuisong@huawei.com> <20231125014745.61348-2-lihuisong@huawei.com> <89b73632-8a7a-e54c-2957-04c347027c2e@huawei.com> <8968ac41-bf19-40ac-a057-aad7b46b7ca8@amd.com> <52c309ea-7c83-8b64-e581-5f313227f622@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <52c309ea-7c83-8b64-e581-5f313227f622@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR4P281CA0239.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:e9::16) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH0PR12MB8174:EE_ X-MS-Office365-Filtering-Correlation-Id: fee935b6-befa-4e3d-18f7-08dbeffc0cc0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7o+TAuJh/5vfjDhvRPNNgVQUsFbnp0lUbgUNcC6m5vJnxOH4AQg1o0q8Lm+Pmby0PPaguoA+03f2fx81rlJYxak0V74dM1HDHTbpaj0JxZloOMpA4O8psoRvsw4PHfJKoHU+mg8zRSXqtXKkVMhNQG3QZl5u5tE+MaSfpXTwXAZMbpqAPSCwJ+qNypVDvmWKh2qcbRDOzqkd7y4Q7+IinT8C9l4gFKB89zoYBomdul9imE0kyDw1+J3h9uHG6GdzHlhKKX8A13/YCR0QsHq0pcNo0HqylKl6BDqUXYKVHHKUmBFhK+mKGgoXUx6k1tJw+7U/xcigCxxy1PRfxoAtFKyaZ1zwNs8cK1xKZshmoN8BxKwSfmbTsl/x+wYDNfPz0PrxvdYRQna7o/mmYm3rqMXFqPLOZEchnRMpb2Si1hIcViVoJXS/SmZdSZr5Js4iqMCukpXZAAtwJ8t9zXMDNl2ttsbfiABJ1i5v46ovLV64iAAcMD8JihcP9pmch9YGRqxgmmBeuoQwgCteRvlWm6Uk2QznxX75X8b9ViROOuH4TD0EoZUyDzg+G+6OuJjePbr9DhDIYEV/y3fMEMvc/WtEe8k60z21haVAMaVOioyowDk+cy25TNg7M6YcpIz46IXKUhtrEpaqgoTxaJ8ugA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(376002)(39860400002)(366004)(396003)(346002)(230922051799003)(186009)(451199024)(64100799003)(1800799012)(316002)(54906003)(66476007)(66556008)(66946007)(478600001)(6486002)(6666004)(36756003)(5660300002)(2906002)(41300700001)(8676002)(4326008)(8936002)(44832011)(86362001)(31696002)(83380400001)(38100700002)(2616005)(26005)(31686004)(53546011)(6506007)(6512007)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cWtiTmNtNFdWTklKOW8vRkR1TWlZUVZMM2xkKzBIUGo4WGE4cG1raFI2a0ZU?= =?utf-8?B?bUJ2NC9TemhwcXFxZTNZdGc0RzlpSktPOG5YMFlqeDVkZEJiYjYrOVhwVFpy?= =?utf-8?B?WnM1OUJVY0RXSWVBWkVGclk5ZUxDTlNSTkhYSFQ5S0NhNGNpcUlIQW9QTHh0?= =?utf-8?B?YndpWmpBRDhqMUlLWHFnMzliRnNJMEtDWnZCWnhLWUwxV1Zkc2E0MUZMYmVL?= =?utf-8?B?UTdoWmh0UWlhWWRjdlRrUzR5bC9nTTljK29HQ3pHS2tVRTJ3STcwUEpCVzBi?= =?utf-8?B?d25La1JsVnlld2p1ZGJMNUlJa2xsejNIRWZrSnZ3RUtjRnlWT3pnMmcraWRx?= =?utf-8?B?a3NObm5WOFVhUnd2ZjNKeEdDaTRBcm94a3FTOG1mc2ZRTGk3Y1drM0FzNWRa?= =?utf-8?B?cDc1amZKOWx0UVB1NCtXYUwrRmxta29rNFMzWHFieFdya0N0R20zY3lHZW9n?= =?utf-8?B?UDIyRExVUWFITVczNDhTeVNJR0Y4UkMxSUo2MVFnWXdqRktSZHhRdnpheE1r?= =?utf-8?B?aGp6aER0cG8rdHNha0FWQVpXL3plRUZib3RrZFFyakVjZFR4czUxVjY1REEx?= =?utf-8?B?cDc0bXhKSGxxSGM1amJ2cUNldFZTeVh4bXpJMXYwWkV4L3ZWTmhqQ2FuQm9i?= =?utf-8?B?bFNTQzJtRm8ybmNGbEVtN3ZZSGdOR0pmbnZ1ZVlaMjRmSlIrQU9uR3FXcWM0?= =?utf-8?B?RDV0aDd6TmdwN3pjQlpUMmhINGdKQVNmZWkvbkZsMUswNVVBK0VHTENSSUZn?= =?utf-8?B?ZnFWUGt2RlgrdmNDcDJYb0RNUGw3QSt6SEo4Q0tLV2FUc2QzZTVtN25wQjJF?= =?utf-8?B?anR4Yk9ZRG5KamZVY050Z0l3a0hEOSsyYUZ2K2Ura01JZVZyWWp5K3FDZFZD?= =?utf-8?B?Z1lVYUw2elhSWEh0WGs4UFpMUzJMVjdxSDVuS0FjUGFNREcwVGhtdGdCY1FN?= =?utf-8?B?Mk5yT0E4M1IybkloNFJsNTFhTXBjekJTbnQ1QnV6M0FpQmNUVUx4T0c4ZXFz?= =?utf-8?B?UEhyK1BNUGNRWmMrM0p3cVBYNnVDSlZuOHI1OWVBVm5VdFIyS1dkcG80Vk0z?= =?utf-8?B?eGxmVWJHZGQ3c0RVM050STJkQnM3cThzSjZicCtKOHZndEh2dGZZVGp3SjlL?= =?utf-8?B?UnNJdERBWWlXNC9QN2pzRFJVVXpKOTdZNHU1V0t0U0Q2SnRRVEFwVjRzRWJa?= =?utf-8?B?WUdJMUE2Szk4TS95RnQ1cUtDNTdkNTBjMWRlSjB6cjAyUFRZT0t0Vjl1a0pU?= =?utf-8?B?UzZZcEs3NjBINUVLTCtqZ2xoZHpJQUVoQjRJV3AxUTJ3c3BuVDMxd3ZQMnFV?= =?utf-8?B?SUQ3eHZHOEIyQ2wwYkR4Y0FCd2llc2J4MCtRTjEvV2tJejY1RmJPeGRha1BW?= =?utf-8?B?SDlNZ3NPRm14Q085MzlvRUJFcm1xRmduV0VSUElyMngwaGxTSUZTenpSQjhB?= =?utf-8?B?Z1Y3K1pRT0tRSXNMaE9QTTZLV2NjdjJWTkFrUWQ1aVBGVFYwNjducXhMQVJU?= =?utf-8?B?NjdDemp3SDVKKzBvc0t3R2RCeEoyQ2Z0Vy9KdzR5LzZoWkluWkFUMWhFejM4?= =?utf-8?B?RUZTbVJyeVZBNGFPcDRVWGFueG9XcWpBRW1nWW04OFkyL0xJb05RRkJJajQ1?= =?utf-8?B?RHovRkFrNTFPU2pDWG80S3RTbjJma1Y2c3BiS21WMG5ZdmJQSEtKcmI2R28w?= =?utf-8?B?bEJiUkpvZ05ndXkrK0Q5bm55VjRibWZ4Qk1SOVBBZG1NT0xNYjZUbURhY3Mw?= =?utf-8?B?eFJ3L3NVU3dwTGNvMmR2amQ3dDFKazRHelVyR2ZBMkpuTHhrSkc5b0ozSWpj?= =?utf-8?B?ODFvSk1qUEJ6NWt6d2YxNUp2c01nbHdBbm03K3BmS1grR3VWUC9zb3VHZU9H?= =?utf-8?B?YWJ0ZzJmZkxrR1kydlhPbzZnemJCSDhMdTU0WnhqdmJLZnBVOUF6ZHJ0Uno2?= =?utf-8?B?M0NieDBBU0MyWDRYNU1CN1FabnFJMStkeVNXVFNWelZpSXc1dEMzY1B4OHBr?= =?utf-8?B?cXZmdXpJY2FKbUEwZHNhbTNVN3FEMmRyc1lkMU52ZTh0UUd2aWFlUENweVMx?= =?utf-8?B?bXVVQkFRQXpESlR4dzlKbngwRzRiNnlwWkphNEJoSDhmTHdQNUdrSHN5TG5G?= =?utf-8?Q?3VGQDDUxoGpPtV7sIbxJP/4zD?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: fee935b6-befa-4e3d-18f7-08dbeffc0cc0 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 10:23:23.0847 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HquO4ZBX67pdEaCm9/8Hu4HPBLSN82ZrfmIog7zMIaWwwzFzC4uU5r1deriwWE8K X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB8174 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/28/2023 1:34 AM, lihuisong (C) wrote: > > 在 2023/11/28 0:35, Ferruh Yigit 写道: >> On 11/27/2023 3:43 PM, Ferruh Yigit wrote: >>> On 11/27/2023 1:12 PM, lihuisong (C) wrote: >>>> 在 2023/11/27 20:19, Ferruh Yigit 写道: >>>>> On 11/25/2023 1:47 AM, Huisong Li wrote: >>>>>> Add hash algorithm feature introduced by 23.11 and fix some RSS >>>>>> features >>>>>> description. >>>>>> >>>>>> Fixes: 34ff088cc241 ("ethdev: set and query RSS hash algorithm") >>>>>> >>>>>> Signed-off-by: Huisong Li >>>>>> Acked-by: Chengwen Feng >>>>>> --- >>>>>>    doc/guides/nics/features.rst | 26 ++++++++++++++++++++++---- >>>>>>    1 file changed, 22 insertions(+), 4 deletions(-) >>>>>> >>>>>> diff --git a/doc/guides/nics/features.rst >>>>>> b/doc/guides/nics/features.rst >>>>>> index 1a1dc16c1e..0d38c5c525 100644 >>>>>> --- a/doc/guides/nics/features.rst >>>>>> +++ b/doc/guides/nics/features.rst >>>>>> @@ -277,10 +277,12 @@ RSS hash >>>>>>    Supports RSS hashing on RX. >>>>>>      * **[uses]     user config**: ``dev_conf.rxmode.mq_mode`` = >>>>>> ``RTE_ETH_MQ_RX_RSS_FLAG``. >>>>>> -* **[uses]     user config**: ``dev_conf.rx_adv_conf.rss_conf``. >>>>>> +* **[uses]     user config**: ``rss_conf.rss_hf``. >>>>>> >>>>> Feature title is "RSS hash", it can be two things, >>>>> 1. "Receive Side Scaling" support >>>>> 2. Provide RSS hash to application >>>>> >>>>> When this document first prepared RSS hash value was always >>>>> provided to >>>>> the application when RSS enabled. >>>>> So intention with this feature was "Receive Side Scaling" support, >>>>> hence >>>>> 'RTE_ETH_MQ_RX_RSS_FLAG' added. >>>>> >>>>> Later providing RSS has to the application separated as optimization, >>>>> 'RTE_ETH_RX_OFFLOAD_RSS_HASH' & 'RTE_MBUF_F_RX_RSS_HASH' added for >>>>> this >>>>> support. >>>> What should I do for above two comments？ >>>> To tell application how to use it? >>>> >>> Just tried to give some context. >>> >>> >>>>> As the intention of this feature is "Receive Side Scaling" support, we >>>>> shouldn't reduce configuration struct to 'rss_conf.rss_hf'. >>>>> >>>>> Instead perhaps can expand to: >>>>> 'rte_eth_conf.rx_adv_conf.rss_conf', 'rte_eth_rss_conf' >>>>   I just pick their common part.😁 >>>> >>>> ok, will fix it. >>>> >>>>> >>>>>>    * **[uses]     rte_eth_rxconf,rte_eth_rxmode**: >>>>>> ``offloads:RTE_ETH_RX_OFFLOAD_RSS_HASH``. >>>>>>    * **[provides] rte_eth_dev_info**: ``flow_type_rss_offloads``. >>>>>>    * **[provides] mbuf**: ``mbuf.ol_flags:RTE_MBUF_F_RX_RSS_HASH``, >>>>>> ``mbuf.rss``. >>>>>> +* **[related]  API**: ``rte_eth_dev_configure``, >>>>>> ``rte_eth_dev_rss_hash_update`` >>>>>> +  ``rte_eth_dev_rss_hash_conf_get()``. >>>>>>    >>>>> ack >>>>> >>>>>>      .. _nic_features_inner_rss: >>>>>> @@ -288,7 +290,7 @@ Supports RSS hashing on RX. >>>>>>    Inner RSS >>>>>>    --------- >>>>>>    -Supports RX RSS hashing on Inner headers. >>>>>> +Supports RX RSS hashing on Inner headers by rte_flow API. >>>>>>    >>>>> This should be clarified with details below, not sure if it >>>>> required to >>>>> limit description to rte_flow. >>>> But this block like rte_flow_action_rss is from rte_flow. >>>> And ethdev ops doesn't support inner RSS. >>>> So I think it is ok. >>>> >>> Yes it is supported by rte_flow, and '[uses]' information should already >>> clarify it. >>> >>> >>>>> >>>>> And I guess similar confusion exist with the providing hash to user. >>>>> Need to check if rte_flow implementation puts hash to mbuf along with >>>>> doing the RSS, or if it checks 'RTE_ETH_RX_OFFLOAD_RSS_HASH' offload, >>>>> and update below items accordingly. >>>> Do we need to tell user how to use it here? >>>> I feel this document is a little simple and main to list interface for >>>> user. >>>> In addition, it is better that the more detail about RSS should be >>>> presented  in rte_flow features. >>>> >>> No, I am not suggesting to add more detail. >>> >>> My concern is 'RTE_ETH_RX_OFFLOAD_RSS_HASH' information may not be >>> correct, ethdev APIs checks offload flags, but does rte_flow >>> implementation check it? >>> >>> My suggestion is double check that piece of information and fix it if >>> required. >>> >> Thinking twice, ethdev API or rte_flow or different ways to configure >> RSS, but datapath that puts hash value to mbuf is same. >> So same 'RTE_ETH_RX_OFFLOAD_RSS_HASH' check is used for both method, and >> it is OK to have it documented. > There was a check for  RTE_ETH_RX_OFFLOAD_RSS_HASH in > rte_eth_dev_configure(). > This offload flag depends on the RTE_ETH_MQ_RX_RSS_FLAG mode. > As far as I know, ethdev ops allows to enable RSS hash only when > RTE_ETH_MQ_RX_RSS_FLAG mode is set. > But rte flow API enable RSS hash doesn't depend on this MQ mode. > So I guess that the mbuf.ol_flags:RTE_MBUF_F_RX_RSS_HASH and mbuf.rss > also be set to report application when create RSS hash flow, even if > application don't set RTE_ETH_MQ_RX_RSS_FLAG mode by ethdev ops. > Even rte_flow is used for RSS, application may want to control exposing hash value via 'RTE_ETH_RX_OFFLOAD_RSS_HASH' flag, so lets keep the documentation as it is. But in implementation it is possible that some drivers may not be using the offload flag, as you explained above, this confused me but we still should document what is expected from driver. >> >> >> >>>>> >>>>>>    * **[uses]    rte_flow_action_rss**: ``level``. >>>>>>    * **[uses]    rte_eth_rxconf,rte_eth_rxmode**: >>>>>> ``offloads:RTE_ETH_RX_OFFLOAD_RSS_HASH``. >>>>>> @@ -303,9 +305,25 @@ RSS key update >>>>>>    Supports configuration of Receive Side Scaling (RSS) hash >>>>>> computation. Updating >>>>>>    Receive Side Scaling (RSS) hash key. >>>>>>    -* **[implements] eth_dev_ops**: ``rss_hash_update``, >>>>>> ``rss_hash_conf_get``. >>>>>> +* **[implements] eth_dev_ops**: ``dev_configure``, >>>>>> ``rss_hash_update``, ``rss_hash_conf_get``. >>>>>> +* **[uses]     user config**: ``rss_conf.rss_key``, >>>>>> ``rss_conf.rss_key_len`` >>>>>>    * **[provides]   rte_eth_dev_info**: ``hash_key_size``. >>>>>> -* **[related]    API**: ``rte_eth_dev_rss_hash_update()``, >>>>>> +* **[related]    API**: ``rte_eth_dev_configure``, >>>>>> ``rte_eth_dev_rss_hash_update()``, >>>>>> +  ``rte_eth_dev_rss_hash_conf_get()``. >>>>>> + >>>>> ack >>>>> >>>>> There is an inconsistency in the documentation but I think it is >>>>> good to >>>>> use '()' when documenting API, like: 'rte_eth_dev_configure()' >>>> +1 will fix it. >>>>> >>>>>> + >>>>>> +.. _nic_features_rss_hash_algo_update: >>>>>> + >>>>>> +RSS hash algorithm update >>>>>> +------------------------- >>>>>> + >>>>>> +Supports configuration of Receive Side Scaling (RSS) hash algorithm. >>>>>> Updating >>>>>> +RSS hash algorithm. >>>>>> + >>>>>> +* **[implements] eth_dev_ops**: ``dev_configure``, >>>>>> ``rss_hash_update``, ``rss_hash_conf_get``. >>>>>> +* **[uses]     user config**: ``rss_conf.algorithm`` >>>>>> +* **[provides]   rte_eth_dev_info**: ``rss_algo_capa``. >>>>>> +* **[related]    API**: ``rte_eth_dev_configure``, >>>>>> ``rte_eth_dev_rss_hash_update()``, >>>>>>      ``rte_eth_dev_rss_hash_conf_get()``. >>>>>>      >>>>> This document describes features listed in the 'default.ini', so we >>>>> shouldn't have above. >>>>> >>>>> And I don't think RSS hash algorithm update is a big enough feature to >>>>> list in the feature list, perhaps it can be embedded in the RSS >>>>> support >>>>> block, what do you think? >>>> Yes it is not a bit feature. >>>> so put it to RSS hash, right? >>>> >>> Yes please. >>> >> .