From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <konstantin.ananyev@intel.com>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id 07D6558EC
 for <dev@dpdk.org>; Wed,  3 Oct 2018 10:53:38 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 03 Oct 2018 01:53:37 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.54,335,1534834800"; d="scan'208";a="91744138"
Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25])
 by fmsmga002.fm.intel.com with ESMTP; 03 Oct 2018 01:53:24 -0700
Received: from irsmsx106.ger.corp.intel.com ([169.254.8.45]) by
 irsmsx110.ger.corp.intel.com ([169.254.15.182]) with mapi id 14.03.0319.002;
 Wed, 3 Oct 2018 09:53:23 +0100
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, "Lu, Wenzhuo"
 <wenzhuo.lu@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com>, "Iremonger,
 Bernard" <bernard.iremonger@intel.com>, "Mcnamara, John"
 <john.mcnamara@intel.com>, "Kovacevic, Marko" <marko.kovacevic@intel.com>,
 Thomas Monjalon <thomas@monjalon.net>, "Yigit, Ferruh"
 <ferruh.yigit@intel.com>, Andrew Rybchenko <arybchenko@solarflare.com>,
 Olivier Matz <olivier.matz@6wind.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "shahafs@mellanox.com"
 <shahafs@mellanox.com>
Thread-Topic: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP
 checksum	definition
Thread-Index: AQHUWoZ16N+S2p7Xg0+YkXutkRYbN6UNN04g
Date: Wed, 3 Oct 2018 08:53:22 +0000
Message-ID: <2601191342CEEE43887BDE71AB9772580102FE1479@IRSMSX106.ger.corp.intel.com>
References: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com>
 <20181002192451.19119-1-jerin.jacob@caviumnetworks.com>
In-Reply-To: <20181002192451.19119-1-jerin.jacob@caviumnetworks.com>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWMyNGMyYWQtZDA5My00Y2E5LWIzOGMtNzcwMmE4ZWM4YThlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNDF6M2szdjFoQklYcUV0ZEh5Z0lkdGd6SERwMExuQ2NGN3E0Z1JuNVh1aWpNSm5jVExRTEgzaU5PbGF6M2dvUiJ9
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.400.15
dlp-reaction: no-action
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP
 checksum	definition
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Oct 2018 08:53:39 -0000

Hi Jerin,

>=20
> Introduced DEV_RX_OFFLOAD_OUTER_UDP_CKSUM Rx offload flag and
> PKT_RX_EL4_CKSUM_BAD mbuf ol_flags to detect outer UDP checksum
> failure.
>=20
> - To use hardware Rx outer UDP checksum offload, the user needs to
> configure DEV_RX_OFFLOAD_OUTER_UDP_CKSUM offload flags in slowpath.
>=20
> - Driver updates the PKT_RX_EL4_CKSUM_BAD mbuf ol_flag on checksum failur=
e
> similar to the outer L3 PKT_RX_EIP_CKSUM_BAD flag.
>=20
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Looks ok to me in general.
Just wonder is there any PMD that supports all these new features?
Konstantin=20