From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id B8FAA201 for ; Sat, 6 Oct 2018 14:18:05 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Oct 2018 05:18:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,348,1534834800"; d="scan'208";a="96659653" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by fmsmga001.fm.intel.com with ESMTP; 06 Oct 2018 05:18:02 -0700 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.45]) by IRSMSX152.ger.corp.intel.com ([169.254.6.110]) with mapi id 14.03.0319.002; Sat, 6 Oct 2018 13:18:01 +0100 From: "Ananyev, Konstantin" To: Jerin Jacob , Thomas Monjalon CC: "Yigit, Ferruh" , Andrew Rybchenko , "Lu, Wenzhuo" , "Wu, Jingjing" , "Iremonger, Bernard" , "Mcnamara, John" , "Kovacevic, Marko" , Olivier Matz , "dev@dpdk.org" , "shahafs@mellanox.com" , "didier.pallard@6wind.com" Thread-Topic: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition Thread-Index: AQHUWuu7VJ6hY4BF4km45CUClA1MHqUNFsiAgACbQICAAA1WgIAAA82AgAAZ/oCAAKsSAIACfkgAgAAs8ACAAJ95AIAAU8jw Date: Sat, 6 Oct 2018 12:18:00 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772580102FE2EE9@IRSMSX106.ger.corp.intel.com> References: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com> <20181004055930.GA4406@jerin> <26087815.IDbtF1NTBH@xps> <20181006081537.GB21149@jerin> In-Reply-To: <20181006081537.GB21149@jerin> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDdhYTVkY2MtZDE5MC00YzNkLWIyMjYtNDg1NWQ3OWYwYjFmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVEVtcElIbUEyMGhhc2NscW9JZUMyNzJFdEVVXC9sNHE2dEhObzc4TWNYWVJoXC9tU1BtRDcxNVFJYnAxaldqREw0In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Oct 2018 12:18:06 -0000 > -----Original Message----- > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Saturday, October 6, 2018 9:16 AM > To: Thomas Monjalon > Cc: Yigit, Ferruh ; Andrew Rybchenko ; Lu, Wenzhuo ; Wu, > Jingjing ; Iremonger, Bernard ; Mcnamara, John ; > Kovacevic, Marko ; Olivier Matz ; dev@dpdk.org; shahafs@mellanox.com; > Ananyev, Konstantin ; didier.pallard@6wind.= com > Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP c= hecksum definition >=20 > -----Original Message----- > > Date: Sat, 06 Oct 2018 00:44:52 +0200 > > From: Thomas Monjalon > > To: Ferruh Yigit , Jerin Jacob > > , Andrew Rybchenko > > > > Cc: Wenzhuo Lu , Jingjing Wu , > > Bernard Iremonger , John McNamara > > , Marko Kovacevic = , > > Olivier Matz , dev@dpdk.org, shahafs@mellanox.= com, > > "Ananyev, Konstantin" , > > didier.pallard@6wind.com > > Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP > > checksum definition > > > > > > 05/10/2018 22:04, Ferruh Yigit: > > > On 10/4/2018 6:59 AM, Jerin Jacob wrote: > > > > From: Andrew Rybchenko > > > >> On 03.10.2018 21:14, Jerin Jacob wrote: > > > >>> From: Andrew Rybchenko > > > >>>> On 03.10.2018 20:12, Jerin Jacob wrote: > > > >>>>> From: Jerin Jacob > > > >>>>>> From: Andrew Rybchenko > > > >>>>>>> 3. PKT_RX_L4_CKSUM_MASK description says nothing if it is inn= er or outer. > > > >>>>>>> May be it is not directly related to changeset, but I th= ink it would be really > > > >>>>>>> useful to clarify it. > > > >>>>>> I will update the comment. > > > >>>>> Hi Andrew, > > > >>>>> > > > > However, we should re-visit the flag PKT_RX_EIP_CKSUM_BAD. >=20 > Do we need to block this patch due to the exiting PKT_RX_EIP_CKSUM_BAD > definition? >=20 > I already added the author of the PKT_RX_EIP_CKSUM_BAD flag and ethdev an= d mbuf > maintainers in this list. So what else I need make forward progress > on this patch? >=20 > I think, the definition of PKT_RX_EIP_CKSUM_BAD based on HW capability. I= t > is safe to assume that ALL HW can support CKSUM BAD if the feature is > available and hence it is more portable. Yes, as I remember PKT_RX_EIP_CKSUM_BAD is based on DEV_RX_OFFLOAD_OUTER_IP= V4_CKSUM. Konstantin >=20 > > > >