From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id C7C351D7 for ; Mon, 12 Nov 2018 23:44:44 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Nov 2018 14:44:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,497,1534834800"; d="scan'208";a="85979906" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga008.fm.intel.com with ESMTP; 12 Nov 2018 14:44:42 -0800 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.87]) by IRSMSX151.ger.corp.intel.com ([169.254.4.122]) with mapi id 14.03.0415.000; Mon, 12 Nov 2018 22:44:42 +0000 From: "Ananyev, Konstantin" To: "Lipiec, Herakliusz" , "dev@dpdk.org" Thread-Topic: [PATCH] example/ipv4_multicast: fix app hanging when using clone Thread-Index: AQHUesjXwRa/wc3zoEOCvWNGqQmfc6VMvKcQ Date: Mon, 12 Nov 2018 22:44:41 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258010CE49844@IRSMSX106.ger.corp.intel.com> References: <20181112204650.7175-1-herakliusz.lipiec@intel.com> In-Reply-To: <20181112204650.7175-1-herakliusz.lipiec@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGYxZjdkYTMtZWQ0ZC00NzgxLWJhNTYtN2RhNGM2YWMwMzRiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSmdZRDNNeWdJZ3BLbDdNdzZsOGRRMWxzYlBMQkt4SXNJbU85WVJYeVwvMU9OVjd0OGw0QUpGS3FrcGpxWXRRMVgifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] example/ipv4_multicast: fix app hanging when using clone X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Nov 2018 22:44:45 -0000 > -----Original Message----- > From: Lipiec, Herakliusz > Sent: Monday, November 12, 2018 8:47 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Lipiec, Heraklius= z > Subject: [PATCH] example/ipv4_multicast: fix app hanging when using clone >=20 > This example was dropping packets when using clone (ip 224.0.0.103). > The problem was that mbufs were not freed. This was caused by coping > ol_flags from cloned mbuf to header mbufs. >=20 > Signed-off-by: Herakliusz Lipiec > --- > examples/ipv4_multicast/main.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/examples/ipv4_multicast/main.c b/examples/ipv4_multicast/mai= n.c > index 4073a4907..428ca4694 100644 > --- a/examples/ipv4_multicast/main.c > +++ b/examples/ipv4_multicast/main.c > @@ -266,8 +266,6 @@ mcast_out_pkt(struct rte_mbuf *pkt, int use_clone) > hdr->tx_offload =3D pkt->tx_offload; > hdr->hash =3D pkt->hash; >=20 > - hdr->ol_flags =3D pkt->ol_flags; > - > __rte_mbuf_sanity_check(hdr, 1); > return hdr; > } > -- Acked-by: Konstantin Ananyev > 2.17.1