From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id E1BA92D13 for ; Tue, 13 Nov 2018 12:49:56 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Nov 2018 03:49:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,499,1534834800"; d="scan'208";a="90742609" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga006.jf.intel.com with ESMTP; 13 Nov 2018 03:49:54 -0800 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.87]) by irsmsx105.ger.corp.intel.com ([169.254.7.144]) with mapi id 14.03.0415.000; Tue, 13 Nov 2018 11:49:52 +0000 From: "Ananyev, Konstantin" To: Akhil Goyal , "dev@dpdk.org" CC: "thomas@monjalon.net" , "jerin.jacob@caviumnetworks.com" , "anoob.joseph@caviumnetworks.com" , "Nicolau, Radu" , "Doherty, Declan" , Hemant Agrawal Thread-Topic: [PATCH] security: remove experimental tag Thread-Index: AQHUe0P7pW07ouSgyEm8Cur4KLVhCKVNlbSQ Date: Tue, 13 Nov 2018 11:49:51 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258010CE49CF8@IRSMSX106.ger.corp.intel.com> References: <20181113112255.20050-1-akhil.goyal@nxp.com> In-Reply-To: <20181113112255.20050-1-akhil.goyal@nxp.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGM2ZmY0NGYtMDI1OC00ZjUxLWJmZjYtYzk2OWNjNzFiZjdiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTjNLVjlzbmZ4Z2FpRXduVDNQdHRuazhmbXQyODkweElDUDBwM2YrdFUyd0dkU2ZmMllcL2hGT201QXJKN2owRzUifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] security: remove experimental tag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Nov 2018 11:49:57 -0000 Hi Akhil, > -----Original Message----- > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > Sent: Tuesday, November 13, 2018 11:28 AM > To: dev@dpdk.org > Cc: thomas@monjalon.net; Ananyev, Konstantin ; jerin.jacob@caviumnetworks.com; > anoob.joseph@caviumnetworks.com; Nicolau, Radu ; = Doherty, Declan ; Hemant > Agrawal ; Akhil Goyal > Subject: [PATCH] security: remove experimental tag >=20 > rte_security has been experimental since DPDK 17.11 release. > Now the library has matured and expermental tag is removed in > this patch. I agree that it is present for a while in dpdk.org, but as I can see we still have unimplemented API here. Which makes me doubt that it is ok to remove experimental tag from it. Konstantin >=20 > Signed-off-by: Akhil Goyal > --- > MAINTAINERS | 2 +- > lib/librte_security/Makefile | 1 - > lib/librte_security/meson.build | 1 - > lib/librte_security/rte_security.c | 18 +++++++++--------- > lib/librte_security/rte_security.h | 27 +++++++++++++---------= ----- > lib/librte_security/rte_security_driver.h | 1 - > lib/librte_security/rte_security_version.map | 2 +- > 7 files changed, 24 insertions(+), 28 deletions(-) >=20 > diff --git a/MAINTAINERS b/MAINTAINERS > index 19353ac..bdd6747 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -347,7 +347,7 @@ F: lib/librte_cryptodev/ > F: test/test/test_cryptodev* > F: examples/l2fwd-crypto/ >=20 > -Security API - EXPERIMENTAL > +Security API > M: Akhil Goyal > M: Declan Doherty > T: git://dpdk.org/next/dpdk-next-crypto > diff --git a/lib/librte_security/Makefile b/lib/librte_security/Makefile > index 8daebea..bd92343 100644 > --- a/lib/librte_security/Makefile > +++ b/lib/librte_security/Makefile > @@ -10,7 +10,6 @@ LIB =3D librte_security.a > LIBABIVER :=3D 1 >=20 > # build flags > -CFLAGS +=3D -DALLOW_EXPERIMENTAL_API > CFLAGS +=3D -O3 > CFLAGS +=3D $(WERROR_FLAGS) > LDLIBS +=3D -lrte_eal -lrte_mempool > diff --git a/lib/librte_security/meson.build b/lib/librte_security/meson.= build > index 4c85894..532953f 100644 > --- a/lib/librte_security/meson.build > +++ b/lib/librte_security/meson.build > @@ -1,7 +1,6 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2017 Intel Corporation >=20 > -allow_experimental_apis =3D true > sources =3D files('rte_security.c') > headers =3D files('rte_security.h', 'rte_security_driver.h') > deps +=3D ['mempool', 'cryptodev'] > diff --git a/lib/librte_security/rte_security.c b/lib/librte_security/rte= _security.c > index c6355de..bc81ce1 100644 > --- a/lib/librte_security/rte_security.c > +++ b/lib/librte_security/rte_security.c > @@ -10,7 +10,7 @@ > #include "rte_security_driver.h" >=20 > struct rte_security_session * > -__rte_experimental rte_security_session_create(struct rte_security_ctx *= instance, > +rte_security_session_create(struct rte_security_ctx *instance, > struct rte_security_session_conf *conf, > struct rte_mempool *mp) > { > @@ -33,7 +33,7 @@ __rte_experimental rte_security_session_create(struct r= te_security_ctx *instance > return sess; > } >=20 > -int __rte_experimental > +int > rte_security_session_update(struct rte_security_ctx *instance, > struct rte_security_session *sess, > struct rte_security_session_conf *conf) > @@ -42,14 +42,14 @@ rte_security_session_update(struct rte_security_ctx *= instance, > return instance->ops->session_update(instance->device, sess, conf); > } >=20 > -unsigned int __rte_experimental > +unsigned int > rte_security_session_get_size(struct rte_security_ctx *instance) > { > RTE_FUNC_PTR_OR_ERR_RET(*instance->ops->session_get_size, 0); > return instance->ops->session_get_size(instance->device); > } >=20 > -int __rte_experimental > +int > rte_security_session_stats_get(struct rte_security_ctx *instance, > struct rte_security_session *sess, > struct rte_security_stats *stats) > @@ -58,7 +58,7 @@ rte_security_session_stats_get(struct rte_security_ctx = *instance, > return instance->ops->session_stats_get(instance->device, sess, stats); > } >=20 > -int __rte_experimental > +int > rte_security_session_destroy(struct rte_security_ctx *instance, > struct rte_security_session *sess) > { > @@ -76,7 +76,7 @@ rte_security_session_destroy(struct rte_security_ctx *i= nstance, > return ret; > } >=20 > -int __rte_experimental > +int > rte_security_set_pkt_metadata(struct rte_security_ctx *instance, > struct rte_security_session *sess, > struct rte_mbuf *m, void *params) > @@ -86,7 +86,7 @@ rte_security_set_pkt_metadata(struct rte_security_ctx *= instance, > sess, m, params); > } >=20 > -void * __rte_experimental > +void * > rte_security_get_userdata(struct rte_security_ctx *instance, uint64_t md= ) > { > void *userdata =3D NULL; > @@ -98,14 +98,14 @@ rte_security_get_userdata(struct rte_security_ctx *in= stance, uint64_t md) > return userdata; > } >=20 > -const struct rte_security_capability * __rte_experimental > +const struct rte_security_capability * > rte_security_capabilities_get(struct rte_security_ctx *instance) > { > RTE_FUNC_PTR_OR_ERR_RET(*instance->ops->capabilities_get, NULL); > return instance->ops->capabilities_get(instance->device); > } >=20 > -const struct rte_security_capability * __rte_experimental > +const struct rte_security_capability * > rte_security_capability_get(struct rte_security_ctx *instance, > struct rte_security_capability_idx *idx) > { > diff --git a/lib/librte_security/rte_security.h b/lib/librte_security/rte= _security.h > index 1431b4d..e07b132 100644 > --- a/lib/librte_security/rte_security.h > +++ b/lib/librte_security/rte_security.h > @@ -8,7 +8,6 @@ >=20 > /** > * @file rte_security.h > - * @b EXPERIMENTAL: this API may change without prior notice > * > * RTE Security Common Definitions > * > @@ -330,7 +329,7 @@ struct rte_security_session { > * - On success, pointer to session > * - On failure, NULL > */ > -struct rte_security_session * __rte_experimental > +struct rte_security_session * > rte_security_session_create(struct rte_security_ctx *instance, > struct rte_security_session_conf *conf, > struct rte_mempool *mp); > @@ -345,7 +344,7 @@ rte_security_session_create(struct rte_security_ctx *= instance, > * - On success returns 0 > * - On failure return errno > */ > -int __rte_experimental > +int > rte_security_session_update(struct rte_security_ctx *instance, > struct rte_security_session *sess, > struct rte_security_session_conf *conf); > @@ -359,7 +358,7 @@ rte_security_session_update(struct rte_security_ctx *= instance, > * - Size of the private data, if successful > * - 0 if device is invalid or does not support the operation. > */ > -unsigned int __rte_experimental > +unsigned int > rte_security_session_get_size(struct rte_security_ctx *instance); >=20 > /** > @@ -374,7 +373,7 @@ rte_security_session_get_size(struct rte_security_ctx= *instance); > * - -EINVAL if session is NULL. > * - -EBUSY if not all device private data has been freed. > */ > -int __rte_experimental > +int > rte_security_session_destroy(struct rte_security_ctx *instance, > struct rte_security_session *sess); >=20 > @@ -391,7 +390,7 @@ rte_security_session_destroy(struct rte_security_ctx = *instance, > * - On success, zero. > * - On failure, a negative value. > */ > -int __rte_experimental > +int > rte_security_set_pkt_metadata(struct rte_security_ctx *instance, > struct rte_security_session *sess, > struct rte_mbuf *mb, void *params); > @@ -413,7 +412,7 @@ rte_security_set_pkt_metadata(struct rte_security_ctx= *instance, > * - On success, userdata > * - On failure, NULL > */ > -void * __rte_experimental > +void * > rte_security_get_userdata(struct rte_security_ctx *instance, uint64_t md= ); >=20 > /** > @@ -422,7 +421,7 @@ rte_security_get_userdata(struct rte_security_ctx *in= stance, uint64_t md); > * @param sym_op crypto operation > * @param sess security session > */ > -static inline int __rte_experimental > +static inline int > __rte_security_attach_session(struct rte_crypto_sym_op *sym_op, > struct rte_security_session *sess) > { > @@ -431,13 +430,13 @@ __rte_security_attach_session(struct rte_crypto_sym= _op *sym_op, > return 0; > } >=20 > -static inline void * __rte_experimental > +static inline void * > get_sec_session_private_data(const struct rte_security_session *sess) > { > return sess->sess_private_data; > } >=20 > -static inline void __rte_experimental > +static inline void > set_sec_session_private_data(struct rte_security_session *sess, > void *private_data) > { > @@ -453,7 +452,7 @@ set_sec_session_private_data(struct rte_security_sess= ion *sess, > * @param op crypto operation > * @param sess security session > */ > -static inline int __rte_experimental > +static inline int > rte_security_attach_session(struct rte_crypto_op *op, > struct rte_security_session *sess) > { > @@ -500,7 +499,7 @@ struct rte_security_stats { > * - On success return 0 > * - On failure errno > */ > -int __rte_experimental > +int > rte_security_session_stats_get(struct rte_security_ctx *instance, > struct rte_security_session *sess, > struct rte_security_stats *stats); > @@ -608,7 +607,7 @@ struct rte_security_capability_idx { > * - Returns array of security capabilities. > * - Return NULL if no capabilities available. > */ > -const struct rte_security_capability * __rte_experimental > +const struct rte_security_capability * > rte_security_capabilities_get(struct rte_security_ctx *instance); >=20 > /** > @@ -622,7 +621,7 @@ rte_security_capabilities_get(struct rte_security_ctx= *instance); > * index criteria. > * - Return NULL if the capability not matched on security instance. > */ > -const struct rte_security_capability * __rte_experimental > +const struct rte_security_capability * > rte_security_capability_get(struct rte_security_ctx *instance, > struct rte_security_capability_idx *idx); >=20 > diff --git a/lib/librte_security/rte_security_driver.h b/lib/librte_secur= ity/rte_security_driver.h > index 42f42ff..1b561f8 100644 > --- a/lib/librte_security/rte_security_driver.h > +++ b/lib/librte_security/rte_security_driver.h > @@ -8,7 +8,6 @@ >=20 > /** > * @file rte_security_driver.h > - * @b EXPERIMENTAL: this API may change without prior notice > * > * RTE Security Common Definitions > * > diff --git a/lib/librte_security/rte_security_version.map b/lib/librte_se= curity/rte_security_version.map > index 5a1c8ae..a77ca4b 100644 > --- a/lib/librte_security/rte_security_version.map > +++ b/lib/librte_security/rte_security_version.map > @@ -1,4 +1,4 @@ > -EXPERIMENTAL { > +DPDK_18.11 { > global: >=20 > rte_security_attach_session; > -- > 2.7.4