From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 971F71B46A; Wed, 9 Jan 2019 19:40:14 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2019 10:40:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,458,1539673200"; d="scan'208";a="116819423" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga003.jf.intel.com with ESMTP; 09 Jan 2019 10:40:08 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.116]) by IRSMSX151.ger.corp.intel.com ([169.254.4.172]) with mapi id 14.03.0415.000; Wed, 9 Jan 2019 18:40:07 +0000 From: "Ananyev, Konstantin" To: Stephen Hemminger , "Hu, Jiayu" CC: "dev@dpdk.org" , "mb@smartsharesystems.com" , "thomas@monjalon.net" , "Varghese, Vipin" , "stable@dpdk.org" Thread-Topic: [PATCH v5] doc: add GRO API limitations in prog_guide Thread-Index: AQHUp/QnVNyts019JkG1ePNMPmal+aWnQAUAgAAD25A= Date: Wed, 9 Jan 2019 18:40:06 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258010D901595@irsmsx105.ger.corp.intel.com> References: <1547002811-6989-1-git-send-email-jiayu.hu@intel.com> <1547021995-14231-1-git-send-email-jiayu.hu@intel.com> <20190109102014.41c685b5@hermes.lan> In-Reply-To: <20190109102014.41c685b5@hermes.lan> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzBlNjVjOWEtNjM0Mi00Njk2LWJjOWEtOGExMWI0ZjQ0OWE5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiS04zdGpGXC9xK3hPdHNaYWwwa2tMSjJQXC9ka253U2dTbkNUUXVnZkI5Mk4rbTMwKzlaVGE2UnIwUU5aclFueHplIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5] doc: add GRO API limitations in prog_guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2019 18:40:15 -0000 > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Wednesday, January 9, 2019 6:20 PM > To: Hu, Jiayu > Cc: dev@dpdk.org; Ananyev, Konstantin ; mb@= smartsharesystems.com; thomas@monjalon.net; > Varghese, Vipin ; stable@dpdk.org > Subject: Re: [PATCH v5] doc: add GRO API limitations in prog_guide >=20 > O be merged. > > + > > +GRO Library Limitations > > +----------------------- > > + > > +- GRO library uses the values of MBUF->l2_len/l3_len/l4_len/ > > + outer_l2_len/outer_l3_len to get protocol headers for the > > + input packet, rather than parsing the packet header. Therefore, > > + before call GRO APIs to merge packets, user applications > > + must set MBUF->l2_len/l3_len/l4_len/outer_l2_len/outer_l3_len > > + to the same values as the protocol headers of the packet. > > + >=20 > Since these length values are critical to other functionality > why not require all poll mode drivers to set them. Most of current HW doesn't provide that functionality, so RX function would need to parse (touch) packet data. >>From other side not every rx_burst() consumer does use GRO library. >=20 > Many poll mode drivers call rte_net_get_ptype() on the received > mbuf and it already handles setting this. >=20 > One could argue that GRO should just log and die if it > gets malformed data.