From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 9F894271; Wed, 16 Jan 2019 10:50:10 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jan 2019 01:50:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,485,1539673200"; d="scan'208";a="138704154" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga001.fm.intel.com with ESMTP; 16 Jan 2019 01:50:08 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.116]) by IRSMSX106.ger.corp.intel.com ([169.254.8.161]) with mapi id 14.03.0415.000; Wed, 16 Jan 2019 09:50:08 +0000 From: "Ananyev, Konstantin" To: "Hu, Jiayu" , "dev@dpdk.org" CC: "thomas@monjalon.net" , "stable@dpdk.org" Thread-Topic: [PATCH v6] doc: add GRO limitations in prog_guide Thread-Index: AQHUrUEeYrgfCZQ3Q0mhHlO2mSA+R6WxpxEw Date: Wed, 16 Jan 2019 09:50:07 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258010D9047DB@irsmsx105.ger.corp.intel.com> References: <1547021995-14231-1-git-send-email-jiayu.hu@intel.com> <1547604822-9920-1-git-send-email-jiayu.hu@intel.com> In-Reply-To: <1547604822-9920-1-git-send-email-jiayu.hu@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGY1Yjk3ZDItZTU3NC00ZGYzLWJmNDYtYmU2NzQwZjI2YmFmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibGZJZ1JhOTlXa3hISW0yU3F2YTVrUE9iVnNYYjM5M2pFUUt2ZnpBd0tJaU9ZYm1FNm9ZbUNaTGU1NUY3Q2FydCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6] doc: add GRO limitations in prog_guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jan 2019 09:50:11 -0000 > -----Original Message----- > From: Hu, Jiayu > Sent: Wednesday, January 16, 2019 2:14 AM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; thomas@monjalon.n= et; Hu, Jiayu ; stable@dpdk.org > Subject: [PATCH v6] doc: add GRO limitations in prog_guide >=20 > This patch adds GRO limitations in the programmer guide. >=20 > Fixes: 2c900d09055e ("doc: add GRO guide") > Cc: stable@dpdk.org >=20 > Signed-off-by: Jiayu Hu > --- > changes in v6: > - add VLAN limitation > changes in v5: > - remove fix commit 9e0b9d2ec0f4 > changes in v4: > - update MBUF->l2_len/... requirement > changes in v3: > - add MBUF limitation > changes in v2: > - add fix commits > - add more limitations >=20 > doc/guides/prog_guide/generic_receive_offload_lib.rst | 19 +++++++++++++= ++++++ > 1 file changed, 19 insertions(+) >=20 > diff --git a/doc/guides/prog_guide/generic_receive_offload_lib.rst b/doc/= guides/prog_guide/generic_receive_offload_lib.rst > index 9c6a4d0..5b3fb91 100644 > --- a/doc/guides/prog_guide/generic_receive_offload_lib.rst > +++ b/doc/guides/prog_guide/generic_receive_offload_lib.rst > @@ -191,3 +191,22 @@ Header fields deciding if packets are neighbors incl= ude: > ignore IPv4 ID fields for the packets whose DF bit is 1. > Additionally, packets which have different value of DF bit can't > be merged. > + > +GRO Library Limitations > +----------------------- > + > +- GRO library uses MBUF->l2_len/l3_len/l4_len/outer_l2_len/ > + outer_l3_len/packet_type to get protocol headers for the > + input packet, rather than parsing the packet header. Therefore, > + before call GRO APIs to merge packets, user applications > + must set MBUF->l2_len/l3_len/l4_len/outer_l2_len/outer_l3_len/ > + packet_type to the same values as the protocol headers of the > + packet. > + > +- GRO library doesn't support to process the packets with IPv4 > + Options or VLAN tagged. > + > +- GRO library just supports to process the packet organized > + in a single MBUF. If the input packet consists of multiple > + MBUFs (i.e. chained MBUFs), GRO reassembly behaviors are > + unknown. > -- Acked-by: Konstantin Ananyev > 2.7.4