From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 56C721B4D1 for ; Thu, 21 Mar 2019 14:51:43 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Mar 2019 06:51:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,253,1549958400"; d="scan'208";a="133517351" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga008.fm.intel.com with ESMTP; 21 Mar 2019 06:51:40 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.210]) by IRSMSX153.ger.corp.intel.com ([169.254.9.83]) with mapi id 14.03.0415.000; Thu, 21 Mar 2019 13:51:40 +0000 From: "Ananyev, Konstantin" To: Shahaf Shuler , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" , "olivier.matz@6wind.com" Thread-Topic: [dpdk-dev] [PATCH v2 1/7] mbuf: new function to generate raw Tx offload value Thread-Index: AQHU36v4rVOZGE81HEmLu4/6fOKdGKYWGeTQ Date: Thu, 21 Mar 2019 13:51:39 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258013655E4F4@irsmsx105.ger.corp.intel.com> References: <1551381661-21078-1-git-send-email-konstantin.ananyev@intel.com> <20190320184655.17004-1-konstantin.ananyev@intel.com> <20190320184655.17004-2-konstantin.ananyev@intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWM0YTYwODQtYjcxZC00NzBiLWI0MmMtNWVkNzdhYzk4NGVjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiR25XTEtnUkdMdTFwMDVjdVB1TDlmdm1YcmtKeFdFVDVFWE40SEhcLzNtaXg3XC9YUk9DWmhxZW5OUHZzV0FrcFkwIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/7] mbuf: new function to generate raw Tx offload value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Mar 2019 13:51:43 -0000 Hi Shahaf, > Hi Konstantin, >=20 > Wednesday, March 20, 2019 8:47 PM, Konstantin Ananyev: > > Subject: [dpdk-dev] [PATCH v2 1/7] mbuf: new function to generate raw T= x > > offload value > > > > Operations to set/update bit-fields often cause compilers to generate > > suboptimal code. > > To help avoid such situation for tx_offload fields: > > introduce new enum for tx_offload bit-fields lengths and offsets, and n= ew > > function to generate raw tx_offload value. > > > > Signed-off-by: Konstantin Ananyev > > --- > > lib/librte_mbuf/rte_mbuf.h | 71 > > ++++++++++++++++++++++++++++++++++---- > > 1 file changed, 64 insertions(+), 7 deletions(-) > > > > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h in= dex > > d961ccaf6..b967ad17e 100644 > > --- a/lib/librte_mbuf/rte_mbuf.h > > +++ b/lib/librte_mbuf/rte_mbuf.h > > @@ -479,6 +479,26 @@ struct rte_mbuf_sched { > > uint16_t reserved; /**< Reserved. */ > > }; /**< Hierarchical scheduler */ > > > > +/** enum for the tx_offload bit-fields lenghts and offsets. */ enum { > > + RTE_MBUF_L2_LEN_BITS =3D 7, > > + RTE_MBUF_L3_LEN_BITS =3D 9, > > + RTE_MBUF_L4_LEN_BITS =3D 8, > > + RTE_MBUF_TSO_SEGSZ_BITS =3D 16, > > + RTE_MBUF_OL3_LEN_BITS =3D 9, > > + RTE_MBUF_OL2_LEN_BITS =3D 7, > > + RTE_MBUF_L2_LEN_OFS =3D 0, > > + RTE_MBUF_L3_LEN_OFS =3D RTE_MBUF_L2_LEN_OFS + > > RTE_MBUF_L2_LEN_BITS, > > + RTE_MBUF_L4_LEN_OFS =3D RTE_MBUF_L3_LEN_OFS + > > RTE_MBUF_L3_LEN_BITS, > > + RTE_MBUF_TSO_SEGSZ_OFS =3D RTE_MBUF_L4_LEN_OFS + > > RTE_MBUF_L4_LEN_BITS, > > + RTE_MBUF_OL3_LEN_OFS =3D RTE_MBUF_TSO_SEGSZ_OFS + > > RTE_MBUF_TSO_SEGSZ_BITS, > > + RTE_MBUF_OL2_LEN_OFS =3D RTE_MBUF_OL3_LEN_OFS + > > RTE_MBUF_OL3_LEN_BITS, > > + RTE_MBUF_TXOFLD_UNUSED_OFS =3D > > + RTE_MBUF_OL2_LEN_OFS + RTE_MBUF_OL2_LEN_BITS, > > + RTE_MBUF_TXOFLD_UNUSED_BITS =3D > > + sizeof(uint64_t) * CHAR_BIT - > > RTE_MBUF_TXOFLD_UNUSED_OFS, }; > > + > > /** > > * The generic rte_mbuf, containing a packet mbuf. > > */ > > @@ -640,19 +660,24 @@ struct rte_mbuf { > > uint64_t tx_offload; /**< combined for easy fetch */ > > __extension__ > > struct { > > - uint64_t l2_len:7; > > + uint64_t l2_len:RTE_MBUF_L2_LEN_BITS; > > /**< L2 (MAC) Header Length for non-tunneling pkt. > > * Outer_L4_len + ... + Inner_L2_len for tunneling > > pkt. > > */ > > - uint64_t l3_len:9; /**< L3 (IP) Header Length. */ > > - uint64_t l4_len:8; /**< L4 (TCP/UDP) Header Length. > > */ > > - uint64_t tso_segsz:16; /**< TCP TSO segment size */ > > + uint64_t l3_len:RTE_MBUF_L3_LEN_BITS; > > + /**< L3 (IP) Header Length. */ > > + uint64_t l4_len:RTE_MBUF_L4_LEN_BITS; > > + /**< L4 (TCP/UDP) Header Length. */ > > + uint64_t tso_segsz:RTE_MBUF_TSO_SEGSZ_BITS; > > + /**< TCP TSO segment size */ > > > > /* fields for TX offloading of tunnels */ > > - uint64_t outer_l3_len:9; /**< Outer L3 (IP) Hdr > > Length. */ > > - uint64_t outer_l2_len:7; /**< Outer L2 (MAC) Hdr > > Length. */ > > + uint64_t outer_l3_len:RTE_MBUF_OL3_LEN_BITS; > > + /**< Outer L3 (IP) Hdr Length. */ > > + uint64_t outer_l2_len:RTE_MBUF_OL2_LEN_BITS; > > + /**< Outer L2 (MAC) Hdr Length. */ > > > > - /* uint64_t unused:8; */ > > + /* uint64_t > > unused:RTE_MBUF_TXOFLD_UNUSED_BITS; */ >=20 > I am not sure we want to decide now that this remaining byte is for anoth= er Tx offloads. Not sure, I understand what is your concern here... tx_offload field is 8B long, see 'uint64_t tx_offload' above. All I did replaced raw number '8' with enum value ' RTE_MBUF_TXOFLD_UNUSED_= BITS' which also evalueate to 8. > Maybe it is better to change a bit the rte_mbuf_tx_offload API to receive= also the mbuf and to assign the offload values w/ mask. Could you explain a bit more what do you suggest here? Konstantin >=20 > > }; > > }; > > > > @@ -2243,6 +2268,38 @@ static inline int rte_pktmbuf_chain(struct > > rte_mbuf *head, struct rte_mbuf *tail > > return 0; > > } > > > > +/* > > + * @warning > > + * @b EXPERIMENTAL: This API may change without prior notice. > > + * > > + * For given input values generate raw tx_offload value. > > + * @param il2 > > + * l2_len value. > > + * @param il3 > > + * l3_len value. > > + * @param il4 > > + * l4_len value. > > + * @param tso > > + * tso_segsz value. > > + * @param ol3 > > + * outer_l3_len value. > > + * @param ol2 > > + * outer_l2_len value. > > + * @return > > + * raw tx_offload value. > > + */ > > +static inline uint64_t > > +rte_mbuf_tx_offload(uint64_t il2, uint64_t il3, uint64_t il4, uint64_t= tso, > > + uint64_t ol3, uint64_t ol2) > > +{ > > + return il2 << RTE_MBUF_L2_LEN_OFS | > > + il3 << RTE_MBUF_L3_LEN_OFS | > > + il4 << RTE_MBUF_L4_LEN_OFS | > > + tso << RTE_MBUF_TSO_SEGSZ_OFS | > > + ol3 << RTE_MBUF_OL3_LEN_OFS | > > + ol2 << RTE_MBUF_OL2_LEN_OFS; > > +} > > + > > /** > > * Validate general requirements for Tx offload in mbuf. > > * > > -- > > 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D265FA00E6 for ; Thu, 21 Mar 2019 14:51:45 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E134C1B4D6; Thu, 21 Mar 2019 14:51:44 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 56C721B4D1 for ; Thu, 21 Mar 2019 14:51:43 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Mar 2019 06:51:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,253,1549958400"; d="scan'208";a="133517351" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga008.fm.intel.com with ESMTP; 21 Mar 2019 06:51:40 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.210]) by IRSMSX153.ger.corp.intel.com ([169.254.9.83]) with mapi id 14.03.0415.000; Thu, 21 Mar 2019 13:51:40 +0000 From: "Ananyev, Konstantin" To: Shahaf Shuler , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" , "olivier.matz@6wind.com" Thread-Topic: [dpdk-dev] [PATCH v2 1/7] mbuf: new function to generate raw Tx offload value Thread-Index: AQHU36v4rVOZGE81HEmLu4/6fOKdGKYWGeTQ Date: Thu, 21 Mar 2019 13:51:39 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258013655E4F4@irsmsx105.ger.corp.intel.com> References: <1551381661-21078-1-git-send-email-konstantin.ananyev@intel.com> <20190320184655.17004-1-konstantin.ananyev@intel.com> <20190320184655.17004-2-konstantin.ananyev@intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWM0YTYwODQtYjcxZC00NzBiLWI0MmMtNWVkNzdhYzk4NGVjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiR25XTEtnUkdMdTFwMDVjdVB1TDlmdm1YcmtKeFdFVDVFWE40SEhcLzNtaXg3XC9YUk9DWmhxZW5OUHZzV0FrcFkwIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/7] mbuf: new function to generate raw Tx offload value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190321135139.uR6lASq9gGBMsTHjgA_NdXOZSpCLEBDUgnAqXaGT7Iw@z> Hi Shahaf, > Hi Konstantin, >=20 > Wednesday, March 20, 2019 8:47 PM, Konstantin Ananyev: > > Subject: [dpdk-dev] [PATCH v2 1/7] mbuf: new function to generate raw T= x > > offload value > > > > Operations to set/update bit-fields often cause compilers to generate > > suboptimal code. > > To help avoid such situation for tx_offload fields: > > introduce new enum for tx_offload bit-fields lengths and offsets, and n= ew > > function to generate raw tx_offload value. > > > > Signed-off-by: Konstantin Ananyev > > --- > > lib/librte_mbuf/rte_mbuf.h | 71 > > ++++++++++++++++++++++++++++++++++---- > > 1 file changed, 64 insertions(+), 7 deletions(-) > > > > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h in= dex > > d961ccaf6..b967ad17e 100644 > > --- a/lib/librte_mbuf/rte_mbuf.h > > +++ b/lib/librte_mbuf/rte_mbuf.h > > @@ -479,6 +479,26 @@ struct rte_mbuf_sched { > > uint16_t reserved; /**< Reserved. */ > > }; /**< Hierarchical scheduler */ > > > > +/** enum for the tx_offload bit-fields lenghts and offsets. */ enum { > > + RTE_MBUF_L2_LEN_BITS =3D 7, > > + RTE_MBUF_L3_LEN_BITS =3D 9, > > + RTE_MBUF_L4_LEN_BITS =3D 8, > > + RTE_MBUF_TSO_SEGSZ_BITS =3D 16, > > + RTE_MBUF_OL3_LEN_BITS =3D 9, > > + RTE_MBUF_OL2_LEN_BITS =3D 7, > > + RTE_MBUF_L2_LEN_OFS =3D 0, > > + RTE_MBUF_L3_LEN_OFS =3D RTE_MBUF_L2_LEN_OFS + > > RTE_MBUF_L2_LEN_BITS, > > + RTE_MBUF_L4_LEN_OFS =3D RTE_MBUF_L3_LEN_OFS + > > RTE_MBUF_L3_LEN_BITS, > > + RTE_MBUF_TSO_SEGSZ_OFS =3D RTE_MBUF_L4_LEN_OFS + > > RTE_MBUF_L4_LEN_BITS, > > + RTE_MBUF_OL3_LEN_OFS =3D RTE_MBUF_TSO_SEGSZ_OFS + > > RTE_MBUF_TSO_SEGSZ_BITS, > > + RTE_MBUF_OL2_LEN_OFS =3D RTE_MBUF_OL3_LEN_OFS + > > RTE_MBUF_OL3_LEN_BITS, > > + RTE_MBUF_TXOFLD_UNUSED_OFS =3D > > + RTE_MBUF_OL2_LEN_OFS + RTE_MBUF_OL2_LEN_BITS, > > + RTE_MBUF_TXOFLD_UNUSED_BITS =3D > > + sizeof(uint64_t) * CHAR_BIT - > > RTE_MBUF_TXOFLD_UNUSED_OFS, }; > > + > > /** > > * The generic rte_mbuf, containing a packet mbuf. > > */ > > @@ -640,19 +660,24 @@ struct rte_mbuf { > > uint64_t tx_offload; /**< combined for easy fetch */ > > __extension__ > > struct { > > - uint64_t l2_len:7; > > + uint64_t l2_len:RTE_MBUF_L2_LEN_BITS; > > /**< L2 (MAC) Header Length for non-tunneling pkt. > > * Outer_L4_len + ... + Inner_L2_len for tunneling > > pkt. > > */ > > - uint64_t l3_len:9; /**< L3 (IP) Header Length. */ > > - uint64_t l4_len:8; /**< L4 (TCP/UDP) Header Length. > > */ > > - uint64_t tso_segsz:16; /**< TCP TSO segment size */ > > + uint64_t l3_len:RTE_MBUF_L3_LEN_BITS; > > + /**< L3 (IP) Header Length. */ > > + uint64_t l4_len:RTE_MBUF_L4_LEN_BITS; > > + /**< L4 (TCP/UDP) Header Length. */ > > + uint64_t tso_segsz:RTE_MBUF_TSO_SEGSZ_BITS; > > + /**< TCP TSO segment size */ > > > > /* fields for TX offloading of tunnels */ > > - uint64_t outer_l3_len:9; /**< Outer L3 (IP) Hdr > > Length. */ > > - uint64_t outer_l2_len:7; /**< Outer L2 (MAC) Hdr > > Length. */ > > + uint64_t outer_l3_len:RTE_MBUF_OL3_LEN_BITS; > > + /**< Outer L3 (IP) Hdr Length. */ > > + uint64_t outer_l2_len:RTE_MBUF_OL2_LEN_BITS; > > + /**< Outer L2 (MAC) Hdr Length. */ > > > > - /* uint64_t unused:8; */ > > + /* uint64_t > > unused:RTE_MBUF_TXOFLD_UNUSED_BITS; */ >=20 > I am not sure we want to decide now that this remaining byte is for anoth= er Tx offloads. Not sure, I understand what is your concern here... tx_offload field is 8B long, see 'uint64_t tx_offload' above. All I did replaced raw number '8' with enum value ' RTE_MBUF_TXOFLD_UNUSED_= BITS' which also evalueate to 8. > Maybe it is better to change a bit the rte_mbuf_tx_offload API to receive= also the mbuf and to assign the offload values w/ mask. Could you explain a bit more what do you suggest here? Konstantin >=20 > > }; > > }; > > > > @@ -2243,6 +2268,38 @@ static inline int rte_pktmbuf_chain(struct > > rte_mbuf *head, struct rte_mbuf *tail > > return 0; > > } > > > > +/* > > + * @warning > > + * @b EXPERIMENTAL: This API may change without prior notice. > > + * > > + * For given input values generate raw tx_offload value. > > + * @param il2 > > + * l2_len value. > > + * @param il3 > > + * l3_len value. > > + * @param il4 > > + * l4_len value. > > + * @param tso > > + * tso_segsz value. > > + * @param ol3 > > + * outer_l3_len value. > > + * @param ol2 > > + * outer_l2_len value. > > + * @return > > + * raw tx_offload value. > > + */ > > +static inline uint64_t > > +rte_mbuf_tx_offload(uint64_t il2, uint64_t il3, uint64_t il4, uint64_t= tso, > > + uint64_t ol3, uint64_t ol2) > > +{ > > + return il2 << RTE_MBUF_L2_LEN_OFS | > > + il3 << RTE_MBUF_L3_LEN_OFS | > > + il4 << RTE_MBUF_L4_LEN_OFS | > > + tso << RTE_MBUF_TSO_SEGSZ_OFS | > > + ol3 << RTE_MBUF_OL3_LEN_OFS | > > + ol2 << RTE_MBUF_OL2_LEN_OFS; > > +} > > + > > /** > > * Validate general requirements for Tx offload in mbuf. > > * > > -- > > 2.17.1