From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 85483378B for ; Tue, 2 Apr 2019 12:53:55 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Apr 2019 03:53:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,300,1549958400"; d="scan'208";a="139445794" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga007.fm.intel.com with ESMTP; 02 Apr 2019 03:53:53 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.210]) by IRSMSX151.ger.corp.intel.com ([169.254.4.91]) with mapi id 14.03.0415.000; Tue, 2 Apr 2019 11:53:52 +0100 From: "Ananyev, Konstantin" To: "Ananyev, Konstantin" , Honnappa Nagarahalli , "stephen@networkplumber.org" , "paulmck@linux.ibm.com" , "Kovacevic, Marko" , "dev@dpdk.org" CC: "gavin.hu@arm.com" , "dharmik.thakkar@arm.com" , "malvika.gupta@arm.com" Thread-Topic: [dpdk-dev] [PATCH v3 1/3] rcu: add RCU library supporting QSBR mechanism Thread-Index: AQHU6T4gCNrWl8QpEUChAQH5sFEj0qYor6IQ Date: Tue, 2 Apr 2019 10:53:51 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258013656343F@irsmsx105.ger.corp.intel.com> References: <20181122033055.3431-1-honnappa.nagarahalli@arm.com> <20190401171102.20168-1-honnappa.nagarahalli@arm.com> <20190401171102.20168-2-honnappa.nagarahalli@arm.com> <2601191342CEEE43887BDE71AB97725801365633FA@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB97725801365633FA@irsmsx105.ger.corp.intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTk4NjE3MjItNjNmOS00Yzc3LTg4M2QtMGM5NWQ3YTc5ZWYzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMTY4UVwvTU1QeWhHU0NoZERGdzZZQXUySjc2UG9NU00xY2hHQ1VqK05MXC9UYW0zbUd5XC9iVjV5RTdHbTFGbk50UyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/3] rcu: add RCU library supporting QSBR mechanism X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 10:53:56 -0000 >=20 > > Add RCU library supporting quiescent state based memory reclamation met= hod. > > This library helps identify the quiescent state of the reader threads s= o > > that the writers can free the memory associated with the lock less data > > structures. > > > > Signed-off-by: Honnappa Nagarahalli > > Reviewed-by: Steve Capper > > Reviewed-by: Gavin Hu > > Reviewed-by: Ola Liljedahl > > --- > > -- >=20 > Acked-by: Konstantin Ananyev >=20 > > 2.17.1 Actually one small thing: while doing make all seeing the following error after patch #2: In file included from /local/kananye1/dpdk.rcu1/app/test/test_rcu_qsbr_perf= .c:8:0: /local/kananye1/dpdk.rcu1/x86_64-native-linuxapp-gcc-aesmb/include/rte_rcu_= qsbr.h: In function =E2rte_rcu_qsbr_thread_online=E2: /local/kananye1/dpdk.rcu1/x86_64-native-linuxapp-gcc-aesmb/include/rte_rcu_= qsbr.h:235:2: error: implicit declaration of function =E2rte_smp_mb=E2 [-We= rror=3Dimplicit-function-declaration] rte_smp_mb(); ^~~~~~~~~~ Fixed by --- a/lib/librte_rcu/rte_rcu_qsbr.h +++ b/lib/librte_rcu/rte_rcu_qsbr.h @@ -31,6 +31,7 @@ extern "C" { #include #include #include +#include From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 6316FA0679 for ; Tue, 2 Apr 2019 12:53:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C0DF93798; Tue, 2 Apr 2019 12:53:57 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 85483378B for ; Tue, 2 Apr 2019 12:53:55 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Apr 2019 03:53:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,300,1549958400"; d="scan'208";a="139445794" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga007.fm.intel.com with ESMTP; 02 Apr 2019 03:53:53 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.210]) by IRSMSX151.ger.corp.intel.com ([169.254.4.91]) with mapi id 14.03.0415.000; Tue, 2 Apr 2019 11:53:52 +0100 From: "Ananyev, Konstantin" To: "Ananyev, Konstantin" , Honnappa Nagarahalli , "stephen@networkplumber.org" , "paulmck@linux.ibm.com" , "Kovacevic, Marko" , "dev@dpdk.org" CC: "gavin.hu@arm.com" , "dharmik.thakkar@arm.com" , "malvika.gupta@arm.com" Thread-Topic: [dpdk-dev] [PATCH v3 1/3] rcu: add RCU library supporting QSBR mechanism Thread-Index: AQHU6T4gCNrWl8QpEUChAQH5sFEj0qYor6IQ Date: Tue, 2 Apr 2019 10:53:51 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258013656343F@irsmsx105.ger.corp.intel.com> References: <20181122033055.3431-1-honnappa.nagarahalli@arm.com> <20190401171102.20168-1-honnappa.nagarahalli@arm.com> <20190401171102.20168-2-honnappa.nagarahalli@arm.com> <2601191342CEEE43887BDE71AB97725801365633FA@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB97725801365633FA@irsmsx105.ger.corp.intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTk4NjE3MjItNjNmOS00Yzc3LTg4M2QtMGM5NWQ3YTc5ZWYzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMTY4UVwvTU1QeWhHU0NoZERGdzZZQXUySjc2UG9NU00xY2hHQ1VqK05MXC9UYW0zbUd5XC9iVjV5RTdHbTFGbk50UyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/3] rcu: add RCU library supporting QSBR mechanism X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402105351.-vSzJ2MZRGdPys1GF3IvoZ414P_x3gyl6L26fVQz8Eg@z> >=20 > > Add RCU library supporting quiescent state based memory reclamation met= hod. > > This library helps identify the quiescent state of the reader threads s= o > > that the writers can free the memory associated with the lock less data > > structures. > > > > Signed-off-by: Honnappa Nagarahalli > > Reviewed-by: Steve Capper > > Reviewed-by: Gavin Hu > > Reviewed-by: Ola Liljedahl > > --- > > -- >=20 > Acked-by: Konstantin Ananyev >=20 > > 2.17.1 Actually one small thing: while doing make all seeing the following error after patch #2: In file included from /local/kananye1/dpdk.rcu1/app/test/test_rcu_qsbr_perf= .c:8:0: /local/kananye1/dpdk.rcu1/x86_64-native-linuxapp-gcc-aesmb/include/rte_rcu_= qsbr.h: In function =E2rte_rcu_qsbr_thread_online=E2: /local/kananye1/dpdk.rcu1/x86_64-native-linuxapp-gcc-aesmb/include/rte_rcu_= qsbr.h:235:2: error: implicit declaration of function =E2rte_smp_mb=E2 [-We= rror=3Dimplicit-function-declaration] rte_smp_mb(); ^~~~~~~~~~ Fixed by --- a/lib/librte_rcu/rte_rcu_qsbr.h +++ b/lib/librte_rcu/rte_rcu_qsbr.h @@ -31,6 +31,7 @@ extern "C" { #include #include #include +#include