From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id A08A71B49C for ; Fri, 5 Apr 2019 11:36:23 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Apr 2019 02:36:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,312,1549958400"; d="scan'208";a="146819643" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by FMSMGA003.fm.intel.com with ESMTP; 05 Apr 2019 02:36:21 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.31]) by IRSMSX152.ger.corp.intel.com ([169.254.6.225]) with mapi id 14.03.0415.000; Fri, 5 Apr 2019 10:36:21 +0100 From: "Ananyev, Konstantin" To: "Zhang, Qi Z" , "Yigit, Ferruh" , "Zhang, Qi Z" , "Iremonger, Bernard" CC: "dev@dpdk.org" , "Yang, Qiming" Thread-Topic: [dpdk-dev] [PATCH v5 1/5] ethdev: add VXLAN-GPE macro Thread-Index: AQHU646PZ8IkpjWhnEiiJky9WRr/l6YtTspw Date: Fri, 5 Apr 2019 09:36:20 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772580148A936FF@irsmsx105.ger.corp.intel.com> References: <20190405090535.7604-1-qi.z.zhang@intel.com> <20190405090535.7604-2-qi.z.zhang@intel.com> In-Reply-To: <20190405090535.7604-2-qi.z.zhang@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGQxYjM3MGItZGY0ZC00MzQ2LWJkYjMtMGMwNDBjYmQ0YjZiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYnRIWlQ1SVJ2V3hqQW1hSGlud21IbUlMbzRUaklqeCtGOHFKWTR6dENleVhvSjViT0s2YitGdnpLNDlKb0lTRCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 1/5] ethdev: add VXLAN-GPE macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Apr 2019 09:36:24 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qi Zhang > Sent: Friday, April 5, 2019 10:06 AM > To: Yigit, Ferruh ; Zhang, Qi Z ; Iremonger, Bernard > Cc: dev@dpdk.org; Yang, Qiming > Subject: [dpdk-dev] [PATCH v5 1/5] ethdev: add VXLAN-GPE macro >=20 > From: Qiming Yang >=20 > This patch added VXLAN-GPE macro in rte_eth_tunnel_type. > This patch will break the ABI, RTE_TUNNEL_TYPE_MAX will have > problem when running with new version of the ethdev shared > library. >=20 > Signed-off-by: Qiming Yang > --- > lib/librte_ethdev/rte_eth_ctrl.h | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/lib/librte_ethdev/rte_eth_ctrl.h b/lib/librte_ethdev/rte_eth= _ctrl.h > index 5ea8ae24c..b3416341b 100644 > --- a/lib/librte_ethdev/rte_eth_ctrl.h > +++ b/lib/librte_ethdev/rte_eth_ctrl.h > @@ -229,6 +229,7 @@ enum rte_eth_tunnel_type { > RTE_TUNNEL_TYPE_NVGRE, > RTE_TUNNEL_TYPE_IP_IN_GRE, > RTE_L2_TUNNEL_TYPE_E_TAG, > + RTE_TUNNEL_TYPE_VXLAN_GPE, Not sure, why do you consider it as an ABI breakage? Konstantin > RTE_TUNNEL_TYPE_MAX, > }; >=20 > -- > 2.13.6 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4CB36A0679 for ; Fri, 5 Apr 2019 11:36:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E1ADA1B4A0; Fri, 5 Apr 2019 11:36:24 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id A08A71B49C for ; Fri, 5 Apr 2019 11:36:23 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Apr 2019 02:36:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,312,1549958400"; d="scan'208";a="146819643" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by FMSMGA003.fm.intel.com with ESMTP; 05 Apr 2019 02:36:21 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.31]) by IRSMSX152.ger.corp.intel.com ([169.254.6.225]) with mapi id 14.03.0415.000; Fri, 5 Apr 2019 10:36:21 +0100 From: "Ananyev, Konstantin" To: "Zhang, Qi Z" , "Yigit, Ferruh" , "Zhang, Qi Z" , "Iremonger, Bernard" CC: "dev@dpdk.org" , "Yang, Qiming" Thread-Topic: [dpdk-dev] [PATCH v5 1/5] ethdev: add VXLAN-GPE macro Thread-Index: AQHU646PZ8IkpjWhnEiiJky9WRr/l6YtTspw Date: Fri, 5 Apr 2019 09:36:20 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772580148A936FF@irsmsx105.ger.corp.intel.com> References: <20190405090535.7604-1-qi.z.zhang@intel.com> <20190405090535.7604-2-qi.z.zhang@intel.com> In-Reply-To: <20190405090535.7604-2-qi.z.zhang@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGQxYjM3MGItZGY0ZC00MzQ2LWJkYjMtMGMwNDBjYmQ0YjZiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYnRIWlQ1SVJ2V3hqQW1hSGlud21IbUlMbzRUaklqeCtGOHFKWTR6dENleVhvSjViT0s2YitGdnpLNDlKb0lTRCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 1/5] ethdev: add VXLAN-GPE macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190405093620.4pjanJaV2wFGVKCSR78FEGBt0yoaxewF72jPoIutQWs@z> > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qi Zhang > Sent: Friday, April 5, 2019 10:06 AM > To: Yigit, Ferruh ; Zhang, Qi Z ; Iremonger, Bernard > Cc: dev@dpdk.org; Yang, Qiming > Subject: [dpdk-dev] [PATCH v5 1/5] ethdev: add VXLAN-GPE macro >=20 > From: Qiming Yang >=20 > This patch added VXLAN-GPE macro in rte_eth_tunnel_type. > This patch will break the ABI, RTE_TUNNEL_TYPE_MAX will have > problem when running with new version of the ethdev shared > library. >=20 > Signed-off-by: Qiming Yang > --- > lib/librte_ethdev/rte_eth_ctrl.h | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/lib/librte_ethdev/rte_eth_ctrl.h b/lib/librte_ethdev/rte_eth= _ctrl.h > index 5ea8ae24c..b3416341b 100644 > --- a/lib/librte_ethdev/rte_eth_ctrl.h > +++ b/lib/librte_ethdev/rte_eth_ctrl.h > @@ -229,6 +229,7 @@ enum rte_eth_tunnel_type { > RTE_TUNNEL_TYPE_NVGRE, > RTE_TUNNEL_TYPE_IP_IN_GRE, > RTE_L2_TUNNEL_TYPE_E_TAG, > + RTE_TUNNEL_TYPE_VXLAN_GPE, Not sure, why do you consider it as an ABI breakage? Konstantin > RTE_TUNNEL_TYPE_MAX, > }; >=20 > -- > 2.13.6