From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Olivier Matz <olivier.matz@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] mbuf: fix big endian build
Date: Tue, 9 Apr 2019 22:55:51 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB9772580148A94ED9@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <20190409200636.2193-2-thomas@monjalon.net>
>
> Compilation was failing when using a big endian toolchain:
>
> rte_mbuf.h:504:2: error: expected ',' or '}' before 'RTE_MBUF_L3_LEN_OFS'
>
> Fixes: 8d9c2c3a1f01 ("mbuf: add function to generate raw Tx offload value")
> Cc: konstantin.ananyev@intel.com
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> lib/librte_mbuf/rte_mbuf.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> index f7886dcb3..7dd2e7fb3 100644
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -500,7 +500,7 @@ enum {
> RTE_MBUF_OUTL2_LEN_BITS,
> #if RTE_BYTE_ORDER == RTE_BIG_ENDIAN
> RTE_MBUF_L2_LEN_OFS =
> - sizeof(uint64_t) * CHAR_BIT - RTE_MBUF_L2_LEN_BITS
> + sizeof(uint64_t) * CHAR_BIT - RTE_MBUF_L2_LEN_BITS,
> RTE_MBUF_L3_LEN_OFS = RTE_MBUF_L2_LEN_OFS - RTE_MBUF_L3_LEN_BITS,
> RTE_MBUF_L4_LEN_OFS = RTE_MBUF_L3_LEN_OFS - RTE_MBUF_L4_LEN_BITS,
> RTE_MBUF_TSO_SEGSZ_OFS = RTE_MBUF_L4_LEN_OFS - RTE_MBUF_TSO_SEGSZ_BITS,
> --
Thanks for fixing
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 2.21.0
next prev parent reply other threads:[~2019-04-09 22:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 19:49 [dpdk-dev] [PATCH 0/2] " Thomas Monjalon
2019-04-09 19:49 ` Thomas Monjalon
2019-04-09 19:49 ` [dpdk-dev] [PATCH 1/2] mbuf: " Thomas Monjalon
2019-04-09 19:49 ` Thomas Monjalon
2019-04-09 19:49 ` [dpdk-dev] [PATCH 2/2] net/enetc: " Thomas Monjalon
2019-04-09 19:49 ` Thomas Monjalon
2019-04-09 20:06 ` [dpdk-dev] [PATCH v2 0/2] " Thomas Monjalon
2019-04-09 20:06 ` Thomas Monjalon
2019-04-09 20:06 ` [dpdk-dev] [PATCH v2 1/2] mbuf: " Thomas Monjalon
2019-04-09 20:06 ` Thomas Monjalon
2019-04-09 22:55 ` Ananyev, Konstantin [this message]
2019-04-09 22:55 ` Ananyev, Konstantin
2019-04-22 13:28 ` Thomas Monjalon
2019-04-22 13:28 ` Thomas Monjalon
2019-04-09 20:06 ` [dpdk-dev] [PATCH v2 2/2] net/enetc: " Thomas Monjalon
2019-04-09 20:06 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB9772580148A94ED9@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).