From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 26C79A49 for ; Tue, 7 May 2019 12:40:57 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 May 2019 03:40:55 -0700 X-ExtLoop1: 1 Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga007.jf.intel.com with ESMTP; 07 May 2019 03:40:54 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.31]) by IRSMSX102.ger.corp.intel.com ([169.254.2.21]) with mapi id 14.03.0415.000; Tue, 7 May 2019 11:40:54 +0100 From: "Ananyev, Konstantin" To: David Christensen , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 2/4] test: verify calloc succeeded for sum variable Thread-Index: AQHVBEFFiaHKCIFAvU6Lw9BxsPKwk6Zfehww Date: Tue, 7 May 2019 10:40:54 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772580148AA21AA@irsmsx105.ger.corp.intel.com> References: <1557170620-99694-1-git-send-email-drc@linux.vnet.ibm.com> In-Reply-To: <1557170620-99694-1-git-send-email-drc@linux.vnet.ibm.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjkyY2FmYmYtODAyNS00ODhjLWEzMWUtYzUzNmE1OTc1MjcwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiN3RtbE1hNmdKWjl2dTZEbll6c0pLOW9IbDlNXC81TlluOUU1ZnJIVzlBQWdFUHZRd0VzVXhETE5Valc5ZTVDSHUifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/4] test: verify calloc succeeded for sum variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 May 2019 10:40:57 -0000 > Code tested calloc failures for pt & lpt variables > but not for the sum variable. Add a test for calloc > failure of sum. >=20 > Signed-off-by: David Christensen > --- > v2: > * Removed change to ITER_MAX >=20 > app/test/test_barrier.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/app/test/test_barrier.c b/app/test/test_barrier.c > index c219d56..ae37b1e 100644 > --- a/app/test/test_barrier.c > +++ b/app/test/test_barrier.c > @@ -202,7 +202,7 @@ struct lcore_plock_test { > printf("%s(iter=3D%u, utype=3D%u) started on %u lcores\n", > __func__, iter, utype, n); >=20 > - if (pt =3D=3D NULL || lpt =3D=3D NULL) { > + if (pt =3D=3D NULL || lpt =3D=3D NULL || sum =3D=3D NULL) { > printf("%s: failed to allocate memory for %u lcores\n", > __func__, n); > free(pt); > -- Acked-by: Konstantin Ananyev > 1.8.3.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 36B21A0096 for ; Tue, 7 May 2019 12:40:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0D6CE2BB8; Tue, 7 May 2019 12:40:58 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 26C79A49 for ; Tue, 7 May 2019 12:40:57 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 May 2019 03:40:55 -0700 X-ExtLoop1: 1 Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga007.jf.intel.com with ESMTP; 07 May 2019 03:40:54 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.31]) by IRSMSX102.ger.corp.intel.com ([169.254.2.21]) with mapi id 14.03.0415.000; Tue, 7 May 2019 11:40:54 +0100 From: "Ananyev, Konstantin" To: David Christensen , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 2/4] test: verify calloc succeeded for sum variable Thread-Index: AQHVBEFFiaHKCIFAvU6Lw9BxsPKwk6Zfehww Date: Tue, 7 May 2019 10:40:54 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772580148AA21AA@irsmsx105.ger.corp.intel.com> References: <1557170620-99694-1-git-send-email-drc@linux.vnet.ibm.com> In-Reply-To: <1557170620-99694-1-git-send-email-drc@linux.vnet.ibm.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjkyY2FmYmYtODAyNS00ODhjLWEzMWUtYzUzNmE1OTc1MjcwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiN3RtbE1hNmdKWjl2dTZEbll6c0pLOW9IbDlNXC81TlluOUU1ZnJIVzlBQWdFUHZRd0VzVXhETE5Valc5ZTVDSHUifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/4] test: verify calloc succeeded for sum variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190507104054.Tx1CzMmX2pZJ_KkJLf-hqLaeMJFuCtWTAEGzqnJCkyQ@z> > Code tested calloc failures for pt & lpt variables > but not for the sum variable. Add a test for calloc > failure of sum. >=20 > Signed-off-by: David Christensen > --- > v2: > * Removed change to ITER_MAX >=20 > app/test/test_barrier.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/app/test/test_barrier.c b/app/test/test_barrier.c > index c219d56..ae37b1e 100644 > --- a/app/test/test_barrier.c > +++ b/app/test/test_barrier.c > @@ -202,7 +202,7 @@ struct lcore_plock_test { > printf("%s(iter=3D%u, utype=3D%u) started on %u lcores\n", > __func__, iter, utype, n); >=20 > - if (pt =3D=3D NULL || lpt =3D=3D NULL) { > + if (pt =3D=3D NULL || lpt =3D=3D NULL || sum =3D=3D NULL) { > printf("%s: failed to allocate memory for %u lcores\n", > __func__, n); > free(pt); > -- Acked-by: Konstantin Ananyev > 1.8.3.1